Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 628688 - media-gfx/converseen-0.9.6.2 - add support for media-gfx/graphicsmagick (was: 0.9.6.2 version bump request)
Summary: media-gfx/converseen-0.9.6.2 - add support for media-gfx/graphicsmagick (was:...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL: http://converseen.fasterland.net/chan...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2017-08-23 08:02 UTC by Sergey Torokhov
Modified: 2021-01-17 19:59 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
media-gfx/converseen-0.9.6.2.ebuild (converseen-0.9.6.2.ebuild,1.20 KB, text/plain)
2017-08-23 08:04 UTC, Sergey Torokhov
Details
media-gfx/converseen-0.9.6.2.ebuild (converseen-0.9.6.2.ebuild,1.20 KB, text/plain)
2017-08-23 08:20 UTC, Sergey Torokhov
Details
media-gfx/converseen-0.9.6.2.ebuild (converseen-0.9.6.2.ebuild,1.19 KB, text/plain)
2017-08-23 08:34 UTC, Sergey Torokhov
Details
converseen-0.9.6.2-r1_graphicsmagick.diff (converseen-0.9.6.2-r1_graphicsmagick.diff,2.16 KB, patch)
2017-09-17 00:13 UTC, Sergey Torokhov
Details | Diff
converseen-0.9.6.2-r1.ebuild (converseen-0.9.6.2-r1.ebuild,1.35 KB, text/plain)
2017-09-17 00:14 UTC, Sergey Torokhov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Torokhov 2017-08-23 08:02:48 UTC
Converseen-0.9.6.2 was released on 28 feb 2017. 

Gwenview:5 has no batch images processing more due to absence of it in kipi-plugins:5 as this functions was moved directly to digikam code. 

Current version of converseen in Gentoo tree is 0.6.8 and depends on Qt4. 

Please review attached .ebuild to update media-gfx/converseen package. 

Reproducible: Always
Comment 1 Sergey Torokhov 2017-08-23 08:04:04 UTC
Created attachment 490194 [details]
media-gfx/converseen-0.9.6.2.ebuild
Comment 2 Sergey Torokhov 2017-08-23 08:14:17 UTC
Comment on attachment 490194 [details]
media-gfx/converseen-0.9.6.2.ebuild

># Copyright 1999-2017 Gentoo Foundation
># Distributed under the terms of the GNU General Public License v2
>
>#EAPI="5"
>EAPI="6"
>LANGSLONG="cs_CZ da_DK de_DE fr_FR hu_HU it_IT ja_JP pl_PL pt_BR ru_RU tr_TR"
>LANGS="es_CL"
>
>inherit cmake-utils
>
>DESCRIPTION="Batch image converter and resizer based on ImageMagick"
>HOMEPAGE="http://converseen.sourceforge.net"
>RESTRICT="mirror"
>SRC_URI="mirror://sourceforge/${PN}/${P}.tar.bz2"
>
>LICENSE="GPL-3"
>SLOT="0"
>KEYWORDS="~amd64 ~x86"
>IUSE="debug"
>for x in ${LANGS}; do
>	IUSE="${IUSE} linguas_${x}"
>done
>for x in ${LANGSLONG}; do
>	IUSE="${IUSE} linguas_${x%_*}"
>done
>
># FIXME: graphicsmagick dependency does not work properly, failures when compiling
>#	|| ( media-gfx/imagemagick[cxx] media-gfx/graphicsmagick[cxx,imagemagick] )
>RDEPEND="
>	dev-qt/qtcore:5
>	dev-qt/qtgui:5
>	media-gfx/imagemagick:=[cxx]
>"
>DEPEND="${RDEPEND}"
>
>DOCS=( README.md )
>
>src_prepare() {
>	for x in ${LANGSLONG}; do
>		if use !linguas_${x%_*}; then
>			rm -f "loc/${PN}_${x}."* || die
>			sed -i -e "\,/${PN}_${x}\...,d" CMakeLists.txt || die
>		fi
>	done
>	for x in ${LANGS}; do
>		if use !linguas_${x}; then
>			rm -f "loc/${PN}_${x}."* || die
>			sed -i -e "\,/${PN}_${x}\...,d" CMakeLists.txt || die
>		fi
>	done
>	eapply_user
>}
Comment 3 Sergey Torokhov 2017-08-23 08:17:51 UTC
Sorry, I forgot to add "da_DK" LANGSLONG use flag to initial ebuild.
Comment 4 Sergey Torokhov 2017-08-23 08:20:30 UTC
Created attachment 490196 [details]
media-gfx/converseen-0.9.6.2.ebuild
Comment 5 Sergey Torokhov 2017-08-23 08:34:53 UTC
Created attachment 490198 [details]
media-gfx/converseen-0.9.6.2.ebuild
Comment 6 Sergey Torokhov 2017-09-13 12:20:26 UTC
It seems I found the way to compile Converseen with GraphicsMagick[cxx,imagemagick] versus ImageMagick[cxx] but it needs FindGraphicsMagick.cmake and LibFindMacros.cmake from Darktable project 
(https://github.com/darktable-org/darktable/tree/master/cmake/modules) 
and also some modification of ./CMakLIsts.txt and ./src{converter.cpp,globals.h} files.

I successfully build modified sources, launch Converseen and "Resize" -> 50% several jpg-files.
I need some additional tests before uploading patch if it requires for this .ebuild.
Comment 7 Sergey Torokhov 2017-09-17 00:13:22 UTC
Created attachment 494788 [details, diff]
converseen-0.9.6.2-r1_graphicsmagick.diff

Patch that allows to build and use Converseen(-0.9.6.2-r1) with media-gfx/graphicsmagick[cxx,imagemagick] backend instead of media-gfx/imagemagick[cxx] ones.

I decided not to use external .cmake files (FindGraphicsMagick.cmake and LibFindMacros.cmake from Darktable project) ad just modified ./CMakLIsts.txt and ./src{converter.cpp,globals.h} files.

With builded in graphicsmagick successfully resize, rotate and flip images.

But for 1 file I got the entirely black image after change format form png to jpg via Converseen, while "convert test.png -resize 50% test.jpg" results normal image.
Comment 8 Sergey Torokhov 2017-09-17 00:14:42 UTC
Created attachment 494790 [details]
converseen-0.9.6.2-r1.ebuild
Comment 9 Larry the Git Cow gentoo-dev 2018-01-09 01:23:03 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4f01d583d3b144b0d102c7f9bc6cabcdff60eefe

commit 4f01d583d3b144b0d102c7f9bc6cabcdff60eefe
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-01-09 01:15:13 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-01-09 01:22:45 +0000

    media-gfx/converseen: 0.9.6.2 version bump
    
    Thanks-to: Sergey Torokhov <torokhov_s_a@mail.ru>
    Bug: https://bugs.gentoo.org/628688
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 media-gfx/converseen/Manifest                      |  1 +
 media-gfx/converseen/converseen-0.9.6.2.ebuild     | 32 +++++++++++
 .../files/converseen-0.9.6.2-gnuinstalldirs.patch  | 64 ++++++++++++++++++++++
 media-gfx/converseen/metadata.xml                  |  2 +-
 4 files changed, 98 insertions(+), 1 deletion(-)}
Comment 10 Andreas Sturmlechner gentoo-dev 2018-01-09 01:25:12 UTC
(In reply to Sergey Torokhov from comment #7)
> Created attachment 494788 [details, diff] [details, diff]
> converseen-0.9.6.2-r1_graphicsmagick.diff
Thanks for your work. This patch should be submitted upstream. I guess for upstream, the cmake-module approach would be better. No need to reinvent the wheel when there are existing solutions.
Comment 11 Jonas Stein gentoo-dev 2021-01-17 19:59:14 UTC
version bump was done by asturm. -no graphicsmagick support