Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 627468 - xfce-extra/xfce4-sensors-plugin-1.2.98: cannot compile hddtemp.c
Summary: xfce-extra/xfce4-sensors-plugin-1.2.98: cannot compile hddtemp.c
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2017-08-10 16:59 UTC by Felix J. Ogris
Modified: 2019-01-24 20:25 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
my emerge --info (emerge-info.txt,6.58 KB, text/plain)
2017-08-10 16:59 UTC, Felix J. Ogris
Details
patch to compile hddtemp.c (xfce4-sensors-plugin-1.2.98-gtk.patch,1.44 KB, patch)
2017-08-10 17:01 UTC, Felix J. Ogris
Details | Diff
build log (build.log.tgz,4.94 KB, application/x-compressed-tar)
2018-05-11 18:54 UTC, Norman Shulman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Felix J. Ogris 2017-08-10 16:59:02 UTC
Created attachment 488506 [details]
my emerge --info

lib/hddtemp.c does not build due to typos and issues w/ glib/gtk. I'm attaching a patch below. 

libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I../include -DNDEBUG -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -DPACKAGE_LOCALE_DIR=\"/usr/share/locale\" -pthread -I/usr/include/xfce4/libxfce4ui-2 -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/xfce4 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/include/xfce4/libxfce4panel-2.0 -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/xfce4 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include -I/usr/include/NVCtrl -O2 -pipe -march=nocona -c hddtemp.c  -fPIC -DPIC -o .libs/libxfce4sensors_la-hddtemp.o
In file included from /usr/include/glib-2.0/gobject/gobject.h:24:0,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from /usr/include/xfce4/libxfce4util/xfce-kiosk.h:30,
                 from /usr/include/xfce4/libxfce4util/libxfce4util.h:33,
                 from ../include/types.h:31,
                 from ../include/middlelayer.h:24,
                 from hddtemp.c:28:
hddtemp.c: In function 'quick_message_with_checkbox':
hddtemp.c:171:55: error: 'GtkDialog {aka struct _GtkDialog}' has no member named 'vbox'
     gtk_box_pack_start (GTK_BOX(GTK_DIALOG(ptr_dialog)->vbox), ptr_checkbox, FALSE, FALSE, 0);
                                                       ^
/usr/include/glib-2.0/gobject/gtype.h:2211:48: note: in definition of macro '_G_TYPE_CIC'
 #  define _G_TYPE_CIC(ip, gt, ct)       ((ct*) ip)
                                                ^~
/usr/include/gtk-3.0/gtk/gtkbox.h:40:34: note: in expansion of macro 'G_TYPE_CHECK_INSTANCE_CAST'
 #define GTK_BOX(obj)            (G_TYPE_CHECK_INSTANCE_CAST ((obj), GTK_TYPE_BOX, GtkBox))
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
hddtemp.c:171:25: note: in expansion of macro 'GTK_BOX'
     gtk_box_pack_start (GTK_BOX(GTK_DIALOG(ptr_dialog)->vbox), ptr_checkbox, FALSE, FALSE, 0);
                         ^~~~~~~
make[2]: *** [Makefile:620: libxfce4sensors_la-hddtemp.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
Comment 1 Felix J. Ogris 2017-08-10 17:01:01 UTC
Created attachment 488508 [details, diff]
patch to compile hddtemp.c

Put to /etc/portage/patches/xfce-extra/xfce4-sensors-plugin-1.2.98
Comment 2 Norman Shulman 2018-04-09 15:39:15 UTC
Still same problem:

$ sudo emerge -aqv xfce-extra/xfce4-sensors-plugin
[ebuild     U ] xfce-extra/xfce4-sensors-plugin-1.2.98 [1.2.6] USE="acpi hddtemp lm_sensors -libnotify (-debug%)" VIDEO_CARDS="nvidia" 
...
acpi.c: In function 'get_acpi_value':
acpi.c:780:9: warning: ignoring return value of 'fgets', declared with attribute warn_unused_result [-Wunused-result]
         fgets (buffer, sizeof(buffer), ptr_file); /* appends null-byte character at end */
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hddtemp.c: In function 'quick_message_dialog':
hddtemp.c:141:35: error: 'message' undeclared (first use in this function)
                                   message, NULL);
                                   ^~~~~~~
hddtemp.c:141:35: note: each undeclared identifier is reported only once for each function it appears in
hddtemp.c:143:29: error: 'dialog' undeclared (first use in this function)
     g_signal_connect_swapped (dialog, "response",
                             ^~~~~~
hddtemp.c: In function 'quick_message_with_checkbox':
hddtemp.c:171:73: error: 'GtkDialog {aka struct _GtkDialog}' has no member named 'vbox'
     gtk_box_pack_start (GTK_BOX(GTK_DIALOG(ptr_dialog)->vbox), ptr_checkbox, FALSE, FALSE, 0);
                                                                         ^~
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-05-11 11:50:06 UTC
I can't reproduce with 1.3.0.  Feel free to reopen if it still happens.
Comment 4 Norman Shulman 2018-05-11 18:17:45 UTC
Please reopen.

$ sudo emerge -aqv =xfce-extra/xfce4-sensors-plugin-1.3.0
...
hddtemp.c: In function ‘quick_message_dialog’:
hddtemp.c:141:35: error: ‘message’ undeclared (first use in this function)
                                   message, NULL);
                                   ^~~~~~~
hddtemp.c:141:35: note: each undeclared identifier is reported only once for each function it appears in
In file included from /usr/include/glib-2.0/gobject/gobject.h:28:0,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from /usr/include/xfce4/libxfce4util/xfce-kiosk.h:30,
                 from /usr/include/xfce4/libxfce4util/libxfce4util.h:33,
                 from ../include/types.h:31,
                 from ../include/hddtemp.h:26,
                 from hddtemp.c:27:
hddtemp.c:143:31: error: ‘dialog’ undeclared (first use in this function)
     g_signal_connect_swapped (dialog, "response",
                               ^
/usr/include/glib-2.0/gobject/gsignal.h:528:29: note: in definition of macro ‘g_signal_connect_swapped’
     g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, G_CONNECT_SWAPPED)
                             ^~~~~~~~
In file included from /usr/include/glib-2.0/gobject/gobject.h:24:0,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from /usr/include/xfce4/libxfce4util/xfce-kiosk.h:30,
                 from /usr/include/xfce4/libxfce4util/libxfce4util.h:33,
                 from ../include/types.h:31,
                 from ../include/hddtemp.h:26,
                 from hddtemp.c:27:
hddtemp.c: In function ‘quick_message_with_checkbox’:
hddtemp.c:171:55: error: ‘GtkDialog {aka struct _GtkDialog}’ has no member named ‘vbox’
     gtk_box_pack_start (GTK_BOX(GTK_DIALOG(ptr_dialog)->vbox), ptr_checkbox, FALSE, FALSE, 0);
                                                       ^
/usr/include/glib-2.0/gobject/gtype.h:2212:57: note: in definition of macro ‘_G_TYPE_CIC’
     ((ct*) g_type_check_instance_cast ((GTypeInstance*) ip, gt))
                                                         ^~
/usr/include/gtk-3.0/gtk/gtkbox.h:40:34: note: in expansion of macro ‘G_TYPE_CHECK_INSTANCE_CAST’
 #define GTK_BOX(obj)            (G_TYPE_CHECK_INSTANCE_CAST ((obj), GTK_TYPE_BOX, GtkBox))
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
hddtemp.c:171:25: note: in expansion of macro ‘GTK_BOX’
     gtk_box_pack_start (GTK_BOX(GTK_DIALOG(ptr_dialog)->vbox), ptr_checkbox, FALSE, FALSE, 0);
                         ^~~~~~~
make[2]: *** [Makefile:621: libxfce4sensors_la-hddtemp.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
acpi.c: In function ‘get_acpi_value’:
acpi.c:780:9: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result]
         fgets (buffer, sizeof(buffer), ptr_file); /* appends null-byte character at end */
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: Leaving directory '/var/tmp/portage/xfce-extra/xfce4-sensors-plugin-1.3.0/work/xfce4-sensors-plugin-1.3.0/lib'
make[1]: *** [Makefile:508: all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/xfce-extra/xfce4-sensors-plugin-1.3.0/work/xfce4-sensors-plugin-1.3.0'
make: *** [Makefile:438: all] Error 2
 * ERROR: xfce-extra/xfce4-sensors-plugin-1.3.0::gentoo failed (compile phase):
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-05-11 18:43:59 UTC
Please attach the complete build log then.
Comment 6 Felix J. Ogris 2018-05-11 18:48:19 UTC
Please USE=hddtemp to reproduce the error.
With USE=-hddtemp, 1.3.0 just builds ok.
Comment 7 Norman Shulman 2018-05-11 18:54:58 UTC
Created attachment 530914 [details]
build log