Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 624858 - mail-filter/spamassassin-3.4.1-r11 fails to build with openssl-1.1
Summary: mail-filter/spamassassin-3.4.1-r11 fails to build with openssl-1.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Philippe Chaintreuil
URL:
Whiteboard:
Keywords:
Depends on: 592480 592578
Blocks: openssl-1.1
  Show dependency tree
 
Reported: 2017-07-13 09:38 UTC by Hanno Böck
Modified: 2017-11-01 18:55 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
spamassassin-3.4.1-openssl-1.1-p1.patch (spamassassin-3.4.1-openssl-1.1-p1.patch,14.78 KB, patch)
2017-10-20 02:39 UTC, Mark Wright
Details | Diff
spamassassin-3.4.1-openssl-1.1-p2.patch (spamassassin-3.4.1-openssl-1.1-p2.patch,1.12 KB, patch)
2017-10-20 02:40 UTC, Mark Wright
Details | Diff
spamassassin-3.4.1-r17.ebuild (spamassassin-3.4.1-r17.ebuild,7.28 KB, text/plain)
2017-10-22 23:44 UTC, Michael Orlitzky
Details
spamassassin-3.4.1-bug_7361.patch (spamassassin-3.4.1-bug_7361.patch,16.10 KB, patch)
2017-10-22 23:46 UTC, Michael Orlitzky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hanno Böck gentoo-dev 2017-07-13 09:38:19 UTC
Fails already during configure:

checking for SSL_CTX_free in -lssl... yes
configure: error: Cannot use SSL; libraries or header files are missing.

Here's the upstream bug (with patches):
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7361
Comment 1 Philippe Chaintreuil 2017-07-16 12:33:28 UTC
I setup a VM to try to tackle this over the weekend, but realized that Python and OpenSSH aren't fixed yet.  While not direct dependencies, I don't trust the system until those can be upgrade to support it.  Unless anyone objects, I'm going to sit on this while I wait for those.
Comment 2 Michael Orlitzky gentoo-dev 2017-07-16 12:36:16 UTC
There's supposed to be an RC for spamassassin-3.4.2 soon. I would wait for that, too, in case it's already fixed upstream.
Comment 3 Mark Wright gentoo-dev 2017-10-20 02:39:34 UTC
Created attachment 499340 [details, diff]
spamassassin-3.4.1-openssl-1.1-p1.patch

This patch is from here slightly tweaked to apply when copied to /etc/portage/patches/mail-filter/spamassassin-3.4.1-r16
https://bz.apache.org/SpamAssassin/attachment.cgi?id=5416&action=diff&collapsed=&headers=1&format=raw
Comment 4 Mark Wright gentoo-dev 2017-10-20 02:40:23 UTC
Created attachment 499342 [details, diff]
spamassassin-3.4.1-openssl-1.1-p2.patch

The second patch of 2 by me.
Comment 5 Michael Orlitzky gentoo-dev 2017-10-22 23:44:10 UTC
Created attachment 499730 [details]
spamassassin-3.4.1-r17.ebuild
Comment 6 Michael Orlitzky gentoo-dev 2017-10-22 23:46:44 UTC
Created attachment 499732 [details, diff]
spamassassin-3.4.1-bug_7361.patch

Since Mark did all the work already, and because v3.4.2 appears delayed -- maybe we should just go ahead with this? I made a new revision of the ebuild and concatenated the two patches. The result builds against openssl-1.0, but I haven't tested it any further. If everyone is happy with the result, I can add it to the tree alongside -r16 (which we'll probably stabilize).
Comment 7 Philippe Chaintreuil 2017-10-23 13:49:18 UTC
Python still doesn't install with openssl-1.1.[1]  Mark Wright's Python Github Pull-Request[2] has some outstanding concerns from Python developers.  (Keep going, Mark!  Seems like you're getting close.)

That said, if his autotools changes work for you on openssl-1.0, and since the spamc changes are limited by the OPENSSL_API_COMPAT checks, I don't see any reason not to throw in an -r17 as long as we're willing to shoulder maintaining it if other changes come in.  (Which I am, and it seems you are.)

[1] See Gentoo Bug #592480
[2] https://github.com/python/cpython/pull/3943
Comment 8 Michael Orlitzky gentoo-dev 2017-10-24 14:57:29 UTC
(In reply to Philippe Chaintreuil from comment #7)
> 
> That said, if his autotools changes work for you on openssl-1.0, and since
> the spamc changes are limited by the OPENSSL_API_COMPAT checks, I don't see
> any reason not to throw in an -r17 as long as we're willing to shoulder
> maintaining it if other changes come in.  (Which I am, and it seems you are.)
> 

Since this has been committed to 3.4.1 upstream, any further patches against that branch will likely need to be based on top of this one. (The ordering of the patches might cause problems, but spiritually, we're trailing the upstream branch.)

I'm not 100% keen on saying "I'll fix it!" if it doesn't work because I'm not running openssl-1.1, but I would like to get out of everyone else's way if we're holding them back.

I've filed the stabilization request for -r16, and then I'll think about doing -r17. That way, if any problems crop up, we can simply tell people to downgrade while we figure out what to do.
Comment 9 Larry the Git Cow gentoo-dev 2017-11-01 18:55:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7c925b49c0ac1bb08fb4e3f7666a571b9e076343

commit 7c925b49c0ac1bb08fb4e3f7666a571b9e076343
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2017-10-31 14:12:47 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2017-11-01 18:54:56 +0000

    mail-filter/spamassassin: new revision to fix the build with openssl-1.1.
    
    This new revision adds a patch (thanks to Mark Wright) that fixes the
    build with the new openssl-1.1 branch. Our patch is based on the fix
    contributed upstream by Noah Meyerhans (thanks Noah) in SA bug 7361.
    
    In an unrelated change, the SRC_URI was updated to use the https
    protocol.
    
    Bug: https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7361
    Closes: https://bugs.gentoo.org/624858
    Package-Manager: Portage-2.3.8, Repoman-2.3.3

 .../files/spamassassin-3.4.1-bug_7361.patch        | 491 +++++++++++++++++++++
 .../spamassassin/spamassassin-3.4.1-r17.ebuild     | 244 ++++++++++
 2 files changed, 735 insertions(+)