Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 624194 - sci-libs/opencascade - remove sci-libs/vtk[qt4] dependency
Summary: sci-libs/opencascade - remove sci-libs/vtk[qt4] dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Weber (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 610362
Blocks: qtwebkit4-removal
  Show dependency tree
 
Reported: 2017-07-08 03:45 UTC by Michael Palimaka (kensington)
Modified: 2017-11-06 01:58 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Palimaka (kensington) gentoo-dev 2017-07-08 03:45:56 UTC
sci-libs/opencascade optionally depends on sci-libs/vtk[qt4]:
> vtk? ( || ( sci-libs/vtk[imaging] sci-libs/vtk[qt4] sci-libs/vtk[rendering] sci-libs/vtk[views] sci-libs/vtk[all-modules] ) )"

Could we please remove the sci-libs/vtk[qt4] option from all versions of sci-libs/opencascade? This is blocking a cleanup of old versions of sci-libs/vtk which depend on vulnerable qtwebkit.
Comment 1 Matthew Schultz 2017-08-02 16:37:07 UTC
It seems bumping to 7.1.0 in bug 610362 would fix this issue.
Comment 2 Fabio Rossi 2017-10-26 16:23:07 UTC
After having looked at the build system, it seems to me that Qt4 is not needed at all for the opencascade-6.x.y and opencascade 7.1.0 libraries, Qt is not a system requirement but it's only needed to build and run the shipped examples. The examples are written for Qt4.

Moreover starting from 7.2.0, besides the examples, there is a new component which requires Qt and is built specifying -DBUILD_Inspector. It compiles fine against Qt5. The examples seem to work bot for Qt4 and Qt5, ideally it might be possible to backport the changes for Qt5 to older versions of opencascade.

For this reason I would consider unmasking opencascade versions currently in portage. Are we going to keep multiple versions in parallel like now or only latest version?
Comment 3 Larry the Git Cow gentoo-dev 2017-11-06 01:58:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0d2a598ccf73735880a42e5f67212dadec0fde0c

commit 0d2a598ccf73735880a42e5f67212dadec0fde0c
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2017-11-05 19:55:52 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2017-11-06 01:57:16 +0000

    sci-libs/opencascade: Drop USE=qt4
    
    Thanks-to: Fabio Rossi <rossi.f@inwind.it>
    Closes: https://bugs.gentoo.org/624194
    Package-Manager: Portage-2.3.13, Repoman-2.3.4

 sci-libs/opencascade/opencascade-6.9.1-r2.ebuild | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5e7c5d97488b5b46e20db03862f2502f91335286

commit 5e7c5d97488b5b46e20db03862f2502f91335286
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2017-11-05 19:30:20 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2017-11-06 01:57:16 +0000

    sci-libs/opencascade: Drop old
    
    Bug: https://bugs.gentoo.org/624194
    Package-Manager: Portage-2.3.13, Repoman-2.3.4

 sci-libs/opencascade/Manifest                      |   3 -
 .../opencascade-6.5.4-fixed-tbb-VERSION.patch      |  10 --
 .../files/opencascade-6.7.0-fixed-DESTDIR.patch    |  51 -------
 .../opencascade-6.7.1-deprecated-glx-api.patch     |  89 -----------
 sci-libs/opencascade/opencascade-6.7.1-r1.ebuild   | 161 --------------------
 sci-libs/opencascade/opencascade-6.8.0-r1.ebuild   | 158 --------------------
 sci-libs/opencascade/opencascade-6.9.0-r1.ebuild   | 163 --------------------
 sci-libs/opencascade/opencascade-6.9.1-r1.ebuild   | 164 ---------------------
 8 files changed, 799 deletions(-)}