Bug 622718 – media-libs/libffado-2.3.0 keyword request

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Hector Martin 2017-06-25 23:35:59 UTC]

This will become a dependency of media-sound/jack-audio-connection-kit; please add the missing keywords:

~alpha ~arm ~hppa ~ia64 ~ppc ~ppc64 ~sh ~sparc ~x86 ~amd64-fbsd

[Comment 1 Alexis Ballier 2017-06-26 17:43:58 UTC]

I think it fails to build with gcc-7 so, at least on my side, it'll help if this was fixed first

[Comment 2 Stabilization helper bot 2017-06-26 18:00:49 UTC]

An automated check of this bug failed - repoman reported dependency errors (39 lines truncated): 

> dependency.bad media-libs/libffado/libffado-2.3.0.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0) ['dev-libs/dbus-c++', 'dev-libs/libconfig[cxx,abi_x86_32(-)?,abi_x86_64(-)?,abi_x86_x32(-)?,abi_mips_n32(-)?,abi_mips_n64(-)?,abi_mips_o32(-)?,abi_ppc_32(-)?,abi_ppc_64(-)?,abi_s390_32(-)?,abi_s390_64(-)?]']
> dependency.bad media-libs/libffado/libffado-2.3.0.ebuild: RDEPEND: ~alpha(default/linux/alpha/13.0) ['dev-libs/dbus-c++', 'dev-libs/libconfig[cxx,abi_x86_32(-)?,abi_x86_64(-)?,abi_x86_x32(-)?,abi_mips_n32(-)?,abi_mips_n64(-)?,abi_mips_o32(-)?,abi_ppc_32(-)?,abi_ppc_64(-)?,abi_s390_32(-)?,abi_s390_64(-)?]']
> dependency.bad media-libs/libffado/libffado-2.3.0.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0/desktop) ['dev-libs/dbus-c++', 'dev-libs/libconfig[cxx,abi_x86_32(-)?,abi_x86_64(-)?,abi_x86_x32(-)?,abi_mips_n32(-)?,abi_mips_n64(-)?,abi_mips_o32(-)?,abi_ppc_32(-)?,abi_ppc_64(-)?,abi_s390_32(-)?,abi_s390_64(-)?]']

[Comment 3 Hector Martin 2017-06-26 22:08:33 UTC]

Created attachment 478142 [details, diff]
patch for dev-libs/dbus-c++ gcc7 support

[Comment 4 Hector Martin 2017-06-26 22:09:22 UTC]

gcc-7 is still unkeyworded. I tried emerging it to give it a shot, but trying libffado with it I'm getting errors because dev-libs/libconfig needs to be rebuilt too (ABI changes again, sigh...), and then there's a problem with dev-libs/dbus-c++. That one doesn't build with gcc-7 to begin with (due to an actual bug in the code); fixing that doesn't help though, as ffado still fails due to this bug: https://sourceforge.net/p/dbus-cplusplus/bugs/12/.

So it looks to me like media-libs/libffado builds fine per se with gcc-7, it's just that one of its dependencies needs rebuilding due to an ABI change and another one has headers that are broken with gcc-7. Are you seeing a different result?

Patch for dbus-c++ is attached.

[Comment 5 Hector Martin 2017-06-26 22:16:16 UTC]

Filed bug 622790 for the dev-libs/dbus-c++ issue.

[Comment 6 Alexis Ballier 2017-06-27 00:20:11 UTC]

(In reply to Hector Martin from comment #4)
> gcc-7 is still unkeyworded.

yes, but the idea is to get it keyworded rather sooner than later :)

> I tried emerging it to give it a shot, but
> trying libffado with it I'm getting errors because dev-libs/libconfig needs
> to be rebuilt too (ABI changes again, sigh...), and then there's a problem
> with dev-libs/dbus-c++. That one doesn't build with gcc-7 to begin with (due
> to an actual bug in the code); fixing that doesn't help though, as ffado
> still fails due to this bug:
> https://sourceforge.net/p/dbus-cplusplus/bugs/12/.


yep, I had also built this one with an older gcc, thanks for sumbitting the patch!


> So it looks to me like media-libs/libffado builds fine per se with gcc-7,
> it's just that one of its dependencies needs rebuilding due to an ABI change
> and another one has headers that are broken with gcc-7. Are you seeing a
> different result?

Yes, it may be dbus-c++ headers breaking it. I just noticed that even after having built dbus-c++ with gcc 6, libffado still failed to build with gcc 7.

[Comment 7 Hector Martin 2017-06-30 21:48:54 UTC]

CCed arches, please test and keyword ~arch (s) so we can add this dep to media-sound/jack-audio-connection-kit. Some dependencies also need keywords for less common arches (e.g. dev-libs/dbus-c++).

[Comment 8 Alexis Ballier 2017-07-01 09:12:11 UTC]

(In reply to Hector Martin from comment #7)
> CCed arches, please test and keyword ~arch (s) so we can add this dep to
> media-sound/jack-audio-connection-kit. Some dependencies also need keywords
> for less common arches (e.g. dev-libs/dbus-c++).


You need to fill the complete list so that this does not happen:


(In reply to Stabilization helper bot from comment #2)
> An automated check of this bug failed - repoman reported dependency errors
> (39 lines truncated): 
> 
> > dependency.bad media-libs/libffado/libffado-2.3.0.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0) ['dev-libs/dbus-c++', 'dev-libs/libconfig[cxx,abi_x86_32(-)?,abi_x86_64(-)?,abi_x86_x32(-)?,abi_mips_n32(-)?,abi_mips_n64(-)?,abi_mips_o32(-)?,abi_ppc_32(-)?,abi_ppc_64(-)?,abi_s390_32(-)?,abi_s390_64(-)?]']


otherwise this bug will just be ignored

[Comment 9 Markus Meier 2017-07-09 08:04:06 UTC]

~arm added

[Comment 10 Stabilization helper bot 2017-07-09 09:02:04 UTC]

An automated check of this bug failed - repoman reported dependency errors (39 lines truncated): 

> dependency.bad media-libs/libffado/libffado-2.3.0.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0) ['dev-libs/dbus-c++', 'dev-libs/libconfig[cxx,abi_x86_32(-)?,abi_x86_64(-)?,abi_x86_x32(-)?,abi_mips_n32(-)?,abi_mips_n64(-)?,abi_mips_o32(-)?,abi_ppc_32(-)?,abi_ppc_64(-)?,abi_s390_32(-)?,abi_s390_64(-)?]']
> dependency.bad media-libs/libffado/libffado-2.3.0.ebuild: RDEPEND: ~alpha(default/linux/alpha/13.0) ['dev-libs/dbus-c++', 'dev-libs/libconfig[cxx,abi_x86_32(-)?,abi_x86_64(-)?,abi_x86_x32(-)?,abi_mips_n32(-)?,abi_mips_n64(-)?,abi_mips_o32(-)?,abi_ppc_32(-)?,abi_ppc_64(-)?,abi_s390_32(-)?,abi_s390_64(-)?]']
> dependency.bad media-libs/libffado/libffado-2.3.0.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0/desktop) ['dev-libs/dbus-c++', 'dev-libs/libconfig[cxx,abi_x86_32(-)?,abi_x86_64(-)?,abi_x86_x32(-)?,abi_mips_n32(-)?,abi_mips_n64(-)?,abi_mips_o32(-)?,abi_ppc_32(-)?,abi_ppc_64(-)?,abi_s390_32(-)?,abi_s390_64(-)?]']

[Comment 11 Hector Martin 2017-07-10 15:35:53 UTC]

These are the dependencies that need new keywords (repoman is happy with these) for everything but hppa:

=dev-libs/dbus-c++-0.9.0-r3: ~alpha ~ia64 ~ppc64 ~sh ~sparc ~amd64-fbsd
=dev-libs/libconfig-1.5: ~alpha ~ia64 ~sh ~amd64-fbsd

With hppa the missing keyword chain runs deeper. The chain involves PyQt4 (which will probably be replaced with PyQt5 in a newer release of libffado), and honestly I'd be surprised if there's a single person out there that cares about JACK with libffado on Gentoo on HP-PA by now, so let's drop that keyword.

[Comment 12 Stabilization helper bot 2017-07-10 16:01:20 UTC]

An automated check of this bug succeeded - the previous repoman errors are now resolved.

[Comment 13 Sergei Trofimovich (RETIRED) 2017-07-11 07:53:29 UTC]

ia64 keyworded

[Comment 14 Sergei Trofimovich (RETIRED) 2017-08-09 21:01:05 UTC]

~ppc keyworded

[Comment 15 Sergei Trofimovich (RETIRED) 2017-08-09 21:18:12 UTC]

~ppc64 keyworded

[Comment 16 Markus Meier 2017-09-07 19:29:58 UTC]

~arm64 added

[Comment 17 Sergei Trofimovich (RETIRED) 2017-12-23 21:13:57 UTC]

~amd64 is already keyworded (I believe from day-1)

[Comment 18 Thomas Deutschmann (RETIRED) 2018-01-08 23:56:24 UTC]

x86 stable

[Comment 19 Sergei Trofimovich (RETIRED) 2018-01-09 22:30:01 UTC]

sparc stable (thanks to Rolf Eike Beer)

[Comment 20 Hector Martin 2018-01-11 04:36:33 UTC]

Let's close this, since libffado-2.4.0 is out and will have to drop a few KEYWORDS due to the move to PyQt5, while 2.3.0 is likely to be removed as Qt4 dies off.