Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 622698 - net-wireless/bluez-tools: new package
Summary: net-wireless/bluez-tools: new package
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: laurantino
URL: https://github.com/khvzak/bluez-tools
Whiteboard:
Keywords:
Depends on:
Blocks: 622696
  Show dependency tree
 
Reported: 2017-06-25 14:55 UTC by laurantino
Modified: 2017-06-25 19:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
bluez-tools-0.2.0 ebuild (bluez-tools-0.2.0.ebuild,679 bytes, text/plain)
2017-06-25 14:55 UTC, laurantino
Details
metadata.xml (metadata.xml,575 bytes, text/xml)
2017-06-25 14:56 UTC, laurantino
Details
bluez-tools_pre20161212.ebuild (bluez-tools-0.2.0_pre20161212.ebuild,673 bytes, text/plain)
2017-06-25 18:28 UTC, laurantino
Details

Note You need to log in before you can comment on or make changes to this bug.
Description laurantino 2017-06-25 14:55:36 UTC
Created attachment 477982 [details]
bluez-tools-0.2.0 ebuild

New package request for bluez-tools that is needed by latest net-wireless/blueberry version.

I am OK to proxy maintain it like I do for net-wireless/blueberry.

I attach an ebuild proposal.
Comment 1 laurantino 2017-06-25 14:56:41 UTC
Created attachment 477984 [details]
metadata.xml

Metadata file for bluez-tools package
Comment 2 Kristian Fiskerstrand (RETIRED) gentoo-dev 2017-06-25 15:02:53 UTC
(In reply to charlot from comment #0)
> Created attachment 477982 [details]
> bluez-tools-0.2.0 ebuild
> 
> New package request for bluez-tools that is needed by latest
> net-wireless/blueberry version.
> 
> I am OK to proxy maintain it like I do for net-wireless/blueberry.
> 
> I attach an ebuild proposal.

Thank you for the ebuild, some (minor) comments

SRC_URI="https://github.com/khvzak/${PN}/archive/${COMMIT}.tar.gz -> ${PN}-${PV}.tar.gz"
^ any reason not to use ${P} above instead of ${PN}-${PV} ?

LICENSE="GPL-2"
^ seems this should actually be GPL-2+ based on the headers in the .c files I looked at?
Comment 3 laurantino 2017-06-25 18:26:17 UTC
(In reply to Kristian Fiskerstrand from comment #2)

> SRC_URI="https://github.com/khvzak/${PN}/archive/${COMMIT}.tar.gz ->
> ${PN}-${PV}.tar.gz"
> ^ any reason not to use ${P} above instead of ${PN}-${PV} ?

No you are right, we should use ${P}. Besides, the versioning scheme I used is not the best since it seems the 0.2.0 version has never been officially released. The best is to prefix the name of the ebuild with _pre20161212 according to the date of the commit.
 
> LICENSE="GPL-2"
> ^ seems this should actually be GPL-2+ based on the headers in the .c files
> I looked at?

OK

I will attach a new version of the ebuild regarding your two comments.
Comment 4 laurantino 2017-06-25 18:28:54 UTC
Created attachment 477994 [details]
bluez-tools_pre20161212.ebuild

Updated version of the ebuild
Comment 5 Kristian Fiskerstrand (RETIRED) gentoo-dev 2017-06-25 19:23:18 UTC
(In reply to charlot from comment #3)
> (In reply to Kristian Fiskerstrand from comment #2)
> 
> > SRC_URI="https://github.com/khvzak/${PN}/archive/${COMMIT}.tar.gz ->
> > ${PN}-${PV}.tar.gz"
> > ^ any reason not to use ${P} above instead of ${PN}-${PV} ?
> 
> No you are right, we should use ${P}. Besides, the versioning scheme I used
> is not the best since it seems the 0.2.0 version has never been officially
> released. The best is to prefix the name of the ebuild with _pre20161212

you'd use _pre if you're getting closer to a released version (e.g knowing it is an rc variant), what you likely want to look into is 0_pYYYYMMDD (note that your current name is invalid as it has no version)
Comment 6 Kristian Fiskerstrand (RETIRED) gentoo-dev 2017-06-25 19:46:39 UTC
Added, for updates, please provide a git format-patch against the gentoo git repository including commit message describing the change.

commit 101965a9308cb82d3fa1234177905a80000b0fc5 (HEAD -> master)
Author: Kristian Fiskerstrand <k_f@gentoo.org>
Date:   Sun Jun 25 21:45:43 2017 +0200

    net-wireless/bluez-tools: New package
    
    Needed by net-wireless/blueberry
    
    Gentoo-Proxied-Maintainer: Olivier Laurantin
    Gentoo-Bug: 622698
    
    Package-Manager: Portage-2.3.6, Repoman-2.3.1