Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 621468 - app-portage/gentoolkit-0.4.0 Update the manpage for revdep-rebuild SEARCH_DIRS_MASK
Summary: app-portage/gentoolkit-0.4.0 Update the manpage for revdep-rebuild SEARCH_DIR...
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-11 02:59 UTC by Chris Smith
Modified: 2017-06-12 16:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Smith 2017-06-11 02:59:59 UTC
Python coded revdep-rebuild ignores SEARCH_DIRS_MASK in make.conf.
The script revdep-rebuild.sh works properly.
Comment 1 Brian Dolbec gentoo-dev 2017-06-12 00:33:12 UTC
The correct place for masks is in /etc/revdep-rebuild/99revdep-rebuild.

Application ebuilds also install mask files there on an as needed basis.

Please move you masks from make.conf to the /etc/revdep-rebuild directory.

The only reason the bash version picks it up there is because it sources make.conf for some settings.  The python version gets those settings from portage api calls.
Comment 2 Chris Smith 2017-06-12 01:19:47 UTC
(In reply to Brian Dolbec from comment #1)
> The correct place for masks is in /etc/revdep-rebuild/99revdep-rebuild.
> 
> Application ebuilds also install mask files there on an as needed basis.
> 
> Please move you masks from make.conf to the /etc/revdep-rebuild directory.
> 
> The only reason the bash version picks it up there is because it sources
> make.conf for some settings.  The python version gets those settings from
> portage api calls.

Then one would think that the man page should reflect this and that also the SEARCH_DIRS variable in /etc/revdep-rebuild/99revdep-rebuild would be adhered to, which it isn't as many more paths are searched besides those listed.
Comment 3 Brian Dolbec gentoo-dev 2017-06-12 01:54:42 UTC
Good point.  We'll have to update the man page properly.

And yes the revdep-rebuild directory is additive for both bash and python versions.  So as a pkg installs a mask file, it then becomes part of the total masks.

Re-opened for that.
Comment 4 Paul Varner (RETIRED) gentoo-dev 2017-06-12 16:30:56 UTC
This is a change in the intended behavior that was designed into the bash script.

We definitely need to discuss and document how to do it correctly for the python version. The biggest issue that will bite people is /etc/revdep-rebuild is not under configuration protection. So you don't want to modify files placed there by ebuilds or changes will be lost.