Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 620694 - app-misc/sleepyhead depends on dev-qt/qtwebkit:4
Summary: app-misc/sleepyhead depends on dev-qt/qtwebkit:4
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Richard Freeman
Depends on:
Blocks: qtwebkit4-removal
  Show dependency tree
Reported: 2017-06-04 06:39 UTC by Michael Palimaka (kensington)
Modified: 2017-11-06 00:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

0001-app-misc-sleepyhead-revision-bump-ports-to-Qt-5.patch (0001-app-misc-sleepyhead-revision-bump-ports-to-Qt-5.patch,2.36 KB, patch)
2017-10-01 04:08 UTC, Michael Palimaka (kensington)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Palimaka (kensington) gentoo-dev 2017-06-04 06:39:30 UTC
app-misc/sleepyhead depends on dev-qt/qtwebkit:4 which is ancient and will never see any security updates.

If there's no upstream fix available, it might be time to remove this package.
Comment 1 Richard Freeman gentoo-dev 2017-06-04 19:21:32 UTC
Looks like I'll need to update this to the latest version.  I'd been avoiding this as they're seemingly in perpetual beta, but I'll tag a commit.  It has been updated to qt5 at least.
Comment 2 Richard Freeman gentoo-dev 2017-06-04 21:00:25 UTC
Ok, the new version is in the tree.  I'll leave this open to track the qt4 dependency until the old version is removed, but I'd like to leave it around for a bit in case the new version causes issues.
Comment 3 Andreas Sturmlechner gentoo-dev 2017-08-27 18:48:01 UTC
Upstream hasn't found it necessary to fix stuff in their beta for ~1 year - do you think the old version is ready for cleanup? :)
Comment 4 Richard Freeman gentoo-dev 2017-08-27 18:57:31 UTC
(In reply to Andreas Sturmlechner from comment #3)
> Upstream hasn't found it necessary to fix stuff in their beta for ~1 year -
> do you think the old version is ready for cleanup? :)

I don't see that we have much choice if you plan to retire qt4.

However, I can definitely vouch that the current version is useless on my CPAP.  It looks like they reverted a bunch of stuff where they didn't get permission to re-license it, so it doesn't support some less-common models, including mine.  I may end up setting up a container somewhere to run the old version and stop maintaining this at some point.
Comment 5 Michael Palimaka (kensington) gentoo-dev 2017-10-01 04:08:09 UTC
Created attachment 497288 [details, diff]

0.9.3 builds against Qt 5 OK, please test.
Comment 6 Andreas Sturmlechner gentoo-dev 2017-10-15 08:25:49 UTC
Should we just add the patch and cleanup?
Comment 7 Richard Freeman gentoo-dev 2017-10-15 16:00:11 UTC
Sorry about the delay.  I just did some testing and I'm getting segfaults after creating a profile with the patched version.

Thread 1 "SleepyHead" received signal SIGSEGV, Segmentation fault.
0x00007ffff5788066 in QOpenGLFunctions::hasOpenGLFeature(QOpenGLFunctions::OpenGLFeature) const ()
   from /usr/lib64/
(gdb) bt
#0  0x00007ffff5788066 in QOpenGLFunctions::hasOpenGLFeature(QOpenGLFunctions::OpenGLFeature) const ()
   from /usr/lib64/
#1  0x00007ffff7f7be11 in QGLContextPrivate::bindTexture(QImage const&, unsigned int, int, long long, QFlags<QGLContext::BindOption>) () from /usr/lib64/
#2  0x00007ffff7f7c5b3 in QGLContextPrivate::bindTexture(QImage const&, unsigned int, int, QFlags<QGLContext::BindOption>) () from /usr/lib64/
#3  0x00007ffff7f7c65b in QGLContext::bindTexture(QImage const&, unsigned int, int, QFlags<QGLContext::BindOption>) ()
   from /usr/lib64/
#4  0x00007ffff7f7c6ae in QGLWidget::bindTexture(QImage const&, unsigned int, int) () from /usr/lib64/
#5  0x00000000005661bd in gGraphView::setCubeImage (this=0x16fe020, img=0x1262880) at Graphs/gGraphView.cpp:3287
#6  0x000000000047ecbe in Daily::Daily (this=0x1357d20, parent=0xb53650, shared=0x0) at daily.cpp:335
#7  0x00000000004c5415 in MainWindow::MainWindow (this=0x7fffffffcdb0, parent=0x0) at mainwindow.cpp:139
#8  0x0000000000427d0c in main (argc=1, argv=0x7fffffffcf68) at main.cpp:282

It loads fine if I switch back to the qt4 version.  So, the patch might build but it seems to have issues.  You should be able to reproduce this without any cpap data - the segfault happens just after you create a profile.

We may be stuck just going to the 1.0 beta, though that has its own issues.  That is basically the direction upstream is going in, so I don't really have a problem with this.  

I don't see a point in releasing the 0.9 patch until it works.  However, I'm fine with cleaning out old versions alongside the qt4 cleanup - don't let this hold anything up.
Comment 8 Andreas Sturmlechner gentoo-dev 2017-10-16 15:12:41 UTC
Affected versions depending on Qt4WebKit were masked.
Comment 9 Andreas Sturmlechner gentoo-dev 2017-11-06 00:31:48 UTC
Cleanup done by rich0 in git commit 28d0bdd20453d231a09a8838deacf441ab7a7df5.