Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 619436 - sys-cluster/torque-4.1.7-r1 unsafely mangles CFLAGS
Summary: sys-cluster/torque-4.1.7-r1 unsafely mangles CFLAGS
Status: IN_PROGRESS
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Cluster Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-cflags
  Show dependency tree
 
Reported: 2017-05-23 09:18 UTC by Alessandro Barbieri
Modified: 2017-06-03 19:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Barbieri 2017-05-23 09:18:59 UTC
It removes -O* flags too naively, even when they are to be passes at the linker leading for sure to build failures (I have seen this in the erlang ebuild too)

-Wl,O1 and -Wl,-O2 became -Wl, as seen here

checking for bison... bison -y
checking for gtbl... gtbl
checking for gpic... no
checking for pic... pic
checking for groff... groff
checking whether to turn on the compilation of DEBUG code... no
checking whether to compile with debugging symbols... DEBUG_SYMBOLS=yes
before tweak CFLAGS=-Os -pipe -march=native -mtune=native -fomit-frame-pointer -mfpmath=sse -Wformat -Wformat-security -Wl,-O1 -Wl,--as-needed -Wl,-O2 -Wl,-z,now -Wl,-z,relro -lpthread -lgomp -fweb -fgcse-after-reload -fivopts -fopenmp -Wno-error=implicit-function-declaration -pthread
mid tweak CFLAGS= -pipe -march=native -mtune=native -fomit-frame-pointer -mfpmath=sse -Wformat -Wformat-security -Wl, -Wl,--as-needed -Wl, -Wl,-z,now -Wl,-z,relro -lpthread -lgomp -fweb -fgcse-after-reload -fivopts -fopenmp -Wno-error=implicit-function-declaration -pthread
after tweak CFLAGS=-g  -pipe -march=native -mtune=native -fomit-frame-pointer -mfpmath=sse -Wformat -Wformat-security -Wl, -Wl,--as-needed -Wl, -Wl,-z,now -Wl,-z,relro -lpthread -lgomp -fweb -fgcse-after-reload -fivopts -fopenmp -Wno-error=implicit-function-declaration -pthread
checking whether to use strict gcc warnings... no
checking for stat64... no
checking for stat64... no
checking for open64... no
checking for lseek64... no
checking for struct stat64.st_mode... yes
Comment 1 Ian Stakenvicius gentoo-dev 2017-05-23 14:12:04 UTC
Thanks for reporting, I'll look into this asap.
Comment 2 Ian Stakenvicius gentoo-dev 2017-05-24 13:53:20 UTC
(In reply to Ian Stakenvicius from comment #1)
> Thanks for reporting, I'll look into this asap.

OK so configure.ac definitely contains some rather nasty (and from what I can tell, useless) code in this respect.  Unfortunately, fixing their build system so that an eautoreconf will complete seems to be non-trivial.  I'm pushing torque-4.2.10 today with this bug addressed, please test.

I'll also check the newer variants (6.x I think is the only one we have in the repo right now) to ensure the issue doesn't exist there.