Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 618104 - media-gfx/darktable Add lua support (via use flag) once dev-lang/lua-5.3 is unmasked
Summary: media-gfx/darktable Add lua support (via use flag) once dev-lang/lua-5.3 is u...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement with 2 votes (vote)
Assignee: Marek Szuba
URL:
Whiteboard:
Keywords:
Depends on: lua-5.2
Blocks:
  Show dependency tree
 
Reported: 2017-05-10 12:09 UTC by schmittlauch
Modified: 2020-09-30 15:41 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
darktable 2.2.5 ebuild with lua enabled (darktable-2.2.5.ebuild,3.81 KB, text/plain)
2017-06-10 19:26 UTC, Nick
Details

Note You need to log in before you can comment on or make changes to this bug.
Description schmittlauch 2017-05-10 12:09:28 UTC
This is already a TODO in the ebuild, but I think it's good having a bug to subscribe to.
Comment 1 schmittlauch 2017-05-11 21:15:12 UTC
There's also the possibility of bundling lua-5.2 until it's unmasked as a system package.
Comment 2 urcindalo 2017-05-17 10:54:46 UTC
(In reply to t.schmittlauch+gentoo from comment #1)
> There's also the possibility of bundling lua-5.2 until it's unmasked as a
> system package.

Yes, it would be great to enjoy lua support in darktable.
Comment 3 Nick 2017-06-07 19:42:13 UTC
I managed to get lua working with darktable using a slotted lua and a dirty hack in ebuild, as I failed to do it properly ( see this discussion https://redmine.darktable.org/issues/11641 )
I've unmasked and installed lua 5.2, eselected it, then dt compiled and lua seems to work, at least few scripts I tested yet.

If somebody is able to improve my hack to make cmake to correctly pass the -isystem parameter, we'll have a decent solution...
Comment 4 Nick 2017-06-10 19:26:18 UTC
Created attachment 475936 [details]
darktable 2.2.5 ebuild with lua enabled
Comment 5 Nick 2017-06-10 19:26:37 UTC
UPDATE to my comment #3
The issue appeared to reside in lua5.2.pc file (see link to the discussion in my previous post).
It reads Cflags: -I${includedir} instead of
         Cflags: -I${includedir}/${lib_name_include}
So far I fixed it manually, but I ought to file a bug about it. 
So here comes the working ebuild.
Comment 6 Nick 2017-06-10 19:36:43 UTC
Apparently there is a bug about this already for about a year... Ohh...
https://bugs.gentoo.org/show_bug.cgi?id=592052
Comment 7 Marek Szuba archtester gentoo-dev 2020-06-18 13:01:37 UTC
Still waiting for lua-5.2.
Comment 8 Marek Szuba archtester gentoo-dev 2020-09-30 15:14:51 UTC
For the record, current versions of darktable require lua-5.3+.
Comment 9 Larry the Git Cow gentoo-dev 2020-09-30 15:41:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9cb5ef5c3e97c72b45c015fb9bb38d7209e67030

commit 9cb5ef5c3e97c72b45c015fb9bb38d7209e67030
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2020-09-30 15:28:00 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2020-09-30 15:41:37 +0000

    media-gfx/darktable: enable Lua support
    
    Looks like it will still take a lot of time before we have lua-5.3
    available in the tree, slotted or not. Fortunately it turns out that
    recent versions of Darktable come with bundled Lua 5.3 which can
    optionally be used instead of system version.
    
    Closes: https://bugs.gentoo.org/618104
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 media-gfx/darktable/darktable-3.2.1-r1.ebuild | 151 ++++++++++++++++++++++++++
 media-gfx/darktable/darktable-9999.ebuild     |   9 +-
 2 files changed, 156 insertions(+), 4 deletions(-)