Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 617754 - dev-tex/latexdiff broken on perl 5.26 (Unescaped left brace in regex is illegal here in regex)
Summary: dev-tex/latexdiff broken on perl 5.26 (Unescaped left brace in regex is illeg...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: TeX project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: perl-5.26
  Show dependency tree
 
Reported: 2017-05-07 18:29 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2017-11-03 22:17 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
unescaped-lbracket-5.26.patch (unescaped-lbracket-5.26.patch,22.94 KB, patch)
2017-06-09 17:45 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details | Diff
build log from a successful patch + compile on latexdiff 1.2.0 (latexdiff-1.2.0-r2:20170609-172001.log,45.89 KB, text/plain)
2017-06-09 17:49 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2017-05-07 18:29:49 UTC
All versions in tree become unusable with Perl 5.26

Please keep this issue open until no affected versions remain in tree.

>>>  '/var/log/portage-build/build/dev-tex/latexdiff-1.2.0:20170507-090556.log'                                    
 * Package:    dev-tex/latexdiff-1.2.0                                                                                 
 * Repository: gentoo                                                                                              
 * Maintainer: tex@gentoo.org                                                                                          
 * USE:        abi_x86_64 amd64 elibc_glibc kernel_linux test userland_GNU                               
 * FEATURES:   preserve-libs sandbox test userpriv usersandbox                 
mkdir -p latexdiff-1.2.0                                       
ln -s latexdiff-1.2.0 dist                    
mkdir -p dist/doc                          
mkdir -p dist/example                     
grep -v '^###' latexdiff > dist/latexdiff ; chmod a+x dist/latexdiff
grep -v '^###' latexrevise > dist/latexrevise ; chmod a+x dist/latexrevise
awk '/use Algorithm::Diff qw\(traverse_sequences\);/ { system("cat Algorithm-Diff-Block") ; next } { print }' latexdiff | grep -v '^###' > dist/latexdiff-so ; chmod a+x dist/latexdiff-so
awk '/use Algorithm::Diff qw\(traverse_sequences\);/ { system("cat Algorithm-Diff-Fast") ; next } { print }' latexdiff | grep -v '^###' > dist/latexdiff-fast ; chmod a+x dist/latexdiff-fast
grep -v '^###' latexdiff-vc > dist/latexdiff-vc ; chmod a+x dist/latexdiff-vc
pod2man -center=" " latexdiff > dist/latexdiff.1                            
pod2man -center=" " latexrevise > dist/latexrevise.1                                          
pod2man -center=" " latexdiff-vc > dist/latexdiff-vc.1                                       
pod2latex latexdiff; sed 's/--/-{}-/g' latexdiff.tex > tmp$.tex ; mv tmp$.tex latexdiff.tex                        
pod2latex latexdiff-vc; sed 's/--/-{}-/g' latexdiff-vc.tex > tmp$.tex ; mv tmp$.tex latexdiff-vc.tex                   
pod2latex latexrevise ; sed 's/--/-{}-/g' latexrevise.tex > tmp$.tex ; mv tmp$.tex latexrevise.tex       
latexdiff -t UNDERLINE example-draft.tex example-rev.tex > example-diff.tex    
Negative repeat count does nothing at /var/tmp/portage/dev-tex/latexdiff-1.2.0/work/latexdiff-1.2.0/dist/latexdiff line 607, <DATA> line 23800.
Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\\begin{ <-- HERE ((?:picture|tikzpicture|DIFnomarkup)[\w\d*@]*)}(.*?)\\end{\1}/ at /var/tmp/portage/dev-tex/latexdiff-1.2.0/work/latexdiff-1.2.0/dist/latexdiff line 1897.
make: *** [Makefile:94: example-diff.tex] Error 2
Comment 1 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2017-06-09 17:45:54 UTC
Created attachment 475780 [details, diff]
unescaped-lbracket-5.26.patch

So, I have a patch that appears to make it compile and pass tests, but I'm gonna want feedback before I submit it upstream.

I'm not sure I'm reading the test output right, and I want somebody who knows what they're doing to review the tests and make sure I didn't introduce any breakage.
Comment 2 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2017-06-09 17:49:17 UTC
Created attachment 475782 [details]
build log from a successful patch + compile on latexdiff 1.2.0
Comment 3 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2017-06-09 18:00:15 UTC
Patch probably easier to read in this format:

http://dev.gentoo.org/~kentnl/scratch/bug-617754/cdiff.html
Comment 4 Alexis Ballier gentoo-dev 2017-06-14 11:29:56 UTC
FWIW, here I have:
The compilation of the following programs resulted in problems:
rapine_et_al-diff.tex gershwin12-diff.tex gershwin34-diff.tex outerrise-diff.tex


While you get:
The compilation of the following programs resulted in problems:
rapine_et_al-diff.tex island_obs2004-diff.tex gershwin12-diff.tex gershwin34-diff.tex schneider-diff.tex outerrise-diff.tex rolla-diff.tex apacite-test-diff.tex units-diff.tex figures-diff.tex




It'd be interesting to understand why those fail.

As for those that do not fail, just open the pdf and look at something weird.

Note that upstream seems to already have related fixes, such as https://github.com/ftilmann/latexdiff/commit/f10759b525dbc94aefdbba1eb2c5a0951e9dccc5
Comment 5 Andreas K. Hüttel archtester gentoo-dev 2017-06-17 15:22:42 UTC
https://github.com/ftilmann/latexdiff/issues/104
Comment 6 Andreas K. Hüttel archtester gentoo-dev 2017-06-17 15:34:11 UTC
I've added a live ebuild for testing git master. Let's see how that fares.
Comment 7 Alexey Korepanov 2017-09-07 13:02:50 UTC
According to
https://github.com/ftilmann/latexdiff/issues/104
there is a 1.2.1 release which is expected to fix the problem.
Maybe, version bump?
Comment 8 Bernd Feige 2017-10-23 15:21:18 UTC
(In reply to Alexey Korepanov from comment #7)
> According to
> https://github.com/ftilmann/latexdiff/issues/104
> there is a 1.2.1 release which is expected to fix the problem.
> Maybe, version bump?

Yes please! 1.2.1 fixes the problem here. Thanks!
Comment 9 Larry the Git Cow gentoo-dev 2017-11-03 22:17:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5e2b3743b02b220f8aa24c8ec8ff95112e25e39b

commit 5e2b3743b02b220f8aa24c8ec8ff95112e25e39b
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2017-11-03 22:17:14 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2017-11-03 22:17:30 +0000

    dev-tex/latexdiff: Version bump, fixes bug 617754
    
    Closes: https://bugs.gentoo.org/617754
    Package-Manager: Portage-2.3.13, Repoman-2.3.4

 dev-tex/latexdiff/Manifest               |  1 +
 dev-tex/latexdiff/latexdiff-1.2.1.ebuild | 47 ++++++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+)