Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 616996 - media-libs/openexr-2.2.0-r1 - OPENEXR_VERSION_STRING and OPENEXR_PACKAGE_STRING are not strings
Summary: media-libs/openexr-2.2.0-r1 - OPENEXR_VERSION_STRING and OPENEXR_PACKAGE_STRI...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 596268
  Show dependency tree
 
Reported: 2017-04-29 12:41 UTC by Dennis Schridde
Modified: 2017-09-28 21:22 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix-openexr-2.2.0-fix-build-system.patch (fix-openexr-2.2.0-fix-build-system.patch,1.08 KB, patch)
2017-04-29 12:41 UTC, Dennis Schridde
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Schridde 2017-04-29 12:41:07 UTC
Created attachment 471276 [details, diff]
fix-openexr-2.2.0-fix-build-system.patch

media-libs/openexr/files/openexr-2.2.0-fix-build-system.patch contains:
-AC_DEFINE_UNQUOTED(OPENEXR_VERSION_STRING, "${VERSION}")
-AC_DEFINE_UNQUOTED(OPENEXR_PACKAGE_STRING, "${PACKAGE_STRING}")
+AC_DEFINE_UNQUOTED([OPENEXR_VERSION_STRING], [${VERSION}], [OpenEXR version string])
+AC_DEFINE_UNQUOTED([OPENEXR_PACKAGE_STRING], [${PACKAGE_STRING}], [OpenEXR version string])

This causes OPENEXR_VERSION_STRING and OPENEXR_PACKAGE_STRING in config/OpenEXRConfig.h to no longer be strings. Instead the patch should keep the quotes around the variable. This can be verified by looking at the example in the autoconf documentation for AC_DEFINE_UNQUOTED: https://www.gnu.org/software/autoconf/manual/autoconf-2.60/html_node/Defining-Symbols.html

Attached patch-to-the-patch fixes this.

Found when trying to build media-libs/openimageio-1.7.13, a version bump I am preparing right now (bug #596268).
Comment 1 Larry the Git Cow gentoo-dev 2017-09-28 12:50:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dd4ad81b5d8ba426b3d2d75b27f9993119f73e30

commit dd4ad81b5d8ba426b3d2d75b27f9993119f73e30
Author:     Jonathan Scruggs <j.scruggs@gmail.com>
AuthorDate: 2017-09-23 13:04:39 +0000
Commit:     Alexis Ballier <aballier@gentoo.org>
CommitDate: 2017-09-28 12:45:07 +0000

    media-libs/openexr: Revision bump to 2.2.0-r2
    
    * Added patch to fix a typo in the C bindings
    * Added patch to install the missing header files
    * Added patch to fix security issues:
      CVE-2017-9110, CVE-2017-9111, CVE-2017-9112, CVE-2017-9113,
      CVE-2017-9114, CVE-2017-9115, CVE-2017-9116
    * Fixed build system patch
    * Added tabs in the metadata.xml file
    
    Closes: https://bugs.gentoo.org/616996
    Closes: https://bugs.gentoo.org/631382
    Closes: https://bugs.gentoo.org/620324

 ....2.0-CVE-2017-9110-to-9116-security-fixes.patch | 98 ++++++++++++++++++++++
 .../openexr-2.2.0-Fix-typo-in-C-bindings.patch     | 26 ++++++
 ...penexr-2.2.0-Install-missing-header-files.patch | 60 +++++++++++++
 .../files/openexr-2.2.0-fix-build-system.patch     |  4 +-
 media-libs/openexr/metadata.xml                    |  9 +-
 media-libs/openexr/openexr-2.2.0-r2.ebuild         | 64 ++++++++++++++
 6 files changed, 256 insertions(+), 5 deletions(-)
Comment 2 Dennis Schridde 2017-09-28 21:04:11 UTC
Thanks, Jonathan!
Comment 3 Jonathan Scruggs (RETIRED) gentoo-dev 2017-09-28 21:22:32 UTC
(In reply to Dennis Schridde from comment #2)
> Thanks, Jonathan!

You're welcome.