Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 615824 - sys-apps/portage: emerge fails to report slot conflicts involving autounmask USE changes
Summary: sys-apps/portage: emerge fails to report slot conflicts involving autounmask ...
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Interface (emerge) (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 300071
  Show dependency tree
 
Reported: 2017-04-17 08:41 UTC by Zac Medico
Modified: 2019-09-23 01:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zac Medico gentoo-dev 2017-04-17 08:41:49 UTC
While testing changes for bug 615680, I found that emerge fails to report slot conflicts triggered by autounmask USE changes. The problem is that the _check_slot_conflict fails to identify the slot conflict, since it only sees one package instance, when there should actually be 2 different instances with different USE settings. The problem can be solved by making _check_slot_conflict check if all parent atoms match pkg, and making _add_pkg use pkg.with_use(self._pkg_use_enabled(pkg)) to generate a second package instance (this will cause PackageTracker to recognize the slot conflict). The following test case triggers the problem:


from portage.tests import TestCase
from portage.tests.resolver.ResolverPlayground import (
	ResolverPlayground,
	ResolverPlaygroundTestCase,
)

class AutounmaskUseSlotConflictTestCase(TestCase):

	def testAutounmaskUseSlotConflict(self):

		ebuilds = {
			"sci-libs/K-1": {
				"IUSE": "+foo",
				"EAPI": 1
			},
			"sci-libs/L-1": {
				"DEPEND": "sci-libs/K[-foo]",
				"EAPI": 2
			},
			"sci-libs/M-1": {
				"DEPEND": "sci-libs/K[foo=]",
				"IUSE": "+foo",
				"EAPI": 2
			},
		}

		installed = {}

		test_cases = (
			ResolverPlaygroundTestCase(
				["sci-libs/L", "sci-libs/M"],
				options={"--backtrack": 0},
				success = False,
				mergelist = [
					"sci-libs/L-1",
					"sci-libs/M-1",
					"sci-libs/K-1",
				],
				ignore_mergelist_order = True,
				slot_collision_solutions = [
					{
						"sci-libs/K-1": {"foo": False},
						"sci-libs/M-1": {"foo": False}
					}
				]
			),
		)

		playground = ResolverPlayground(
			ebuilds=ebuilds, installed=installed, debug=True)
		try:
			for test_case in test_cases:
				playground.run_TestCase(test_case)
				self.assertEqual(test_case.test_success,
					True, test_case.fail_msg)
		finally:
			playground.debug = False
			playground.cleanup()
Comment 1 Zac Medico gentoo-dev 2017-04-17 09:21:20 UTC
If we're going to add pkg.with_use(self._pkg_use_enabled(pkg)) to the graph, then we need to add USE to the hash key. Also, the way that _pkg_use_enabled is used everywhere needs to be carefully considered. Maybe it will be okay as long as USE is part of the hash key.
Comment 2 Zac Medico gentoo-dev 2017-04-24 07:06:41 UTC
Fixing this bug will require significant changes, and it shouldn't block bug 615680.