Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 615468 - net-im/skypeforlinux: Redundant use of "no-source-code" license label
Summary: net-im/skypeforlinux: Redundant use of "no-source-code" license label
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gino McCarty
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 615456
  Show dependency tree
 
Reported: 2017-04-13 17:21 UTC by Ulrich Müller
Modified: 2018-10-19 20:16 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2017-04-13 17:21:13 UTC
The "no-source-code" license label is redundant if the license itself is not in the @FREE license group. See the tracker bug 615456 for a longer explanation.

I also have doubts if Skype-TOS covers all components of the package.
Comment 1 Karol Grudziński 2017-05-11 23:11:05 UTC
OK, so removing 'no-source-code' from license is obvious.

As for he second part of your comment. Should I add licenses for bundled libnode (BSD-2) and FFmpeg (LGPL-2.1? GPL-2?) ?
Comment 2 Ulrich Müller gentoo-dev 2017-05-12 06:25:17 UTC
(In reply to Karol Grudziński from comment #1)
> Should I add licenses for bundled libnode (BSD-2) and FFmpeg

Yes, please.

> (LGPL-2.1? GPL-2?) ?

This should be LGPL (but I haven't checked), because a proprietary binary linked against GPL components would not be distributable.
Comment 3 Karol Grudziński 2017-05-12 10:52:32 UTC
I did some research and it looks that libffmpeg.so comes from Chromium which is used by Electron which was used to make new Skype. There is a long list of apps that were also made in Electron (Slack, Atom, VSC etc.).
Comment 4 mercuriete 2017-06-11 23:11:16 UTC
Hi guys.

I installed this package because skype is being discontinued in portage.

My surprise is i could install it without accepting any licence what is totally wrong.


If you go here: https://www.skype.com/en/download-skype/skype-for-computer/

you can read:

By downloading and installing Skype for Linux Beta, you agree to the terms of use and privacy statement.

and a link to this EULA:

https://www.microsoft.com/en-us/servicesagreement/

Please Update the EULA of skypeforlinux because is not open/free software.

Thank you for your work! :)
Comment 5 mercuriete 2017-06-11 23:32:18 UTC
Only for aclaration... It seems skypeforlinux beta dont use SkypeTOS eula anymore. So somebody has to update the EULA of skypeforlinux to the new one.

I have to file a new bug or i can leave in this one?

because is not about "no-source-code" the problem is about SkypeTOS is not used anymore and there are a new EULA called Microsoft Services Agreement.

https://www.microsoft.com/en-us/servicesagreement/

I am not sure if i am right but the point is... I could install skypeforlinux without putting anything inside /etc/portage/package.license

Thank you again :)
Comment 6 Ulrich Müller gentoo-dev 2017-06-12 05:38:15 UTC
(In reply to mercuriete from comment #5)
> because is not about "no-source-code" the problem is about SkypeTOS is not
> used anymore and there are a new EULA called Microsoft Services Agreement.
> 
> https://www.microsoft.com/en-us/servicesagreement/

These seem to be the terms for using their facilities. What we need in LICENSE are the terms that regulate distribution of the program, though. Copyright is about distributing, not about using a program.

> I am not sure if i am right but the point is... I could install
> skypeforlinux without putting anything inside /etc/portage/package.license

What is your ACCEPT_LICENSE? If you set it to "@FREE" (which isn't the Portage default, unfortunately) then you should get only free software.
Comment 7 mercuriete 2017-06-13 19:13:05 UTC
Thank you for your quick response.

cat /etc/portage/package.license 
# required by chrome-binary-plugins (argument)
www-plugins/chrome-binary-plugins:stable google-chrome
# required by skype (argument)
net-im/skype skype-4.0.0.7-copyright
dev-dotnet/referenceassemblies-pcl dotnet-eula

# required by adobe-flash (argument)
www-plugins/adobe-flash AdobeFlash-11.x



emerge --info|grep LICENSE
ACCEPT_LICENSE="* -@EULA"



------------------------

I don't completely understand all the license stuff in gentoo.

If is the right behaviour sorry for the noise in this issue.

I was thinking that I had to accept license in the same way that I had to do with net-im/skype.


Thank you very much for your work :)
Comment 8 Larry the Git Cow gentoo-dev 2017-11-27 18:29:03 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f080bf81d486d5d1dda6119662c493487c3a6eb2

commit f080bf81d486d5d1dda6119662c493487c3a6eb2
Author:     Karol Grudziński <krlgrudzinski+gentoo@gmail.com>
AuthorDate: 2017-11-02 16:24:42 +0000
Commit:     Agostino Sarubbo <ago@gentoo.org>
CommitDate: 2017-11-27 18:28:56 +0000

    net-im/skypeforlinux: version bump
    
    - Remove ebuilds for obsolete versions
    - Bump to 8.11.0.4 with changes in ebuild:
        - updated the list of dependencies
        - updated list of licenses
        - simplified the installation
        - other QA fixes
    
    Bug: https://bugs.gentoo.org/636278
    Bug: https://bugs.gentoo.org/615468
    Package-Manager: Portage-2.3.13, Repoman-2.3.4

 net-im/skypeforlinux/Manifest                      |   3 +-
 net-im/skypeforlinux/skypeforlinux-5.4.0.1.ebuild  | 108 ---------------------
 ....5.0.1.ebuild => skypeforlinux-8.11.0.4.ebuild} |  50 +++++-----
 3 files changed, 25 insertions(+), 136 deletions(-)}
Comment 9 Gino McCarty 2018-10-19 20:16:15 UTC
Hello,

new maintainer here, from the looks of things, this is now taken care of.