Created attachment 469480 [details, diff] patch to handle pulseaudio/apulse dependancy Hi, Since version 52, firefox-bin use pulseaudio instead of alsa. There should be a message on the ebuild indicating that no sound (as it is done for video and ffmpeg). Alternatively, it's possible to use apulse for system without pulseaudio. I've written a small patch on firefox-bin-52.0.1.ebuild to try to handle that. Please find it attached. Regards.
Patches should be in unified format (i.e. created by `diff -u`). About apulse, some suggestions are in bug #613980.
Sorry, I did not find the other bug... Here is an updated version of my patch (in unified format) and using apulse to launch firefox-bin (if apulse is enabled). Regards.
Created attachment 469758 [details, diff] patch to handle pulseaudio/apulse dependancy v2
Adding pulseaudio flag (to addition to apulse flag) as a way to pull in optional dependency, even without actual code being added could be good thing ( skype uses same approach [1] ). But proposed patch feels inconsistently to me. I would either add flags for all optional features, which does not do actual code changes to the package (pulseaudio, ffmpeg and crashreporter) or for none of them. (But this may be separate issue.) Anyway if pulseaudio flag is added, then there should probably be constraint, not to use both apulse and pulseaudio flags at the same time. ( See [2] [1] . ) In addition to that I would also use "exec" command in case of apulse, so that another wrapper shell process, waiting for firefox to close, is avoided. [1] https://gitweb.gentoo.org/repo/gentoo.git/tree/net-im/skype/skype-4.3.0.37-r6.ebuild [2] https://devmanual.gentoo.org/ebuild-writing/eapi/#variables
Created attachment 470024 [details, diff] patch to handle pulseaudio/apulse dependancy v3 Here is the v3 version: - added missing exec for apulse case; - added RESTRICT_USE to prevent enabling apulse and pulseaudio at the same time; - added a crashreporter and a ffmpeg use flags (for consistency). Thanks Zdeněk for the comment.
I approached the same end-goal a different way, though it's somewhat close to your final iteration: commit 27dfc5592208b407bbaf26cbc780bfae5294c001 Author: Ian Stakenvicius <axs@gentoo.org> Date: Wed Apr 12 17:09:22 2017 -0400 www-client/firefox-bin: add apulse compatibility to wrapper and some use-flags Added ffmpeg and pulseaudio to IUSE, default-enabled, to be (A) compatible with www-client/firefox and (B) ensure dependencies for this functionality is brought in and retained without @world entries required. It's a binary package so the hit is minimal to be dealing with optional runtime-only deps with use flags. Also added apulse to the LD_LIBRARY_PATH so that it will be used to provide audio support when it is installed.
Works for me :) Thanks Ian.
