614116 – sys-apps/portage: EbuildBuild._fetchonly_exit triggers event loop recursion

Bug 614116 - sys-apps/portage: EbuildBuild._fetchonly_exit triggers event loop recursion

Summary: sys-apps/portage: EbuildBuild._fetchonly_exit triggers event loop recursion

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Core - Interface (emerge) (show other bugs)
Hardware:	All All

Importance:	Normal normal (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:	591760 619102
	Show dependency tree

Reported:	2017-03-28 04:55 UTC by Zac Medico
Modified:	2017-08-11 19:47 UTC (History)
CC List:	0 users

See Also:	613990
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Zac Medico gentoo-dev

2017-03-28 04:55:13 UTC

The EbuildBuild._fetchonly_exit method triggers event loop recursion when it calls the spawn_nofetch function. There spawn_nofetch function needs to be refactored into an asynchronous task.

Comment 1 Zac Medico gentoo-dev

2017-04-03 01:05:32 UTC

The EbuildBuild._fetchonly_exit method can also call digestgen, which can trigger event loop recursion via portdbapi.aux_get and spawn_nofetch calls.

Comment 2 Zac Medico gentoo-dev

2017-04-03 01:24:11 UTC

We can move the digestgen call from EbuildBuild._fetchonly_exit (bug 470238) to Scheduler._generate_digests (where it currently skips the digestgen call when --fetchonly is enabled).

Comment 3 Zac Medico gentoo-dev

2017-04-03 02:47:03 UTC

Patches posted for review:

https://archives.gentoo.org/gentoo-portage-dev/message/f0817238440cef52389f0a95e22368af
https://github.com/gentoo/portage/pull/154

Comment 4 Zac Medico gentoo-dev

2017-04-04 03:25:34 UTC

This is in the master branch:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=f05d0864653e082bd60db67b52132c4ba6515339
https://gitweb.gentoo.org/proj/portage.git/commit/?id=285d5d038d8bb8a17d853816e156147c8c59f248

Comment 5 Zac Medico gentoo-dev

2017-08-11 19:47:16 UTC

Fixed in 2.3.6.