Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 613378 - <dev-perl/Data-FormValidator-4.860.0-r1 requires '.' in @INC ( do "test/00_base.badformat" failed, '.' is no longer in @INC )
Summary: <dev-perl/Data-FormValidator-4.860.0-r1 requires '.' in @INC ( do "test/00_ba...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Low minor (vote)
Assignee: Gentoo Perl team
URL: https://rt.cpan.org/Ticket/Display.ht...
Whiteboard:
Keywords: TESTFAILURE
Depends on: 624822
Blocks: perl-5.26-no-dot-inc
  Show dependency tree
 
Reported: 2017-03-21 02:28 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2017-12-17 01:25 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2017-03-21 02:28:13 UTC
A test exposes:

https://metacpan.org/source/DFARRELL/Data-FormValidator-4.85/lib/Data/FormValidator.pm#L886-903


sub load_profiles {
    my $self = shift;
 
    my $file = $self->{profile_file};
   ... 
    $self->{profiles} = do $file;
}

This is a relative path in at least one test, and is a runtime problem.

No fix known atm.

Present in all versions in tree.
Comment 1 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2017-03-31 10:41:19 UTC
t/00_base.t .............................. 1/5 do "test/00_base.badformat" failed, '.' is no longer in @INC at /var/tmp/portage/dev-perl/Data-FormValidator-4.810.0-r1/work/Data-FormValidator-4.81/blib/lib/Data/FormValidator.pm line 898.
do "test/00_base.profile" failed, '.' is no longer in @INC at /var/tmp/portage/dev-perl/Data-FormValidator-4.810.0-r1/work/Data-FormValidator-4.81/blib/lib/Data/FormValidator.pm line 898.
Input profiles didn't return a hash ref:
# Looks like your test exited with 2 just after 4.
t/00_base.t .............................. Dubious, test returned 2 (wstat 512, 0x200)
Failed 1/5 subtests
t/02_code_ref.t .......................... ok
Comment 2 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2017-06-03 19:25:36 UTC
commit:  e6b0c67a6a0565bb6e0e50d74e3a9d0bc88e2842
author:  2017-06-04 07:10:43 +1200 Kent Fredric <kentnl@gentoo.org>
commit:  2017-06-04 07:22:25 +1200 Kent Fredric <kentnl@gentoo.org>
gpg-key: E854324B1366A820

    dev-perl/Data-FormValidator: Add fix for '.' in @INC re bug #613378

    This avoids the '.' in @INC issue by absolutizing paths at construction
    time so that "do" never loads any path other than the one the user
    assumed would be read.
    
    Bug: https://bugs.gentoo.org/613378
    Package-Manager: Portage-2.3.5, Repoman-2.3.2


 .../Data-FormValidator-4.860.0-r1.ebuild               | 32 +++
 .../Data-FormValidator/files/4.86-dot-in-inc.patch     | 58 +++++
 2 files changed, 90 insertions(+)


Patch submitted upstream at: https://github.com/dnmfarrell/Data-FormValidator/pull/6
Comment 3 Larry the Git Cow gentoo-dev 2017-12-16 11:27:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=be65d1bd04f53379b9b0cf60dcb1d205c6f774c9

commit be65d1bd04f53379b9b0cf60dcb1d205c6f774c9
Author:     Kent Fredric <kentnl@gentoo.org>
AuthorDate: 2017-12-16 10:57:05 +0000
Commit:     Kent Fredric <kentnl@gentoo.org>
CommitDate: 2017-12-16 11:22:38 +0000

    dev-perl/Data-FormValidator: Cleanup old re bug #613378
    
    Closes: https://bugs.gentoo.org/613378
    Package-Manager: Portage-2.3.18, Repoman-2.3.6

 .../Data-FormValidator-4.810.0-r1.ebuild           | 31 ----------------------
 .../Data-FormValidator-4.850.0.ebuild              | 30 ---------------------
 .../Data-FormValidator-4.860.0.ebuild              | 30 ---------------------
 dev-perl/Data-FormValidator/Manifest               |  2 --
 4 files changed, 93 deletions(-)