Created attachment 467572 [details] ffdiaporama-2.2_pre.ebuild ffdiaporama development has stopped more than two years ago. Version 2.2 has never been officially released but introduced some interesting stuff and this version has received some patches and been packaged by some linux distros. As the proxy maintainer of this package I suggest to update this package to version 2.2 in portage. I attach an ebuild I wrote for that purpose, introducing some changes : - allow the choice between qt4 and qt5 - drop internal openclipart package in favor of the portage media-gfx/openclipart package This package has been tested with ffmpeg 3.0 and libav 11
Created attachment 467574 [details, diff] ffmpeg 3.0 patch for ffdiaporama 2.2
Created attachment 467576 [details, diff] libav 11 patch for ffdiaporama 2.2
Created attachment 467578 [details, diff] qtmultimedia:4 patch for ffdiaporama 2.2
Created attachment 467610 [details] ffdiaporama-2.2_pre20140701.ebuild * 2016 -> 2017 in header * Adaptation of the ebuild to the new _pre20140701 suffix * Expected patch filenames are ffdiaporama-2.2-ffmpeg-3.0.patch, ffdiaporama-2.2-libav11.patch and ffdiaporama-2.2-qt4multimedia.patch
Created attachment 467612 [details] ffdiaporama metadata file Fix typo in metadata: openslipart -> openclipart
Created attachment 475160 [details, diff] ffmpeg 3.0 patch for ffdiaporama 2.2 new patch to reduce size (see bug #620650)
Created attachment 475162 [details, diff] libav 11 patch for ffdiaporama 2.2 new patch to reduce size (see bug #620650)
Created attachment 509106 [details] ffdiaporama-2.2_pre20140701.ebuild New version to replace fdo-mime eclass by xdg-utils eclass
Created attachment 509108 [details] ffdiaporama metadata file Replacing some spaces by tabulations in metadata.xml file
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: • Please test the ebuild with repoman https://wiki.gentoo.org/wiki/Repoman * why do you need eutils?
Thanks for the quick look! eutils is useless, I agree . It was there before to make use of doicon. I already tested it with repoman, and it's not complaining at all in my local repository. Have you also updated the metadata file attached to this bug?
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=41ccf958a8fd6df1f13df748ab5a47e16abe9077 commit 41ccf958a8fd6df1f13df748ab5a47e16abe9077 Author: Olivier Laurantin <olivier.laurantin@laposte.net> AuthorDate: 2017-12-10 14:13:55 +0000 Commit: Jonas Stein <jstein@gentoo.org> CommitDate: 2017-12-10 14:20:42 +0000 media-video/ffdiaporama: Fix typo in metadata Fix typo in metadata: openslipart -> openclipart Bug: https://bugs.gentoo.org/613230 Package-Manager: Portage-2.3.17, Repoman-2.3.6 media-video/ffdiaporama/metadata.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)}
the metadata is merged. The eutils is still in the ebuild. Could you prepare a PR on github? We should not put 40kB patches in the git tree. I uploaded the two large patches for you into my devspace. The same for the large 2.1 patch https://dev.gentoo.org/~jstein/dist/ffdiaporama-2.1-libav10.patch https://dev.gentoo.org/~jstein/dist/ffdiaporama-2.2-ffmpeg-3.0.patch https://dev.gentoo.org/~jstein/dist/ffdiaporama-2.2-libav11.patch Please use these in your 2.2 ebuild. I fixed the 2.1 already for you. The patches should follow the same naming scheme. This would save a lot of work for the developer who merges it.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9e9f5d53c03d49c5d53d7cf61c4f7a647779241d commit 9e9f5d53c03d49c5d53d7cf61c4f7a647779241d Author: Olivier Laurantin <olivier.laurantin@laposte.net> AuthorDate: 2017-12-11 22:15:54 +0000 Commit: Patrice Clement <monsieurp@gentoo.org> CommitDate: 2017-12-21 20:26:24 +0000 media-video/ffdiaporama: version bump to 2.2_pre20140701. The ebuild now depends on media-gfx/openclipart instead of downloading a specific version. This also adds the qt5 USE flag. Closes: https://bugs.gentoo.org/613230 Closes: https://github.com/gentoo/gentoo/pull/6526 media-video/ffdiaporama/Manifest | 4 + .../ffdiaporama/ffdiaporama-2.2_pre20140701.ebuild | 91 ++++++++++++++++++++++ .../files/ffdiaporama-2.2-qt4multimedia.patch | 25 ++++++ 3 files changed, 120 insertions(+)
