Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 612792 - media-video/vlc-2.2.4-r1[speex]: Automagic dependency on media-libs/speexdsp
Summary: media-video/vlc-2.2.4-r1[speex]: Automagic dependency on media-libs/speexdsp
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-16 08:22 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2017-06-12 21:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2017-03-16 08:22:48 UTC 
media-video/vlc-2.2.4-r1[speex] has automagic dependency on media-libs/speexdsp.

So with USE="speex", only when media-libs/speexdsp is already installed, /usr/${LIBDIR}/vlc/plugins/audio_filter/libspeex_resampler_plugin.so will be installed by media-video/vlc.


configure.ac contains:

dnl
dnl  Speex plugins
dnl
PKG_ENABLE_MODULES_VLC([SPEEX], [], [ogg speex >= 1.0.5], [Speex support], [auto])
have_speexdsp="no"
AS_IF([test "${enable_speex}" != "no"], [
  PKG_CHECK_MODULES([SPEEXDSP], [speexdsp], [
    have_speexdsp="yes"
  ], [
    AC_MSG_WARN([${SPEEXDSP_PKG_ERRORS}.])
  ])
])
AM_CONDITIONAL([HAVE_SPEEXDSP], [test "$have_speexdsp" = "yes"])


modules/audio_filter/Modules.am contains:

if HAVE_SPEEXDSP
audio_filter_LTLIBRARIES += libspeex_resampler_plugin.la
endif


I suggest to make media-video/vlc[speex] depend additionally on media-libs/speexdsp.
RDEPEND="...
  speex? ( || (
    ( >=media-libs/speexdsp-1.2.0:0 media-libs/speexdsp:0 )
    <media-libs/speexdsp-1.2.0:0
  ) )
..."
Comment 1 Arfrever Frehtes Taifersar Arahesis 2017-03-16 08:26:04 UTC 
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #0)
> RDEPEND="...
>   speex? ( || (
>     ( >=media-libs/speexdsp-1.2.0:0 media-libs/speexdsp:0 )
>     <media-libs/speexdsp-1.2.0:0
>   ) )
> ..."

Copy/paste error above. It should be:

RDEPEND="...
  speex? ( || (
    ( >=media-libs/speex-1.2.0:0 media-libs/speexdsp:0 )
    <media-libs/speex-1.2.0:0
  ) )
..."
Comment 2 Arfrever Frehtes Taifersar Arahesis 2017-03-16 08:36:40 UTC 
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #1)
> RDEPEND="...
>   speex? ( || (
>     ( >=media-libs/speex-1.2.0:0 media-libs/speexdsp:0 )
>     <media-libs/speex-1.2.0:0
>   ) )
> ..."

Or for simplicity, revision bump with just:

RDEPEND="...
  speex? ( >=media-libs/speex-1.2.0:0 media-libs/speexdsp:0 )
..."