Bug 610456 – toolchain.eclass: uses built_with_use

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Michał Górny 2017-02-22 07:31:51 UTC]

eclass/toolchain.eclass:                        elif built_with_use --hidden --missing false ${CATEGORY}/${needed_libc} crosscompile_opts_headers-only ; then

[Comment 1 Michał Górny 2017-07-01 16:34:50 UTC]

Ping.

[Comment 2 Ulrich Müller 2018-01-03 22:43:39 UTC]

Any progress here?
This is the last usage in the tree blocking built_with_use removal.

[Comment 3 Ulrich Müller 2018-01-04 09:12:48 UTC]

Created attachment 513152 [details, diff]
proposed patch

(In reply to Michał Górny from comment #0)
> built_with_use --hidden --missing false ${CATEGORY}/${needed_libc} crosscompile_opts_headers-only

This should be equivalent to the following, using 4-style use dependencies:
has_version "${CATEGORY}/${needed_libc}[crosscompile_opts_headers-only(-)]"

All ebuilds inheriting toolchain are at EAPI 4 at least:
https://qa-reports.gentoo.org/output/eapi-per-eclass/toolchain.eclass/

Patch is attached.

[Comment 4 Anthony Basile 2018-01-04 13:05:48 UTC]

(In reply to Ulrich Müller from comment #3)
> Created attachment 513152 [details, diff] [details, diff]
> proposed patch
> 
> (In reply to Michał Górny from comment #0)
> > built_with_use --hidden --missing false ${CATEGORY}/${needed_libc} crosscompile_opts_headers-only
> 
> This should be equivalent to the following, using 4-style use dependencies:
> has_version "${CATEGORY}/${needed_libc}[crosscompile_opts_headers-only(-)]"
> 
> All ebuilds inheriting toolchain are at EAPI 4 at least:
> https://qa-reports.gentoo.org/output/eapi-per-eclass/toolchain.eclass/
> 
> Patch is attached.

okay i can test this patch and apply.  i don't know what built_with_use does because i've never seen it before and can only assume its function from the replacement with has_version.

i'll also alert the toolchain folks to look at this bug in lieu of emailing the patch to the list.

[Comment 5 Anthony Basile 2018-01-04 17:16:52 UTC]

(In reply to Anthony Basile from comment #4)
> (In reply to Ulrich Müller from comment #3)
> > Created attachment 513152 [details, diff] [details, diff] [details, diff]
> > proposed patch
> > 
> > (In reply to Michał Górny from comment #0)
> > > built_with_use --hidden --missing false ${CATEGORY}/${needed_libc} crosscompile_opts_headers-only
> > 
> > This should be equivalent to the following, using 4-style use dependencies:
> > has_version "${CATEGORY}/${needed_libc}[crosscompile_opts_headers-only(-)]"
> > 
> > All ebuilds inheriting toolchain are at EAPI 4 at least:
> > https://qa-reports.gentoo.org/output/eapi-per-eclass/toolchain.eclass/
> > 
> > Patch is attached.
> 
> okay i can test this patch and apply.  i don't know what built_with_use does
> because i've never seen it before and can only assume its function from the
> replacement with has_version.
> 
> i'll also alert the toolchain folks to look at this bug in lieu of emailing
> the patch to the list.


as expected, no problems.  i'll commit this by tomorrow.

[Comment 6 Sergei Trofimovich (RETIRED) 2018-01-04 19:58:28 UTC]

(In reply to Anthony Basile from comment #5)
> as expected, no problems.  i'll commit this by tomorrow.

Can you shed some light what you have tested? Did you run crossdev for a new target? That should be enough.

[Comment 7 Anthony Basile 2018-01-04 22:06:18 UTC]

(In reply to Sergei Trofimovich from comment #6)
> (In reply to Anthony Basile from comment #5)
> > as expected, no problems.  i'll commit this by tomorrow.
> 
> Can you shed some light what you have tested? Did you run crossdev for a new
> target? That should be enough.

I built non-masked gcc's and some kgcc64.  i did not run crossdev.  you've been doing some work with that, do you want to try that and see.

[Comment 8 Sergei Trofimovich (RETIRED) 2018-01-04 22:59:18 UTC]

(In reply to Anthony Basile from comment #7)
> (In reply to Sergei Trofimovich from comment #6)
> > (In reply to Anthony Basile from comment #5)
> > > as expected, no problems.  i'll commit this by tomorrow.
> > 
> > Can you shed some light what you have tested? Did you run crossdev for a new
> > target? That should be enough.
> 
> I built non-masked gcc's and some kgcc64.  i did not run crossdev.  you've
> been doing some work with that, do you want to try that and see.

Aha, no problem. I'll test it. Should I use the attached patch as-is or there is something newer posted for review somewhere?

[Comment 9 Sergei Trofimovich (RETIRED) 2018-01-05 23:10:33 UTC]

> Aha, no problem. I'll test it. Should I use the attached patch as-is or
> there is something newer posted for review somewhere?

Tested crossdev as: 

# initial build
$ crossdev -t ia64-unknown-linux-gnu
# update (no-op)
$ crossdev -t ia64-unknown-linux-gnu

$ echo 'int main(){}' | ia64-unknown-linux-gnu-gcc -x c -o a -
$ file a
a: ELF 64-bit LSB shared object, IA-64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-ia64.so.2, for GNU/Linux 3.2.18, not stripped

All is fine!

[Comment 10 Anthony Basile 2018-01-05 23:16:02 UTC]

commit 1df6e6dc6c406541eff5be543659b76b4e909da4 (HEAD -> master, origin/master, origin/HEAD)
Author: Ulrich Müller <[e-mail]>
Date:   Fri Jan 5 18:14:58 2018 -0500

    toolchain.eclass: remove built_with_use, bug #610456
    
    Signed-off-by: Anthony G. Basile <[e-mail]>