Created attachment 458510 [details] build.log x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC=\"/etc/wgetrc\" -DLOCALEDIR=\"/usr/share/locale\" -I. -I../lib -I../lib -DHAVE_LIBSSL -DNDEBUG -O2 -pipe -c -o openssl.o openssl.c openssl.c: In function 'ssl_init': openssl.c:214:12: warning: assignment makes pointer from integer without a cast meth = SSLv2_client_method (); ^ openssl.c:230:12: warning: assignment makes pointer from integer without a cast meth = TLSv1_client_method (); ^ openssl.c:235:12: warning: assignment makes pointer from integer without a cast meth = TLSv1_1_client_method (); ^ openssl.c:239:12: warning: assignment makes pointer from integer without a cast meth = TLSv1_2_client_method (); ^ openssl.c: In function 'ssl_connect_wget': openssl.c:586:50: error: 'SSL_ST_OK' undeclared (first use in this function) if (scwt_ctx.result <= 0 || SSL_state(conn) != SSL_ST_OK) ^ openssl.c:586:50: note: each undeclared identifier is reported only once for each function it appears in Makefile:1585: recipe for target 'openssl.o' failed make[3]: *** [openssl.o] Error 1 make[3]: Leaving directory '/var/tmp/portage/net-misc/wget-1.18/work/wget-1.18/src' Makefile:1400: recipe for target 'all' failed make[2]: *** [all] Error 2 make[2]: Leaving directory '/var/tmp/portage/net-misc/wget-1.18/work/wget-1.18/src' Makefile:1408: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/var/tmp/portage/net-misc/wget-1.18/work/wget-1.18' Makefile:1364: recipe for target 'all' failed make: *** [all] Error 2 * ERROR: net-misc/wget-1.18::gentoo failed (compile phase): * emake failed
localhost ~ # emerge --info '=net-misc/wget-1.18::gentoo' openssl Portage 2.3.0 (python 3.4.5-final-0, default/linux/amd64/13.0, gcc-4.9.4, glibc-2.22-r4, 4.4.6-gentoo x86_64) ================================================================= System Settings ================================================================= System uname: Linux-4.4.6-gentoo-x86_64-Intel-R-_Core-TM-_i5-2520M_CPU_@_2.50GHz-with-gentoo-2.3 KiB Mem: 4043380 total, 3605136 free KiB Swap: 0 total, 0 free Timestamp of repository gentoo: Tue, 03 Jan 2017 00:45:01 +0000 sh bash 4.3_p48-r1 ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1 app-shells/bash: 4.3_p48-r1::gentoo dev-lang/perl: 5.22.3_rc4::gentoo dev-lang/python: 2.7.12::gentoo, 3.4.5::gentoo dev-util/pkgconfig: 0.28-r2::gentoo sys-apps/baselayout: 2.3::gentoo sys-apps/openrc: 0.22.4::gentoo sys-apps/sandbox: 2.10-r1::gentoo sys-devel/autoconf: 2.69::gentoo sys-devel/automake: 1.14.1::gentoo, 1.15::gentoo sys-devel/binutils: 2.25.1-r1::gentoo sys-devel/gcc: 4.9.4::gentoo sys-devel/gcc-config: 1.7.3::gentoo sys-devel/libtool: 2.4.6-r2::gentoo sys-devel/make: 4.1-r1::gentoo sys-kernel/linux-headers: 4.4::gentoo (virtual/os-headers) sys-libs/glibc: 2.22-r4::gentoo Repositories: gentoo location: /usr/portage sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 ACCEPT_KEYWORDS="amd64" ACCEPT_LICENSE="* -@EULA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo" CXXFLAGS="-O2 -pipe" DISTDIR="/usr/portage/distfiles" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://distfiles.gentoo.org" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="acl amd64 berkdb bindist bzip2 cli cracklib crypt cxx dri fortran gdbm iconv ipv6 mmx mmxext modules multilib ncurses nls nptl openmp pam pcre readline seccomp session sse sse2 ssl tcpd unicode xattr zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby21" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON ================================================================= Package Settings ================================================================= net-misc/wget-1.18::gentoo was built with the following: USE="ipv6 nls pcre ssl zlib -debug -gnutls -idn (-libressl) -ntlm -static -test -uuid" ABI_X86="64" dev-libs/openssl-1.1.0c::gentoo was built with the following: USE="asm bindist zlib -rfc3779 -sctp -static-libs -test -tls-heartbeat -vanilla" ABI_X86="64 -32 -x32" CPU_FLAGS_X86="sse2" CFLAGS="-O2 -pipe -fno-strict-aliasing -Wa,--noexecstack" CXXFLAGS="-O2 -pipe -fno-strict-aliasing -Wa,--noexecstack" localhost ~ # emerge -pqv '=net-misc/wget-1.18::gentoo' openssl [ebuild R ] dev-libs/openssl-1.1.0c USE="asm bindist zlib -rfc3779 -sctp -static-libs {-test} -tls-heartbeat -vanilla" ABI_X86="(64) -32 (-x32)" CPU_FLAGS_X86="(sse2)" [ebuild R ] net-misc/wget-1.18 USE="ipv6 nls pcre ssl zlib -debug -gnutls -idn (-libressl) -ntlm -static {-test} -uuid" * IMPORTANT: 12 news items need reading for repository 'gentoo'. * Use eselect news read to view new items.
A fix has already been added to the wget git repository (see URL) but yet lacking a release containing the fix.
Should be fixed in wget-1.19
Reopening. The packages still fail whithout deprecated features from openssl: i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC=\"/etc/wgetrc\" -DLOCALEDIR=\"/usr/share/locale\" -I. -I../lib -I../lib -DHAVE_LIBSSL -DNDEBUG -march=native -O2 -pipe -c -o openssl.o openssl.c openssl.c: In function 'ssl_init': openssl.c:181:7: warning: implicit declaration of function 'OPENSSL_config' [-Wimplicit-function-declaration] OPENSSL_config (NULL); ^ openssl.c:205:3: warning: implicit declaration of function 'SSL_library_init' [-Wimplicit-function-declaration] SSL_library_init (); ^ openssl.c:206:3: warning: implicit declaration of function 'SSL_load_error_strings' [-Wimplicit-function-declaration] SSL_load_error_strings (); ^ openssl.c:232:14: warning: implicit declaration of function 'TLSv1_client_method' [-Wimplicit-function-declaration] meth = TLSv1_client_method (); ^ openssl.c:232:12: warning: assignment makes pointer from integer without a cast [-Wint-conversion] meth = TLSv1_client_method (); ^ openssl.c:237:14: warning: implicit declaration of function 'TLSv1_1_client_method' [-Wimplicit-function-declaration] meth = TLSv1_1_client_method (); ^ openssl.c:237:12: warning: assignment makes pointer from integer without a cast [-Wint-conversion] meth = TLSv1_1_client_method (); ^ openssl.c:241:14: warning: implicit declaration of function 'TLSv1_2_client_method' [-Wimplicit-function-declaration] meth = TLSv1_2_client_method (); ^ openssl.c:241:12: warning: assignment makes pointer from integer without a cast [-Wint-conversion] meth = TLSv1_2_client_method (); ^ i686-pc-linux-gnu-gcc -DHAVE_LIBSSL -DNDEBUG -march=native -O2 -pipe -Wl,-O1 -Wl,--hash-style=gnu -Wl,--sort-common -Wl,--as-needed -o wget connect.o convert.o cookies.o ftp.o css_.o css-url.o ftp-basic.o ftp-ls.o hash.o host.o hsts.o html-parse.o html-url.o http.o init.o log.o main.o netrc.o progress.o ptimer.o recur.o res.o retr.o spider.o url.o warc.o xattr.o utils.o exits.o build_info.o iri.o version.o ftp-opie.o openssl.o ../lib/libgnu.a -lpcre -lidn2 -lssl -lcrypto -lz openssl.o: In function `ssl_init': openssl.c:(.text+0x546): undefined reference to `OPENSSL_config' openssl.c:(.text+0x619): undefined reference to `SSL_library_init' openssl.c:(.text+0x61e): undefined reference to `SSL_load_error_strings' openssl.c:(.text+0x63c): undefined reference to `TLSv1_2_client_method' openssl.c:(.text+0x7b9): undefined reference to `TLSv1_1_client_method' openssl.c:(.text+0x7c3): undefined reference to `TLSv1_client_method' collect2: error: ld returned 1 exit status make[3]: *** [Makefile:1565: wget] Error 1
*** Bug 632560 has been marked as a duplicate of this bug. ***
Created attachment 498698 [details, diff] wget-1.19.1-openssl-1.1.patch Patch by me, only tested with openssl 1.1.0f.
Emailed the wget mailing list, hopefully this will see some action on that side.
A reply from Tim Ruehsen on the mailing list. Can you confirm that this sounds good? The patch seems to have a bug. IMO, it should be if (ssl_options) SSL_CTX_set_options (ssl_ctx, ssl_options); +#if !defined(LIBRESSL_VERSION_NUMBER) && (OPENSSL_VERSION_NUMBER >= 0x10100000L) + if (ssl_proto_version) + SSL_CTX_set_min_proto_version(ssl_ctx, ssl_proto_version); +#endif + Because you only declare 'ssl_proto_version' only under the above conditions. Which means, the patch won't compile on older versions of Openssl. But please have a look and let me know if my assumption is right. The commit can be found in branch 'openssl-1.1'.
Created attachment 507956 [details, diff] wget-1.92.2-openssl-1.1.0-r1.patch Confirmed, the current proposed patch will fail with > openssl.c: In function 'ssl_init': > openssl.c:294:7: error: 'ssl_proto_version' undeclared (first use in this function); did you mean 'SSL_get_version'? > if (ssl_proto_version) > ^~~~~~~~~~~~~~~~~ > SSL_get_version The suggested change from Tim fixes the problem so that <openssl-1.1.0 user are still able to build wget. I am attaching an updated patch. Please re-test against >=openssl-1.1.0.
works, should it be added?
it was added to as 1.92.2-r2
