Bug 604408 – app-backup/fsarchiver-0.8.0 with >=sys-libs/glibc-2.25 : major / minor undefined

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Helmut Jarausch 2017-01-02 15:00:19 UTC]

Created attachment 458376 [details]
patch for gcc-6.3

This packages uses the functions or macros  minor and major, which aren't
defined anymore. I've copied the definitions from the kernel sources and renamed these to MINOR and MAJOR.

[Comment 1 Jeroen Roovers (RETIRED) 2017-01-06 14:06:40 UTC]

Comment on attachment 458376 [details]
patch for gcc-6.3

Build log, emerge --info output?

[Comment 2 Jeroen Roovers (RETIRED) 2017-01-06 14:07:23 UTC]

Pretty sure it's not GCC that matters here.

[Comment 3 fdupoux 2017-02-04 07:17:21 UTC]

fsarchiver-0.8.1 can be compiled successfully without any patch on ArchLinux with gcc-6.3.1. It is likely to be related to linux-headers.

[Comment 4 Peter Levine 2017-07-29 01:24:36 UTC]

I can't reproduce the issue but I assume it was fixed upstream at https://github.com/fdupoux/fsarchiver/commit/975c775b8c9b253fe411b456f0a5d560fcbbe1e9.

[Comment 5 Andreas K. Hüttel 2017-09-26 18:20:38 UTC]

This is a glibc-related problem. The definitions moved into a different header file.

[Comment 6 Andreas K. Hüttel 2017-09-26 18:21:22 UTC]

Comment on attachment 458376 [details]
patch for gcc-6.3

... and please dont patch it like this. It's just adding one more #include ...

[Comment 7 Andreas Sturmlechner 2017-09-26 18:35:00 UTC]

And also, per comment #4, this is already fixed in 0.8.2 which is in tree.