Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 602232 - media-libs/opencv-3.1.0-r6: needs ninja love or hate
Summary: media-libs/opencv-3.1.0-r6: needs ninja love or hate
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Amy Liffey
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: ninja-porting
  Show dependency tree
 
Reported: 2016-12-10 10:22 UTC by Michał Górny
Modified: 2016-12-10 21:29 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
media-libs:opencv-3.1.0-r6:20161210-083855.log (media-libs:opencv-3.1.0-r6:20161210-083855.log,619.97 KB, text/x-log)
2016-12-10 10:23 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-12-10 10:22:21 UTC
When make.conf has:

  CMAKE_BUILD_TYPE=ninja

opencv fails to build due to calling emake directly (instead of cmake-utils_src_make).

Please either update the ebuild to be make-agnostic, or force CMAKE_BUILD_TYPE to emake.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-12-10 10:23:10 UTC
Created attachment 455738 [details]
media-libs:opencv-3.1.0-r6:20161210-083855.log
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-12-10 13:46:44 UTC
Also, that python support code is awful. It kills all the upstream Python parts (including useful ones like obtaining info from Python interp) and instead forces some random hardcoded hackery in the ebuild.
Comment 3 Amy Liffey gentoo-dev 2016-12-10 13:58:21 UTC
(In reply to Michał Górny from comment #2)
> Also, that python support code is awful. It kills all the upstream Python
> parts (including useful ones like obtaining info from Python interp) and
> instead forces some random hardcoded hackery in the ebuild.

Patches are welcome :)
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-12-10 14:25:11 UTC
s/BUILD_TYPE/MAKEFILE_GENERATOR/ ofc.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-12-10 21:29:58 UTC
commit b11a2969d70e10f2d44c6d6f264a6d8df19fcb9c
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: Sat Dec 10 17:34:09 2016
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: Sat Dec 10 22:25:08 2016

    media-libs/opencv: Kill redundant 'emake clean' - fix ninja, #602232
    
    Kill the call to 'emake clean' for Python build directory which
    obviously does not work when Ninja is used instead of Makefiles. It is
    completely redundant since it is followed by 'rm -rf' of the whole
    directory (tested with Makefiles and Ninja).