This one is even worse than leatherman. 1) src_compile() and src_test() are noops, code is built in src_install()... 2) all library/header dependencies are test-conditional in DEPEND while I'm pretty sure it needs them for compiling, 3) it has a *terrible* hack for lib64 that just asks for trouble. It is certainly wrong on SYMLINK_LIB=no systems, and the only reason it doesn't blow up in my face is that you failed to ||die.
commit 0244ae37885db15de5c743ea47f3d00ea5b53c50 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: Tue Dec 6 00:38:54 2016 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: Tue Dec 6 00:52:10 2016 dev-ruby/facter: fix phases, #601746
1. fixed by you 2. deps have been fixed 3. not sure what to do here
mgorny, any pointers for the lib64 stuff?
(In reply to Matthew Thode ( prometheanfire ) from comment #3) > mgorny, any pointers for the lib64 stuff? Lastrite it? But seriously, probably one of the usual ways of adding libdirs to CMake files and submitting that upstream.
(GNUInstallDirs or CMAKE_LIBDIR_SUFFIX or sth like that)
btw, why is the package in the dev-ruby category? app-admin or app-misc are more appropriate categories imho.
mainly history is the reason, it was like that when I took it over
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=63fd0be576f822c65c0800bd7eb485266cf40b38 commit 63fd0be576f822c65c0800bd7eb485266cf40b38 Author: Alexander Tsoy <alexander@tsoy.me> AuthorDate: 2018-07-24 23:05:38 +0000 Commit: Matthew Thode <prometheanfire@gentoo.org> CommitDate: 2018-07-25 18:44:15 +0000 dev-ruby/facter: ebuild cleanup Cleanup: - do not use ${S} set by ruby-ng.eclass - correctly generate facter.rb, FACTERDIR environment variable is no longer required - remove no longer needed environment file - remove no longer needed multilib magic Closes: https://bugs.gentoo.org/601746 Closes: https://github.com/gentoo/gentoo/pull/9339 Signed-off-by: Matthew Thode <prometheanfire@gentoo.org> ...acter-3.11.3.ebuild => facter-3.11.3-r1.ebuild} | 62 +++++++++++---------- dev-ruby/facter/facter-9999.ebuild | 64 ++++++++++++---------- 2 files changed, 67 insertions(+), 59 deletions(-)
