Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 601162 - >=app-emulation/libguestfs{,-appliance}-1.36.3: version bump
Summary: >=app-emulation/libguestfs{,-appliance}-1.36.3: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Maxim Koltsov (RETIRED)
URL:
Whiteboard:
Keywords:
: 614584 (view as bug list)
Depends on:
Blocks: 610998 617986
  Show dependency tree
 
Reported: 2016-11-29 06:49 UTC by Maciej Piechotka
Modified: 2017-08-30 12:33 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for libguestfs 1.36.3 (libguestfs-1.36.3.ebuild,3.88 KB, text/plain)
2017-04-08 20:37 UTC, Hank Leininger
Details
patch file for files/1.36/ (0002_tinfo_fix.patch,556 bytes, patch)
2017-04-08 20:38 UTC, Hank Leininger
Details | Diff
Ebuild for libguestfs-1.36.5 (libguestfs-1.36.5.ebuild,3.92 KB, text/plain)
2017-06-27 22:49 UTC, Hank Leininger
Details
Additional patch, gtkdocize fix (0003_gtkdocize.patch,800 bytes, patch)
2017-06-27 22:51 UTC, Hank Leininger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Piechotka 2016-11-29 06:49:22 UTC
Bumping to 1.34.3 seems to work with exception of patches and I needed to removed files from po/POTFILES.
Comment 1 Hank Leininger 2017-04-03 20:39:10 UTC
I found this bug when I found that the existing 1.28.x will not compile with GCC 5.  Created #614584 with a bump request to a newer newer libguestfs.
Comment 2 Coacher 2017-04-06 10:30:48 UTC
*** Bug 614584 has been marked as a duplicate of this bug. ***
Comment 3 Hank Leininger 2017-04-08 20:37:01 UTC
Created attachment 469510 [details]
Ebuild for libguestfs 1.36.3
Comment 4 Hank Leininger 2017-04-08 20:38:07 UTC
Created attachment 469512 [details, diff]
patch file for files/1.36/

This patch comes from the jtriley overlay.
Comment 5 Hank Leininger 2017-06-27 22:49:02 UTC
Created attachment 478254 [details]
Ebuild for libguestfs-1.36.5

Ebuild for libguestfs-1.36.5 , fixes multiple problems.
Comment 6 Hank Leininger 2017-06-27 22:51:20 UTC
Created attachment 478256 [details, diff]
Additional patch, gtkdocize fix

Workaround for gtkdocize build failure, see uptream bug https://bugzilla.redhat.com/show_bug.cgi?id=1465665
Comment 7 Hank Leininger 2017-06-27 23:11:19 UTC
Updated ebuild to 1.36.5.

This is not just a version bump; it fixes multiple issues with the latest version in the portage tree, 1.28.5-r2, some of which have their own b.g.o bugs and some don't:

1) eclass changes made globbing in PATCHES= no longer supported, so we must list each patch explicitly.  Even the current 1.28.5-r2.ebuild in the tree is broken and will not build.

2) Fixes compilation with GCC5.  GCC5 is not supported by 1.28.x upstream AFAIK, while 1.36.x works fine; see closed-as-duplicate bug#614584

3) Updated upstream fixes build issues against >=gperf-3.1, see bug#617986

4) Updated upstream fixes build issues w/fuse, see bug#610998

5) Added patch to work around gtkdocize issue, see new upstream bug https://bugzilla.redhat.com/show_bug.cgi?id=1465665

6) Make the bash-completion USE flag do something: now the DEPENDS entry is conditional on it.  (There is no ./configure knob I don't think, but if bash-completion is not installed, build will simply skip it-this is not ideal, but better than current IMHO)
Comment 8 Hank Leininger 2017-07-01 02:52:38 UTC
(In reply to Hank Leininger from comment #7)
> 5) Added patch to work around gtkdocize issue, see new upstream bug
> https://bugzilla.redhat.com/show_bug.cgi?id=1465665

Note that upstream has addressed this differently, by removing the gtk-doc / gtkdocize dependency entirely (see that bug for the update).

If a new new libguestfs comes out soon I'll update this ticket with yet another version bump request; if not, I'll prepare a patch that cherry-picks the update unless someone beats me to it.
Comment 9 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2017-08-13 16:20:10 UTC
hlein:
The ocaml part of this isn't building:

ocamlfind ocamlc -g -annot -safe-string -warn-error CDEFLMPSUVYZX-3 -package unix,str -I . -I . -c events.mli -o events.cmi
ocamlc: unknown option `-safe-string'.
usage: ocamlfind ocamlc [options] file ...
  -package <name>         Refer to package when compiling
  -linkpkg                Link the packages in
...
Comment 10 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2017-08-13 21:51:47 UTC
hlein:
Update the 
dev-lang/ocaml dep should be updated to:
>=dev-lang/ocaml-4.04.0[ocamlopt]

I'm looking at issues with the ruby binding now.
Comment 11 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2017-08-13 23:06:14 UTC
Beyond the ruby binding, another failure:
make  install-data-hook
make[4]: Entering directory '/dev/shm/portage/app-emulation/libguestfs-1.36.5/work/libguestfs-1.36.5/po'
make[4]: *** No rule to make target '../builder/index-parse.c', needed by 'libguestfs.pot'.  Stop.
make[4]: Leaving directory '/dev/shm/portage/app-emulation/libguestfs-1.36.5/work/libguestfs-1.36.5/po'
make[3]: *** [Makefile:1759: install-data-am] Error 2
make[3]: Leaving directory '/dev/shm/portage/app-emulation/libguestfs-1.36.5/work/libguestfs-1.36.5/po'
make[2]: *** [Makefile:1710: install-am] Error 2
make[2]: Leaving directory '/dev/shm/portage/app-emulation/libguestfs-1.36.5/work/libguestfs-1.36.5/po'
make[1]: *** [Makefile:1949: install-recursive] Error 1
make[1]: Leaving directory '/dev/shm/portage/app-emulation/libguestfs-1.36.5/work/libguestfs-1.36.5'
make: *** [Makefile:2445: install] Error 2
 * ERROR: app-emulation/libguestfs-1.36.5::gentoo failed (install phase):
Comment 12 Richard Jones 2017-08-14 08:11:47 UTC
(In reply to Robin Johnson from comment #9)
> hlein:
> The ocaml part of this isn't building:
> 
> ocamlfind ocamlc -g -annot -safe-string -warn-error CDEFLMPSUVYZX-3 -package
> unix,str -I . -I . -c events.mli -o events.cmi
> ocamlc: unknown option `-safe-string'.
> usage: ocamlfind ocamlc [options] file ...
>   -package <name>         Refer to package when compiling
>   -linkpkg                Link the packages in
> ...

The configure script is supposed to be detecting if
the -safe-string option is supported, see:

https://github.com/libguestfs/libguestfs/blob/master/m4/guestfs_ocaml.m4#L114

I should note that it doesn't detect that feature directly,
but assumes it from the absence of the OCaml Bytes module.
There may be some other reason why it's failing however, best
to look at the config.log file.

An alternative would be to update to OCaml >= 4.02 (latest
upstream is 4.05).
Comment 13 Richard Jones 2017-08-14 08:15:43 UTC
(In reply to Robin Johnson from comment #11)
> Beyond the ruby binding, another failure:
> make  install-data-hook
> make[4]: Entering directory
> '/dev/shm/portage/app-emulation/libguestfs-1.36.5/work/libguestfs-1.36.5/po'
> make[4]: *** No rule to make target '../builder/index-parse.c', needed by
> 'libguestfs.pot'.  Stop.

This could be an actual bug in the build, but the way to work around
it is to add the following somewhere in your ebuild scripts:

$ rm po/POTFILES
$ make po/POTFILES

I guess it's something to do with you not enabling all the
virt tools, therefore virt-builder is not built, therefore this
file (which is generated by lex/yacc) is not created during the build.
Comment 14 Gilles Dartiguelongue (RETIRED) gentoo-dev 2017-08-30 12:33:19 UTC
Just bump to 1.36. Thanks for reporting.