Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 599506 - x11-misc/sddm: Add elogind support
Summary: x11-misc/sddm: Add elogind support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: LxQt maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: elogind-support
  Show dependency tree
 
Reported: 2016-11-11 17:02 UTC by Sven Eden
Modified: 2017-06-07 14:13 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sddm-0.14.0-r3.ebuild (sddm-0.14.0-r3.ebuild,2.39 KB, text/plain)
2016-11-11 17:03 UTC, Sven Eden
Details
Patch to enable elogind support (sddm-enable-elogind.patch,1.71 KB, patch)
2016-11-11 17:05 UTC, Sven Eden
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Eden 2016-11-11 17:02:12 UTC
Add support for USE="elogind" to sddm. This USE flag should add pam_elogind.so as an optional session module to services/sddm-greeter.pam and substitute the usage of /sbin/shutdown with /usr/bin/loginctl.
Further, if elogind is used, sddm must not depend on consolekit and stop using ck-launch-session.
Comment 1 Sven Eden 2016-11-11 17:03:38 UTC
Created attachment 453036 [details]
sddm-0.14.0-r3.ebuild

This ebuild has USE="elogind" added and patches sddm to use elogind as a substitution for systemd-login.
Comment 2 Sven Eden 2016-11-11 17:05:06 UTC
Created attachment 453038 [details, diff]
Patch to enable elogind support

This patch does the following:

a) Add USE_ELOGIND and libelogind detection to CMakeLists.txt
b) Add pam_elogind.so to services/sddm-greeter.pam
Comment 3 Manuel Rüger (RETIRED) gentoo-dev 2016-11-11 17:16:15 UTC
Is there an upstream bug available? If not, please create one.
Comment 4 Sven Eden 2016-11-11 17:30:54 UTC
(In reply to Manuel Rüger from comment #3)
> Is there an upstream bug available? If not, please create one.

Not yet, as I am not entirely sure whether my patch is complete. Once I am certain (at least mostly) I'll propose this patch upstream.

And currently I drop back to sddm when I try to power off or reboot from within Plasma. I have to find out why.
Comment 5 Sven Eden 2016-11-11 18:36:24 UTC
Proposed my patch upstream at
  https://github.com/sddm/sddm/issues/741
for further review.
Comment 6 Sven Eden 2016-11-24 08:09:23 UTC
*meh* everything must be a pull request these days, even if it is such a small thing...

See: https://github.com/sddm/sddm/pull/746
Comment 7 Sven Eden 2016-12-29 10:44:20 UTC
@Michael : The pull request is in but is not yet merged. Generally sddm works fine with elogind support as it is now, so you might want to add it to the KDE Overlay for wider testing?

@Manuel : Would you be okay with that?
Comment 8 Andreas Sturmlechner gentoo-dev 2017-01-14 19:38:38 UTC
This seems to work fine for me so far.
Comment 9 Michael Palimaka (kensington) gentoo-dev 2017-03-25 02:51:23 UTC
Thanks, fixed in git. Sorry, somehow I accidentally blew away your attribution while rebasing.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d19f8d9400c010a9878a88e888fd5163042ff348
Comment 10 Sven Eden 2017-06-07 14:13:16 UTC
Update on the PR:

davidedmundson merged commit 59ad0f7 into sddm:develop

*yay*