Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 596680 - games-strategy/freeorion-0.4.6 version bump
Summary: games-strategy/freeorion-0.4.6 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Adam Feldman
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-09 12:19 UTC by Bernd Pachur
Modified: 2017-03-16 04:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
ebuild (freeorion-0.4.6.ebuild,2.38 KB, text/plain)
2016-10-16 07:53 UTC, Bernd Pachur 		Details
boost patch for 0.4.6 ebuild (freeorion-0.4.6-boost-1.61.patch,3.21 KB, patch)
2016-10-16 07:55 UTC, Bernd Pachur 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Pachur 2016-10-09 12:19:31 UTC 
0.4.6 (not -pre) is out.

Reproducible: Always
Comment 1 Bernd Pachur 2016-10-16 07:53:54 UTC 
Created attachment 450348 [details]
ebuild

modified copy of the 0.4.5-r1 ebuild
needs the updated boost patch!
Comment 2 Bernd Pachur 2016-10-16 07:55:05 UTC 
Created attachment 450350 [details, diff]
boost patch for 0.4.6 ebuild

patch for 0.4.6 ebuild to allow build with boost >= 1.6.1
Comment 3 Thomas Kahle (RETIRED) gentoo-dev 2016-10-21 20:45:51 UTC 
np-hardass took over maintainership.
Thanks!
Comment 4 anthorx 2017-03-15 07:15:45 UTC 
Why isn't the update already merged? I don't see any pull requests on GitHub.
Comment 5 Adam Feldman gentoo-dev 2017-03-16 04:29:22 UTC 
Resolved in bed9b713e4365156fa6193cfdaf2940b773c0980.

Thanks for the submission Bernd.  I ended up working this one myself because I needed to convert it away from the games eclass and thought it simpler to do that myself rather than imposing that on you, someone just kind enough to submit a patch.

Recommendation for submitting future patches: Usually, it's better to submit a diff rather than the full ebuild so I can see what you've specifically changed.  Additionally, when submitting a patch to fix a build issue, usually it is better to submit upstream and then backport their patch (and keeping the metadata so that the origins of the patch can be tracked)

Anyways, thanks again for the submission.  Looking forward to more from you in the future.