Latest release is from github: https://github.com/swh/ladspa/releases/tag/v0.4.16 Has been out since May. Among many other fixes, this fixes a problem I ran into where gcc5+ doesn't support recursive inline functions. https://github.com/swh/ladspa/commit/93e8a911c95d43016754484d91eec78ef6a80a61 Reproducible: Always
Now 0.4.17 (annotated as bugfixes-only) Did not built though, still trying to adapt current ebuild to new versions, for now checking relevance of gentoo-specitic patchset. Just to note, it is probably bad idea to use libtool to link internal stuff in subdirs (util), with recursive automake project layout.
Created attachment 567670 [details] swh-plugins 0.4.17 ebuild, EAPI=6 Got working ebuild for 0.4.17, based on current 0.4.15-r3. After build i made this test to ensure, that plugins can load: { for f in $( qlist -e swh-plugins | grep --color=never -E "ladspa.*\.so" | sort | less ); do analyseplugin $f; done } | less In version 0.4.15-r3 two plugins crashed: Failed to load plugin "/usr/lib64/ladspa/imp_1199.so": /usr/lib64/ladspa/imp_1199.so: undefined symbol: impulse2freq Failed to load plugin "/usr/lib64/ladspa/sifter_1210.so": /usr/lib64/ladspa/sifter_1210.so: undefined symbol: q_sort (casually noticed while running linuxsampler) Out-of-source build doesn't work in this vesion due to new source system, where sources are originally written in some ladspa-specific xml derivation. gsm is supposed to be linked statically to plugins. Unless system gsm is build with PIC, it requires either internal gsm or link with shared lib. Questionable pic-related patch is replaced by append-cflags -fPIC -DPIC. Can't understand, what is supposed to do glibc-2.10 related patch, since no issue/bug mentioned. Anyway, version 0.4.17 has no discomfort without <locale.h> include. "riceitdown" patch doesn't looks necessary, since CFLAGS line is passed only if no -march option is detected in env CFLAGS, otherwise it is ignored. The above mentioned append-cflags -fPIC solution is taken from this like. Shipped autogen.sh simply calls autoreconf, but it does it with additional option: -I m4 I'm not sure, how to reproduce it with eautoreconf, so left autogen.sh instead.
Created attachment 567674 [details, diff] Patch to use system shared gsm lib (replace with -l:libgsm.a for static lib)
Created attachment 567676 [details, diff] Ebuild diff for better review
/NLS mode on Спасибо, Никита. Вроде бы собирается и работает. /NLS mode off
Nice no to have Ardour bootstrap errors. Thks
Created attachment 600328 [details, diff] hardcoding version in patch name beuilds fine despite: >>> Preparing source in /var/tmp/portage/media-plugins/swh-plugins-0.4.17-r1/work/ladspa-0.4.17 ... * Applying swh-plugins-0.4.17-system-gsm.patch ... [ ok ] ac-wrapper: warning: invalid WANT_AUTOCONF 'latest'; ignoring. Copying file config.rpath --------------------------------------------------------------------------------- libtoolize: copying file 'm4/lt~obsolete.m4' autoheader-2.69: WARNING: Using auxiliary files such as `acconfig.h', `config.h.bot' autoheader-2.69: WARNING: and `config.h.top', to define templates for `config.h.in' autoheader-2.69: WARNING: is deprecated and discouraged. autoheader-2.69: autoheader-2.69: WARNING: Using the third argument of `AC_DEFINE' and autoheader-2.69: WARNING: `AC_DEFINE_UNQUOTED' allows one to define a template without autoheader-2.69: WARNING: `acconfig.h': autoheader-2.69: autoheader-2.69: WARNING: AC_DEFINE([NEED_FUNC_MAIN], 1, autoheader-2.69: [Define if a function `main' is needed.]) autoheader-2.69: autoheader-2.69: WARNING: More sophisticated templates can also be produced, see the autoheader-2.69: WARNING: documentation. configure.ac:3: installing './config.guess' ------------------------------------------------------------------------------- blo.c: In function 'blo_h_tables_new': blo.c:122:3: warning: ignoring return value of 'ftruncate', declared with attribute warn_unused_result [-Wunused-result] 122 | ftruncate(shm_fd, all_tables_size); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -------------------------------------------------------------------------------- which warnings I don't how to understand nor know how to manage them. Already there with original patch
Created attachment 600330 [details] ebuild for git master
forgotten warning, beside typos: checking for lrintf... yes -march=skylake -mtune=skylake -O2 -pipe -fPIC -DPIC -I@top_srcdir@/intl -I@top_srcdir@ configure: WARNING: CFLAGS appears to allready contain architecture specifaction, using exiting one checking for ld used by x86_64-pc-linux-gnu-gcc... (cached) /usr/x86_64-pc-linux-gnu/bin/ld checking if the linker (/usr/x86_64-pc-linux-gnu/bin/ld) is GNU ld... (cached) yes
Solved in git master blo.c: In function 'blo_h_tables_new': blo.c:122:3: warning: ignoring return value of 'ftruncate', declared with attribute warn_unused_result [-Wunused-result] 122 | ftruncate(shm_fd, all_tables_size); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Thks 4 ur attention
Created attachment 656974 [details] swh-plugins-0.4.17.ebuild Another new version. Bump please.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c650a7c49c4ec469010635072c026130fa05ce1c commit c650a7c49c4ec469010635072c026130fa05ce1c Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2020-08-27 08:05:55 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2020-08-27 08:05:55 +0000 media-plugins/swh-plugins: bump to 0.4.17 based on contributions to bug #595812 Closes: https://bugs.gentoo.org/595812 Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> media-plugins/swh-plugins/Manifest | 1 + .../files/swh-plugins-0.4.17-system-gsm.patch | 46 +++++++++++++++ .../swh-plugins/swh-plugins-0.4.17.ebuild | 67 ++++++++++++++++++++++ 3 files changed, 114 insertions(+)
