Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 595442 - dev-libs/gecode-4.4.0 - various QA violations
Summary: dev-libs/gecode-4.4.0 - various QA violations
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-28 19:15 UTC by Michael Palimaka (kensington)
Modified: 2016-09-29 12:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Palimaka (kensington) gentoo-dev 2016-09-28 19:15:59 UTC
>                || (
>                        ( dev-qt/qtcore:4 dev-qt/qtgui:4 )
>                        ( dev-qt/qtcore:5 dev-qt/qtgui:5 )
>                )

This won't work - Qt slots aren't interchangeable.
Comment 1 Michael Orlitzky gentoo-dev 2016-09-28 23:53:55 UTC
You're referring to the fact that an || dependency can be swapped out, right? And that gecode will break if you upgrade from qt4 to qt5?

If so, I think all we need to do is add subslot deps:

  gist? (
    || (
         ( dev-qt/qtcore:4 dev-qt/qtgui:4 )
         ( dev-qt/qtcore:5 dev-qt/qtgui:5 )
       )
       <dev-qt/qtcore-6:=
       <dev-qt/qtgui-6:=
  )
Comment 2 Michael Palimaka (kensington) gentoo-dev 2016-09-29 08:00:21 UTC
This will trigger a useless rebuild on every major Qt version bump.

From qtcore's metadata.xml, subslots: Must only be used by packages that are known to use private parts of the Qt API.

We should follow the rest of the tree by either forcing one version of Qt, or introducing USE flags. See https://wiki.gentoo.org/wiki/Project:Qt/Policies#Handling_different_versions_of_Qt for more details.
Comment 3 Michael Palimaka (kensington) gentoo-dev 2016-09-29 08:41:47 UTC
In addition to automagically selecting a Qt version to build against (with subsequent runtime breakage), this package also:

* Has a similar automagic selection and breakage with gmp/mpir
* Fails to respect CFLAGS correctly
* Installs source files to the root directory
* Installs html documentation to the wrong directory (html/html)
Comment 4 Michael Palimaka (kensington) gentoo-dev 2016-09-29 09:22:17 UTC
It also bundles and installs its own copy of boost.
Comment 5 Michael Palimaka (kensington) gentoo-dev 2016-09-29 10:18:12 UTC
I've fixed most of these. I'm not sure if there's anything we can do about boost, and other distros ship it that way too.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=16f2c13fa964bad248df33231fb2fff2a6b6e5ad
Comment 6 Michael Orlitzky gentoo-dev 2016-09-29 12:11:18 UTC
Thanks. The only thing preventing the removal of the 3.x version is dev-ruby/dep_selector. It looks like there was a commit on August 3rd upstream to support gecode 4.x, and a new release on rubygems.org on August 5th. With any luck, that new release will support gecode-4.x and we can drop the old one.