Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 592220 - dev-util/radare2: use system dev-libs/capstone instead of binded copy
Summary: dev-util/radare2: use system dev-libs/capstone instead of binded copy
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sergei Trofimovich (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-27 02:58 UTC by Anton Bolshakov
Modified: 2017-07-29 20:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Bolshakov 2016-08-27 02:58:37 UTC
radare2 comes with capstone and few other deps by default.

There is a configure script to system library:
 $(use_with capstone syscapstone)

Please unbind that library
Comment 1 Anton Bolshakov 2016-08-27 03:07:26 UTC
we have a working ebuild which uses system capstone, radare2-bindings. Have a look here:
https://github.com/pentoo/pentoo-overlay/tree/master/dev-util/radare2
https://github.com/pentoo/pentoo-overlay/tree/master/dev-libs/radare2-bindings
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2016-08-27 10:39:28 UTC
While I agree the knob needs to be exposed
i'm not sure it's safe to use current 3.0.4 gentoo's capstone as is.

radare2 applies 3 (small) patches on capstone:
    https://github.com/radare/radare2/tree/master/shlr/capstone-patches
and usually pin to relatively recent git capstone release:
    https://github.com/radare/radare2/blob/master/shlr/Makefile#L22
AFAIU those commits are not capstone releases.
Comment 3 Anton Bolshakov 2016-08-27 10:58:18 UTC
I'll try to add Quynh to comment. He is very responsive and willing to fix such bugs usually.

The main reason why you added capstone under "dev-libs" so that it could be shared.

I'm working on adding at least one more tool called "frida" (https://github.com/aquynh/capstone/issues/757) with similar problem.

It would be good to have one library installed at the end.
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2017-07-29 20:53:07 UTC
Took me too long. My apologies.

Pushed as: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8b23a01ee9c711bd6faec409c95c0b46f76abef2

Thanks for the report!