Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 590704 - net-misc/remmina-1.2.0_rc14: uses libsecret instead of global gnome-keyring USE
Summary: net-misc/remmina-1.2.0_rc14: uses libsecret instead of global gnome-keyring USE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Diogo Pereira
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 590838
  Show dependency tree
 
Reported: 2016-08-07 16:03 UTC by Pacho Ramos
Modified: 2016-08-10 12:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2016-08-07 16:03:16 UTC 
For reference go to:
https://wiki.gentoo.org/wiki/Project:GNOME/Gnome_Team_Ebuild_Policies#gnome-keyring_and_libsecret

Also, this is allowing:
webkit? ( || ( net-libs/webkit-gtk:4 net-libs/webkit-gtk:3 ) )

Probably it would be better to hard rdepend on :4 as that is the only maintained slot and older ones are also vulnerable (but still present because we are still needing to clean reverse deps)

Thanks
Comment 1 Patrice Clement gentoo-dev 2016-08-07 20:44:31 UTC 
commit 96460591da1e3fa17ed1622815c8734c711d9f2f (HEAD -> master)
Author:     Diogo Pereira <sir.suriv@gmail.com>
AuthorDate: Sun Aug 7 17:45:05 2016 +0100
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Sun Aug 7 22:44:16 2016 +0200

net-misc/remmina: libsecret and webkit-gtk fixes.

* Patch build to properly allow disabling libsecret.
* Switch from libsecret to gnome-keyring USE flag.
* Hard depend on net-libs/webkit-gtk:4.

Gentoo-Bug: https://bugs.gentoo.org/590704
Reported-by: Pacho Ramos <pacho@gentoo.org>
Closes: https://github.com/gentoo/gentoo/pull/2037

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

...mina-1.2.0_rc14-allow-disabling-libsecret.patch | 22 +++++
net-misc/remmina/remmina-1.2.0_rc14-r1.ebuild      | 94 ++++++++++++++++++++++
2 files changed, 116 insertions(+)
create mode 100644 net-misc/remmina/files/remmina-1.2.0_rc14-allow-disabling-libsecret.patch
create mode 100644 net-misc/remmina/remmina-1.2.0_rc14-r1.ebuild

Commited, thanks!