Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 589560 - dev-qt/qtgui:5 - add linuxfb support
Summary: dev-qt/qtgui:5 - add linuxfb support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2016-07-24 01:30 UTC by Wes
Modified: 2021-08-25 14:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wes 2016-07-24 01:30:43 UTC
Currently dev-qt/qtgui doesn't account for Qt's LinuxFB support, which probably matters more to embedded platforms than desktop.  Enabling it is trivial however and I feel it's time we did

Reproducible: Always




This is a diff between the in-tree qtgui-5.5.1 and my local linuxfb enabled one.  I think this should be the same for enabling it in later versions of qtgui as well:


--- /usr/portage/dev-qt/qtgui/qtgui-5.5.1-r1.ebuild     2016-06-02 06:49:28.000000000 +1000
+++ /usr/local/portage/dev-qt/qtgui/qtgui-5.5.1-r2.ebuild       2016-07-24 11:29:10.497160016 +1000
@@ -15,7 +15,7 @@
 # TODO: directfb, linuxfb, kms integration in eglfs

 IUSE="accessibility dbus egl eglfs evdev +gif gles2 gtkstyle
-       ibus jpeg libinput +png tslib tuio +udev +xcb"
+       ibus jpeg libinput +png tslib tuio +udev +xcb linuxfb"
 REQUIRED_USE="
        || ( eglfs xcb )
        accessibility? ( dbus xcb )
@@ -110,6 +110,7 @@
        !jpeg:no-jpeg:
        libinput
        libinput:xkbcommon-evdev:
+       linuxfb
        :opengl
        png:png:
        png:system-png:IMAGEFORMAT_PNG
@@ -162,6 +163,7 @@
                -opengl $(usex gles2 es2 desktop)
                $(qt_use png libpng system)
                $(qt_use tslib)
+               $(qt_use linuxfb)
                $(qt_use udev libudev)
                $(qt_use xcb xcb system)
                $(qt_use xcb xkbcommon-x11 system)
Comment 1 Davide Pesavento gentoo-dev 2016-07-28 16:10:59 UTC
I'm not going to apply this to 5.5.x or 5.6.x. Instead, can you submit a pull request to the qt overlay against 5.7.0 and later versions please?
Comment 2 Wes 2016-07-28 23:47:16 UTC
Sure, I'll test it with 5.7.0 and PR this weekend, thanks
Comment 3 Wes 2016-08-16 04:00:52 UTC
sorry I haven't had a chance to do this yet, haven't forgotten though.  Testing locally now and will try to get a PR in tonight if work commitments permit
Comment 4 Larry the Git Cow gentoo-dev 2021-08-23 01:15:13 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=8898e86615e7d5d31575c056058a5780a4fd0cba

commit 8898e86615e7d5d31575c056058a5780a4fd0cba
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-08-23 00:35:29 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-08-23 01:14:58 +0000

    dev-qt/qtgui: Add IUSE=linuxfb
    
    Bug: https://bugs.gentoo.org/589560
    Package-Manager: Portage-3.0.22, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtgui/metadata.xml           | 1 +
 dev-qt/qtgui/qtgui-5.15.9999.ebuild | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2021-08-25 14:36:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7e4f10c848a02c04e09c081961f64fad5b0caee1

commit 7e4f10c848a02c04e09c081961f64fad5b0caee1
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-08-23 00:35:29 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-08-25 14:35:48 +0000

    dev-qt/qtgui: Add IUSE=linuxfb
    
    Closes: https://bugs.gentoo.org/589560
    Package-Manager: Portage-3.0.22, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtgui/metadata.xml            | 1 +
 dev-qt/qtgui/qtgui-5.15.2-r10.ebuild | 5 ++---
 2 files changed, 3 insertions(+), 3 deletions(-)