Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 58885 - dev-util/calltree-0.9.7 won't work with /dev-util/valgrind-2.1.2
Summary: dev-util/calltree-0.9.7 won't work with /dev-util/valgrind-2.1.2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High blocker (vote)
Assignee: Caleb Tennis (RETIRED)
URL:
Whiteboard:
Keywords:
: 59149 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-07-30 05:02 UTC by Priit Laes (IRC: plaes)
Modified: 2004-08-14 17:27 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
calltree-0.9.7_configure.patch (calltree-0.9.7_configure.patch,379 bytes, patch)
2004-08-04 19:52 UTC, f5d8fd51ed1e804c9e8d0357e8614e0493b06e96
Details | Diff
calltree-0.9.7-r1.ebuild (calltree-0.9.7-r1.ebuild,945 bytes, text/plain)
2004-08-04 19:53 UTC, f5d8fd51ed1e804c9e8d0357e8614e0493b06e96
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Priit Laes (IRC: plaes) 2004-07-30 05:02:26 UTC
Calculating dependencies ...done!
>>> emerge (1 of 1) dev-util/calltree-0.9.7 to /
>>> md5 src_uri ;-) calltree-0.9.7.tar.gz
>>> Unpacking source...
>>> Unpacking calltree-0.9.7.tar.gz to /var/tmp/portage/calltree-0.9.7/work
>>> Source unpacked.
configure: WARNING: If you wanted to set the --build type, don't use --host.
    If a cross compiler is detected then cross compile mode will be used.
checking for a BSD-compatible install... /bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for i686-pc-linux-gnu-strip... no
checking for strip... strip
checking for i686-pc-linux-gnu-gcc... gcc
checking for C compiler default output... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables...
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ANSI C... none needed
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking for i686-pc-linux-gnu-g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking for a BSD-compatible install... /bin/install -c
checking for valgrind installation... in /usr
checking if vg_skin.h is available... Yes
checking if skin version is supported... configure: error: The installed Valgrind is too new for this package. Please update this package!

!!! ERROR: dev-util/calltree-0.9.7 failed.
!!! Function econf, Line 362, Exitcode 1
!!! econf failed


Reproducible: Always
Steps to Reproduce:





decoder ~ # emerge info
Portage 2.0.50-r9 (default-x86-2004.2, gcc-3.3.4, glibc-2.3.4.20040619-r0,
2.6.7-gentoo-r11)
=================================================================
System uname: 2.6.7-gentoo-r11 i686 Pentium III (Coppermine)
Gentoo Base System version 1.5.1
Autoconf: sys-devel/autoconf-2.59-r4
Automake: sys-devel/automake-1.8.5-r1
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-O2 -mcpu=pentium3 -march=pentium3"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3/share/config /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -mcpu=pentium3 -march=pentium3"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="ftp://ftp.linux.ee/pub/gentoo/distfiles"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X X509 alsa apm avi berkdb bidi cdparanoia cjk crypt cscope cups dga
divx4linux dvd dvdread encode erandom f77 faad flac foomaticdb gcj gdbm gif
gnome gnutls gstreamer gtk gtk2 imlib innodb ipv6 java jpeg kde libg++ libwww
live lzo mad mikmod mmap mmx motif mpeg mysql ncurses network nls objc oggvorbis
opengl oss pam pcmcia pcre pdflib perl pic png pnp pwdb python qt quicktime
readline rtc ruby samba sdk sdl slang smartcard spell sse ssl svga tcpd tetex
tga theora tiff truetype trusted unicode usb v4l v4l2 vim-with-x x86 xinerama
xml xml2 xv xvid zlib"
Comment 1 Priit Laes (IRC: plaes) 2004-08-02 03:55:13 UTC
This package seems to be renamed to callgrind, but this package is only available in CVS. No release so far...

Seems like Valgrind's internal skin code has also changed a bit. CVS version already supports it...
Comment 2 Tom Knight (RETIRED) gentoo-dev 2004-08-02 07:51:54 UTC
*** Bug 59149 has been marked as a duplicate of this bug. ***
Comment 3 f5d8fd51ed1e804c9e8d0357e8614e0493b06e96 2004-08-04 19:21:50 UTC
check: http://kcachegrind.sourceforge.net/cgi-bin/show.cgi/KcacheGrindVg212

Patch for Calltree 0.9.7 to run with Valgrind 2.1.2
Apply the follow patch (or modify manually the one number from 5 to 6 in configure.in): 

 --- configure.in.old    2004-08-04 11:54:55.211422776 +0200
 +++ configure.in        2004-08-04 11:55:52.811666208 +0200
 @@ -60,7 +60,7 @@
  CFLAGS="-I $VG_INCDIR"
  AC_TRY_RUN([
  #include "vg_skin.h"
 -int main() { return (VG_CORE_INTERFACE_MAJOR_VERSION > 5) ? 1:0; }
 +int main() { return (VG_CORE_INTERFACE_MAJOR_VERSION > 6) ? 1:0; }
  ], [
  AC_MSG_RESULT([Yes])
  ], [


Comment 4 f5d8fd51ed1e804c9e8d0357e8614e0493b06e96 2004-08-04 19:52:48 UTC
Created attachment 36792 [details, diff]
calltree-0.9.7_configure.patch
Comment 5 f5d8fd51ed1e804c9e8d0357e8614e0493b06e96 2004-08-04 19:53:56 UTC
Created attachment 36793 [details]
calltree-0.9.7-r1.ebuild

tested the ebuild, doing fine for me.
calltree compiles and works just fine
Comment 6 Andrew Wilkinson 2004-08-09 14:26:16 UTC
Personally I'd modifiy the configure directly rather than regenerating it...

--- calltree-0.9.7.ebuild        2004-06-25 03:39:16.000000000 +0100
+++ calltree-0.9.7-r1.ebuild       2004-08-09 22:03:47.672270650 +0100
@@ -2,6 +2,8 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/dev-util/calltree/calltree-0.9.7.ebuild,v 1.2 2004/06/25 02:21:53 agriffis Exp $

+inherit eutils
+
 DESCRIPTION="A plugin for cachegrind that adds call-graph profiling, needed by kcachegrind"
 HOMEPAGE="http://kcachegrind.sourceforge.net/"
 SRC_URI="http://kcachegrind.sourceforge.net/${P}.tar.gz"
@@ -13,6 +15,12 @@

 DEPEND=">=dev-util/valgrind-2.1.0"

+src_unpack() {
+        unpack ${P}.tar.gz
+
+       epatch ${FILESDIR}/calltree-0.9.7-configure.patch
+}
+
 src_install() {
        einstall                     || die
        rm -rf ${D}/usr/share/doc/valgrind

And then add this as files/calltree-0.9.7-configure.patch
--- calltree-0.9.7/configure  2004-08-09 22:08:53.510438433 +0100
+++ calltree-0.9.7/configure  2004-08-09 22:09:06.152269674 +0100
@@ -3279,7 +3279,7 @@
 /* end confdefs.h.  */

 #include "vg_skin.h"
-int main() { return (VG_CORE_INTERFACE_MAJOR_VERSION > 5) ? 1:0; }
+int main() { return (VG_CORE_INTERFACE_MAJOR_VERSION > 6) ? 1:0; }

 _ACEOF
 rm -f conftest$ac_exeext

A fairly academic difference though ;-)
Comment 7 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2004-08-14 15:31:02 UTC
i just put my own fix in cvs, and only found this afterwards.
either way, it's done now.
Comment 8 f5d8fd51ed1e804c9e8d0357e8614e0493b06e96 2004-08-14 17:11:06 UTC
DEPEND=">=dev-util/valgrind-2.1.0 <dev-util/valgrind-2.1.2"

sorry, but this is no fix.. this is just.. well.. I'll keep this for myself
valgrind 2.1.2 is a "bugfix-release". what use is it rejecting to work with this version if just a tiny fix in the configure script is needed so calltree will accept it... ?
Comment 9 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2004-08-14 17:27:55 UTC
I put that in place and set up 0.9.7-r1 with the fix for users with valgrind-2.1.2.