Created attachment 440610 [details] compile log There are several errors like: bomber.c:2432:3: error: non-void function 'domode4' should return a value [-Wreturn-type] return; adding -Wno-return-type when compiling with clang avoids the issue, I'll attach a patch for review.
Created attachment 440612 [details, diff] ebuild diff
Created attachment 440614 [details, diff] proper repo patch @Games, please review. If there's no comment/problem, I'll commit in two weeks.
This seems more like a workaround than a fix. The code would be wrong no matter which compiler you're using, so it'd be better to patch it unconditionally. Proper fix would be to either put an appropriate return value in, or change the function return type to void.
(In reply to Tristan Heaven from comment #3) > This seems more like a workaround than a fix. The code would be wrong no > matter which compiler you're using, so it'd be better to patch it > unconditionally. > > Proper fix would be to either put an appropriate return value in, or change > the function return type to void. Yes. I started to patch it, but it's not completely clear (to me) what was intended in some places. Given that upstream is dead, there's no real way to fix this properly, or to have the original author verify the changes are correct.
Created attachment 440644 [details, diff] add a patch making those functions void The void approach rather than adding return codes was easier, thanks for suggestion.
Much better
(In reply to Tristan Heaven from comment #6) > Much better Is that OK to commit?
https://github.com/gentoo/gentoo/commit/0a7a9bac3756345505ea52819f483714f259cf01
