Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588106 - net-fs/autofs-5.1.2[libtirpc] fails to detect libtirpc with -Wl,--as-needed
Summary: net-fs/autofs-5.1.2[libtirpc] fails to detect libtirpc with -Wl,--as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Yixun Lan
URL: http://thread.gmane.org/gmane.linux.k...
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2016-07-05 21:26 UTC by Martin von Gagern
Modified: 2016-07-06 20:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Change LDFLAGS to LIBS (gentoo587458a.patch,808 bytes, patch)
2016-07-05 21:26 UTC, Martin von Gagern
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2016-07-05 21:26:43 UTC
Created attachment 439802 [details, diff]
Change LDFLAGS to LIBS

This is a spin-off from bug #587458 comment #2.

Even after adding the libtirpc USE flag for the net-fs/autofs-5.1.2 package, the build failed. Configure reported

checking if libtirpc is requested and available... no

and the non-libtirpc build encountered the issues described in bug #587458. The configure problem is due to the fact that the configure script passes -ltirpc in LDFLAGS, not in LIBS, causing an incorrect order of arguments in the linker invocation.

https://wiki.gentoo.org/wiki/Project:Quality_Assurance/As-needed instructs changing that, which is what the attached patch does. With this I could merge the package successfully. The patch relies on the ebuild doing an autoreconf step, which the current ebuild does.
Comment 1 Yixun Lan archtester gentoo-dev 2016-07-05 23:11:00 UTC
the patch looks good, thanks

would you like to push this patch to autofs upstream? so other user may benefit, also less burden we (Gentoo) will carry ..
Comment 2 Yixun Lan archtester gentoo-dev 2016-07-05 23:23:40 UTC
I've pushed this patch to portage tree (without revision bump), many thanks

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1069c56a8946a005eadfaebc3c75ab6eceee1bed
Comment 3 Martin von Gagern 2016-07-06 20:48:27 UTC
(In reply to Yixun Lan from comment #1)
> would you like to push this patch to autofs upstream? so other user may
> benefit, also less burden we (Gentoo) will carry ..

I HATE sending patches via Majordomo lists. Subscribing to the list. Confirming your address. Realizing I was already subscribed since bug #453778. Checking what folder these mails get directed to. Reading the manual for git-send-email since I hardly ever use that. Checking git sendemail configuration. Sending.
I wish they'd be using GitHub…

Anyway, I finally managed to post that patch:
http://thread.gmane.org/gmane.linux.kernel.autofs/7437