Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 585658 - sys-apps/kexec-tools: systemd unit does not allow more than one commandline argument
Summary: sys-apps/kexec-tools: systemd unit does not allow more than one commandline a...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-12 07:53 UTC by Tiziano Müller
Modified: 2016-06-12 17:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tiziano Müller gentoo-dev 2016-06-12 07:53:16 UTC
With curly braces, environment variables will be be passed as one string (one argument) to the command, making it impossible to pass more than one optional argument to kexec, see also http://0pointer.de/public/systemd-man/systemd.service.html#Command%20lines

diff --git a/sys-apps/kexec-tools/files/kexec.service b/sys-apps/kexec-tools/files/kexec.service
index 289aae0..c387310 100644
--- a/sys-apps/kexec-tools/files/kexec.service
+++ b/sys-apps/kexec-tools/files/kexec.service
@@ -9,8 +9,8 @@ ConditionPathExists=!/nokexec
 Type=oneshot
 RemainAfterExit=yes
 EnvironmentFile=/etc/kexec.conf
-ExecStart=/usr/sbin/kexec -l /boot/${KNAME} ${KEXEC_OPT_ARGS}
-ExecStop=/usr/sbin/kexec -l /boot/${KNAME} ${KEXEC_OPT_ARGS}
+ExecStart=/usr/sbin/kexec -l /boot/${KNAME} $KEXEC_OPT_ARGS
+ExecStop=/usr/sbin/kexec -l /boot/${KNAME} $KEXEC_OPT_ARGS
 
 [Install]
 WantedBy=multi-user.target
Comment 1 SpanKY gentoo-dev 2016-06-12 17:58:46 UTC
if you use systemd, feel free to commit changes to service files