Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 585474 - dev-lang/php: use app-text/tidy-html5 in place of app-text/htmltidy
Summary: dev-lang/php: use app-text/tidy-html5 in place of app-text/htmltidy
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PHP Bugs
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 564884
  Show dependency tree
 
Reported: 2016-06-09 15:02 UTC by Michael Orlitzky
Modified: 2018-11-18 15:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
php-tidy-html5.patch (php-tidy-html5.patch,983 bytes, patch)
2016-06-09 15:02 UTC, Michael Orlitzky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2016-06-09 15:02:24 UTC
Created attachment 437006 [details, diff]
php-tidy-html5.patch

The app-text/htmltidy is going to be gradually removed in favor of app-text/tidy-html5 (see bug #564884). There are a few things we're waiting on:

  1) We need a stable version of app-text/tidy-html5.

  2) There are some keywords (that we support) that were dropped in
     tidy-html5 relative to htmltidy.

Once those issues are resolved, it seems pretty simple to port dev-lang/php to the new library. A sample patch against php:7.0 is provided.
Comment 1 Michael Orlitzky gentoo-dev 2016-06-10 14:58:49 UTC
I created a pull request at,

  https://github.com/php/php-src/pull/1940

that fixes the issue upstream (by supporting both).
Comment 2 Michael Orlitzky gentoo-dev 2016-07-23 11:45:50 UTC
This made it into 7.1.x, but probably won't be backported:

https://github.com/php/php-src/blob/php-7.1.0beta1/NEWS

The only problem with the quick hack I posted originally is that the test suite will fail.
Comment 3 Michael Orlitzky gentoo-dev 2016-12-03 03:22:21 UTC
This is done in the new v7.1.0. Since upstream probably won't backport it, I'm not going to bother unless there's a critical vulnerability.