Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 585428 - [FUTURE EAPI] inclusion of HACKING in einstalldocs default DOCS array
Summary: [FUTURE EAPI] inclusion of HACKING in einstalldocs default DOCS array
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: PMS/EAPI (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PMS/EAPI
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: future-eapi
  Show dependency tree
 
Reported: 2016-06-09 04:52 UTC by Adam Feldman
Modified: 2019-08-25 19:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Feldman gentoo-dev 2016-06-09 04:52:11 UTC
HACKING is a fairly common file in open source projects, so I think this would make a good addition to the list of DOCS.

Originally proposed https://archives.gentoo.org/gentoo-dev/message/b6cc9201159d8d7c2b3398fbb7f1229c

Recommendation to file this bug https://archives.gentoo.org/gentoo-dev/message/19a645bf642e862a80ef39e3c5781837

Requesting that this be included in EAPI 7.
Comment 1 Ulrich Müller gentoo-dev 2016-06-09 06:18:40 UTC
Inclusion of HACKING had already been considered for EAPI 4, back in 2009:
https://archives.gentoo.org/gentoo-dev/message/f4ddcba50e95187833f8a756af1f6107
At the time, a long and a short version of the default list were suggested:

README* ChangeLog AUTHORS NEWS TODO CHANGES THANKS BUGS FAQ CREDITS CHANGELOG

README Change{,s,Log} AUTHORS NEWS TODO ABOUT THANKS {KNOWN_,}BUGS SUBMITTING HACKING FAQ CREDITS PKG-INFO HISTORY PACKAGING MAINTAINER{,S} CONTRIBUT{E,OR,ORS} RELEASE ANNOUNCE PORTING NOTES PROBLEMS NOTICE

The shorter version then was accepted, and I don't see a good reason why we should (even partially) revise that decision. Especially, if it concerns less than 1% of the tree (the quoted message says 370 ebuilds).

After all, the above list is only a default, and it is easy to override it by assigning DOCS, or by calling "einstalldocs" (or "default") followed by "dodoc HACKING" in src_install().
Comment 2 Adam Feldman gentoo-dev 2016-06-09 17:00:21 UTC
(In reply to Ulrich Müller from comment #1)
> Inclusion of HACKING had already been considered for EAPI 4, back in 2009:
> https://archives.gentoo.org/gentoo-dev/message/
> f4ddcba50e95187833f8a756af1f6107
> At the time, a long and a short version of the default list were suggested:
> 
> README* ChangeLog AUTHORS NEWS TODO CHANGES THANKS BUGS FAQ CREDITS CHANGELOG
> 
> README Change{,s,Log} AUTHORS NEWS TODO ABOUT THANKS {KNOWN_,}BUGS
> SUBMITTING HACKING FAQ CREDITS PKG-INFO HISTORY PACKAGING MAINTAINER{,S}
> CONTRIBUT{E,OR,ORS} RELEASE ANNOUNCE PORTING NOTES PROBLEMS NOTICE
> 
> The shorter version then was accepted, and I don't see a good reason why we
> should (even partially) revise that decision. Especially, if it concerns
> less than 1% of the tree (the quoted message says 370 ebuilds).
Bear in mind, that that number is only those that have explicitly chosen to install it.  Who knows how many theoretically have that file.
> 
> After all, the above list is only a default, and it is easy to override it
> by assigning DOCS, or by calling "einstalldocs" (or "default") followed by
> "dodoc HACKING" in src_install().
Good tips, thanks.


No problem.  Just seemed odd to me (not knowing the history of the default DOCS) that a relatively common file in the FOSS world was being omitted.  Feel free to close this if no one else has anything else to add one way or the other.
Comment 3 Ulrich Müller gentoo-dev 2016-06-09 19:39:16 UTC
I assume the two original lists were based on a statistic of documentation files installed by existing ebuilds, with different cut-off levels. Unfortunately, the 2009 posting doesn't provide any numbers (it only says "I got the default list by some horrid shell voodoo").

We can of course reiterate the list, but that should be based on traceable criteria for inclusion of entries (like, X% of ebuilds install a such a file).

Closing for now.