Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 584436 - media-libs/libepoxy depends on X11
Summary: media-libs/libepoxy depends on X11
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Matt Turner
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 611056
  Show dependency tree
 
Reported: 2016-05-29 07:57 UTC by Cedric Sodhi
Modified: 2017-03-05 11:27 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libepoxy-1.4.0.ebuild (libepoxy-1.4.0.ebuild,1.06 KB, text/plain)
2017-02-11 08:52 UTC, dolphinling
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cedric Sodhi 2016-05-29 07:57:27 UTC
Technically, libepoxy can run without libX11 and should, like here, where I only run pure wayland. In fact, the code allows for it (it is no RDEPEND). I was told that it was only a decision made upstream to require libX11 at configure time so that if the user wants to run epoxy ontop of X11, it will not fail. Which I find kind of backwards reasoning. If the configure script detects that the user is not on linux in the first place, it will allow them to not have X11. I suppose Gentoo could patch this in the configure script so that X is not required when it's actually superflous.
Comment 1 Chí-Thanh Christopher Nguyễn gentoo-dev 2016-05-29 10:34:54 UTC
Generally, x11 project tries to avoid maintaining patches which were not accepted upstream. The best way forward would be to create a patch that makes the dependency configurable and convincing upstream to apply it.
Comment 2 Cedric Sodhi 2016-05-29 11:53:39 UTC
Such a patch would be trivial. However, I was already told that upstream rejected the idea. I'm not to judge upstream's decisisions but I'd definitely appreciate it and so will probably other people without X. After all, the risk of "shooting oneself in the foot" (which is supposedly the reason for this imposed dependency) i assumed to be removed by portage USE flags.
Comment 3 Chí-Thanh Christopher Nguyễn gentoo-dev 2016-05-29 16:28:53 UTC
You can use package.provided if you don't want the library that libepoxy is depending on.

Also I guess upstream would accept a patch that allows disabling the configure check but still has it enabled by default.
Comment 4 Matt Turner gentoo-dev 2016-05-29 18:57:03 UTC
(In reply to Cedric Sodhi from comment #2)
> Such a patch would be trivial. However, I was already told that upstream
> rejected the idea.

Citation needed :)
Comment 5 dolphinling 2017-02-11 08:52:06 UTC
Created attachment 463184 [details]
libepoxy-1.4.0.ebuild

Upstream's position on this changed and they now have a configure check that we can use for this.

I've attached the ebuild I'm using for this. Note that this ebuild also switches to eapi 6, so there's some changes related to that also.
Comment 6 Matt Turner gentoo-dev 2017-03-04 07:51:02 UTC
Thanks dolphinling. Fixed by:

commit 8824c4ff99ce377f488b2a95be19809b17f6a5fd
Author: Matt Turner <mattst88@gentoo.org>
Date:   Fri Mar 3 23:37:13 2017 -0800

    media-libs/libepoxy: Add USE=X and port to EAPI=6.

(available in 1.4.1)
Comment 7 Mart Raudsepp gentoo-dev 2017-03-05 11:05:17 UTC
Would have been nice to actually go through the consumers and file bugs for stuff that now need a libepoxy[X(+)] depend.
Comment 8 Mart Raudsepp gentoo-dev 2017-03-05 11:27:41 UTC
And it's already asked to be stabled too, so stable consumers will be breaking. I can't deal with it soon enough, I'll just take care of the independently reported gtk+ bug, I guess in the stable versions too then...