Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 584334 - dev-libs/libxslt: please review Prefix Cygwin patch
Summary: dev-libs/libxslt: please review Prefix Cygwin patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords:
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2016-05-27 14:11 UTC by Michael Haubenwallner (RETIRED)
Modified: 2017-09-05 07:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch to apply: use -no-undefined for libtool libs (0001-dev-libs-libxslt-use-no-undefined.patch,4.20 KB, patch)
2016-05-27 14:11 UTC, Michael Haubenwallner (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Haubenwallner (RETIRED) gentoo-dev 2016-05-27 14:11:46 UTC
Created attachment 435556 [details, diff]
ebuild patch to apply: use -no-undefined for libtool libs

Submitted upstream patch (required for Cygwin, should be used everywhere IMO):
https://bugzilla.gnome.org/show_bug.cgi?id=766669

Although this patch shouldn't change anything for non-Cygwin, I'd suggest revbumping the ebuild.

Thanks!
Comment 1 Michael Haubenwallner (RETIRED) gentoo-dev 2016-11-16 15:31:01 UTC
Upstream accepted the conservative variant here.
Unfortunately, feels like one shouldn't expect their next release within next 3 years or so, and we might end up keeping the patch untill then - for the moment in
https://gitweb.gentoo.org/repo/proj/prefix.git/commit/?id=a256f56f57ea644d10fb1fdd0e0ad0162113a7d5

Ohw - the conservative variant doesn't require the revbump actually.
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2017-09-05 06:54:25 UTC
Upstream went with WIN32_EXTRA_LDFLAGS, is that ok for you ? It was included in Gentoo in 1.1.29 at least and is now released upstream in 1.1.30.
Comment 3 Michael Haubenwallner (RETIRED) gentoo-dev 2017-09-05 07:35:23 UTC
Yes, both 1.1.29-r1 and 1.1.30 look good, thanks!