Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 584186 - www-client/luakit relies on obsolete webkit-gtk slot
Summary: www-client/luakit relies on obsolete webkit-gtk slot
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard: Masked for removal on 2016-06-26
Keywords: PMASKED
Depends on:
Blocks: CVE-2016-1723, CVE-2016-1724, CVE-2016-1725, CVE-2016-1726, CVE-2016-1727, CVE-2016-1728
  Show dependency tree
 
Reported: 2016-05-26 10:58 UTC by Pacho Ramos
Modified: 2016-12-13 11:35 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (build.log.gz,3.00 KB, application/x-gzip)
2016-07-11 09:37 UTC, herminio.hernandezjr
Details
ebuild (luakit-9999.ebuild,1.78 KB, text/plain)
2016-07-12 04:40 UTC, herminio.hernandezjr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2016-05-26 10:58:18 UTC
It relies on obsolete and vulnerable :2 slot and upstream looks dead since 2012. Hence, I would simply treeclean this
Comment 1 Franz Trischberger 2016-05-28 16:10:02 UTC
As pointed out on the mailing list there is still action.
The this issue for reference:
https://github.com/mason-larobina/luakit/issues/299
luakit-crowd has done commits until 2015, aidanholm did some work to port it to webkit-gtk:4 and gtk3. So luakit is not entirely dead.
Comment 2 Michael Palimaka (kensington) gentoo-dev 2016-05-28 16:39:13 UTC
Is anyone interested in taking care of it?
Comment 3 herminio.hernandezjr 2016-06-24 05:09:51 UTC
There is actually working going on with this project. I have been in contact with the developer. I would be willing to be proxy maintainer of the package. I use this browser on my PowerBook G4 (dual booting gentoo and debain) and PowerMac G5 (gentoo ppc64).

Thanks
Herminio
Comment 4 herminio.hernandezjr 2016-07-04 05:42:12 UTC
There is activity on github. I have seen commits to move luakit to gtk-3 and webkitgtk-3.0. You can check it out here https://github.com/luakit/luakit. Like I said I am willing to be a proxy maintainer.

Ragards,
Herminio
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-07-04 05:51:09 UTC
Is there a release with new WebKit already? If not, is it suitable for a snapshot? Write an ebuild, submit it here or a pull request, and you'll get the job :-).
Comment 6 herminio.hernandezjr 2016-07-08 22:43:58 UTC
I am tracking the changes on github. Once the changes get pushed I will begin writing the ebuild.
Comment 7 Franz Trischberger 2016-07-09 07:26:39 UTC
https://github.com/aidanholm/luakit already has wiped out gtk2 and completely moved to wekbit2gtk-4.0.pc. No idea if he plans to join luakit project and push his changes there. At least it is working really well (as long as you are not running into webkit-gtk issues...)

If you are interested this is the diff I use:

--- /var/repositories/gentoo/www-client/luakit/luakit-9999.ebuild       2015-09-05 08:27:08.118860501 +0200
+++ /var/repositories/local/www-client/luakit/luakit-9999.ebuild        2016-07-09 09:25:05.611527620 +0200
@@ -9,20 +9,20 @@
 
 if [[ ${PV} == *9999* ]]; then
        inherit git-2
-       EGIT_REPO_URI="git://github.com/mason-larobina/${PN}.git
-               https://github.com/mason-larobina/${PN}.git"
-       EGIT_BRANCH="develop"
+       EGIT_REPO_URI="git://github.com/aidanholm/${PN}.git
+               https://github.com/aidanholm/${PN}.git"
+       EGIT_BRANCH="webkit2"
        KEYWORDS=""
        SRC_URI=""
 else
        inherit vcs-snapshot
        MY_PV="${PV/_p/-r}"
        KEYWORDS="~amd64 ~x86"
-       SRC_URI="https://github.com/mason-larobina/${PN}/tarball/${MY_PV} -> ${P}.tar.gz"
+       SRC_URI="https://github.com/luakit/${PN}/tarball/${MY_PV} -> ${P}.tar.gz"
 fi
 
 DESCRIPTION="fast, small, webkit-gtk based micro-browser extensible by lua"
-HOMEPAGE="https://mason-larobina.github.com/luakit/"
+HOMEPAGE="https://luakit.github.com/luakit/"
 
 LICENSE="GPL-3"
 SLOT="0"
@@ -32,10 +32,9 @@
        !luajit? ( >=dev-lang/lua-5.1 )
        dev-db/sqlite:3
        dev-libs/glib:2
-       dev-libs/libunique:1
        net-libs/libsoup:2.4
-       net-libs/webkit-gtk:2
-       x11-libs/gtk+:2
+       net-libs/webkit-gtk:4
+       x11-libs/gtk+:3
 "
 
 DEPEND="
@@ -63,7 +62,7 @@
        if use luajit; then
                myconf+=" USE_LUAJIT=1"
        else
-               myconf+=" USE_LUAJIT=0"
+               myconf+=" USE_LUAJIT=0 LUA_PKG_NAME=lua5.1"
        fi
 
        if [[ ${PV} != *9999* ]]; the
Comment 8 herminio.hernandezjr 2016-07-10 06:18:08 UTC
I am use your patch and test it using my local overlay. The only this I would is pcc and ppc64 to keywords. I am running Gentoo on PowerBook G4 and a PowerMac G5.
Comment 9 Franz Trischberger 2016-07-10 07:32:08 UTC
(In reply to herminio.hernandezjr from comment #8)
> I am use your patch and test it using my local overlay. The only this I
> would is pcc and ppc64 to keywords. I am running Gentoo on PowerBook G4 and
> a PowerMac G5.

live ebuilds are usually unkeyworded, so there won't be ppc and ppc64 for -9999.
The snapshot part also needs some work (left that as it was besides updating to the new upstream, because currently there are no webkit2/gtk3-releases yet). Either we use our own snapshots from time to time or we drop that part from the ebuild until upstream (luakit/luakit or aidanholm/luakit) tag their first webkit2gtk release.
Comment 10 herminio.hernandezjr 2016-07-10 07:45:59 UTC
From what I have noticed luakit/luakit has yet merge the PR to get to webkit-3. I   am going to see if the lead developer is considering using aidanholms/luakit work to move to webkit2gtk.
Comment 11 Franz Trischberger 2016-07-10 07:51:52 UTC
(In reply to herminio.hernandezjr from comment #10)
> From what I have noticed luakit/luakit has yet merge the PR to get to
> webkit-3. I   am going to see if the lead developer is considering using
> aidanholms/luakit work to move to webkit2gtk.

It looks like it won't happen too soon:
https://github.com/aidanholm/luakit/issues/82#issuecomment-231575660
Comment 12 herminio.hernandezjr 2016-07-10 08:00:14 UTC
I know that is my thread I started.
Comment 13 Franz Trischberger 2016-07-10 08:11:58 UTC
(In reply to herminio.hernandezjr from comment #12)
> I know that is my thread I started.

Hm, OK, I already thought it was you (but one never knows ;)).

BTW.: webkitgtk-3.0.pc (whic his what http://github.com/luakit/luakit/pull/224 tries to do) won't change anything regarding this removal request as it requires the old, unmaintained and insecure version of webkit-gtk. It needs to be webkit2gtk-4.0.pc (which AFAIK requires >=webkit-gtk-2.6, or was it 2.8?).
Comment 14 herminio.hernandezjr 2016-07-10 08:53:00 UTC
ok based on what adain said do you have a problem with the 9999.eduild to be based on his fork?
Comment 15 herminio.hernandezjr 2016-07-11 08:41:01 UTC
Frnaz,

Where you able to successfully build the package? I am getting this error:

widgets/overlay.c: In function ‘luaH_overlay_reorder_child’:
widgets/overlay.c:55:5: warning: implicit declaration of function ‘gtk_overlay_reorder_overlay’ [-Wimplicit-function-declaration]
     gtk_overlay_reorder_overlay(GTK_OVERLAY(w->widget), GTK_WIDGET(child->widget), pos);
     ^
powerpc-unknown-linux-gnu-gcc -c widgets/spinner.c -o widgets/spinner.o
powerpc-unknown-linux-gnu-gcc -c widgets/image.c -o widgets/image.o
powerpc-unknown-linux-gnu-gcc -c widgets/eventbox.c -o widgets/eventbox.o
powerpc-unknown-linux-gnu-gcc -c common/tokenize.c -o common/tokenize.o
powerpc-unknown-linux-gnu-gcc -o luakit.so extension/scroll.o extension/script_world.o extension/extension.o extension/msg.o extension/luajs.o extension/clib/extension.o extension/clib/dom_element.o extension/clib/dom_document.o extension/clib/page.o extension/clib/ui_process.o common/luaserialize.o common/luaclass.o common/msg.o common/property.o common/luauniq.o common/luautil.o common/util.o common/luaobject.o common/luajs.o common/tokenize.o
powerpc-unknown-linux-gnu-gcc -o luakit luakit.o luah.o msg.o common/luaserialize.o common/luaclass.o common/msg.o common/property.o common/luauniq.o common/luautil.o common/util.o common/luaobject.o common/luajs.o clib/sqlite3.o clib/unique.o clib/xdg.o clib/luakit.o clib/download.o clib/web_module.o clib/stylesheet.o clib/widget.o clib/timer.o clib/soup/cookiejar.o clib/soup/soup.o widgets/socket.o widgets/label.o widgets/entry.o widgets/webview.o widgets/common.o widgets/notebook.o widgets/box.o widgets/scrolled.o widgets/paned.o widgets/overlay.o widgets/window.o widgets/spinner.o widgets/image.o widgets/eventbox.o common/tokenize.o
widgets/overlay.o: In function `luaH_overlay_reorder_child':
overlay.c:(.text+0x2b8): undefined reference to `gtk_overlay_reorder_overlay'
collect2: error: ld returned 1 exit status
Makefile:55: recipe for target 'luakit' failed
make: *** [luakit] Error 1
 * ERROR: www-client/luakit-9999::rican-linux failed (compile phase):
 *   emake failed
 * 
 
Now my C is really basic but this error looks like the function 'gtk_overlay_reorder_overlay' is not defined in gtk-3.0. I searched /usr/inlcude/gtk-3.0 and could not find it either

gentoo-ppc Documents # grep -r gtk_overlay /usr/include/gtk-3.0
/usr/include/gtk-3.0/gtk/gtkoverlay.h:#define GTK_TYPE_OVERLAY             (gtk_overlay_get_type ())
/usr/include/gtk-3.0/gtk/gtkoverlay.h:GType      gtk_overlay_get_type    (void) G_GNUC_CONST;
/usr/include/gtk-3.0/gtk/gtkoverlay.h:GtkWidget *gtk_overlay_new         (void);
/usr/include/gtk-3.0/gtk/gtkoverlay.h:void       gtk_overlay_add_overlay (GtkOverlay *overlay,

However it is defined in the gtk-3 reference manual... Am I missing something?
Comment 16 Franz Trischberger 2016-07-11 08:54:25 UTC
Which gtk version do you have installed?
Could you upload the entire build.log?
For me it (of course) built fine, oterwse I wouldn't have posted the ebuild ;)
Comment 17 herminio.hernandezjr 2016-07-11 09:18:11 UTC
I have gtk+-3.16 installed. However I checked packages.gentoo.org that gtk+-3.18 is listed as stable for ppc. So I am updating my @world and will try again. I will post my build log soon.
Comment 18 herminio.hernandezjr 2016-07-11 09:37:13 UTC
Created attachment 440344 [details]
build log

here is my build log
Comment 19 Franz Trischberger 2016-07-11 15:43:05 UTC
(In reply to herminio.hernandezjr from comment #18)
> Created attachment 440344 [details]
> build log
> 
> here is my build log

Is that build.log with gtk+-3.16 or gtk+-3.18?
AFAICS that function got introduced with 3.18:

GDK_AVAILABLE_IN_3_18
void       gtk_overlay_reorder_overlay (GtkOverlay     *overlay,
					GtkWidget      *child,
					gint            position);
Comment 20 herminio.hernandezjr 2016-07-12 04:40:17 UTC
Created attachment 440402 [details]
ebuild

The build log was against gtk3.16. This morning I updated @world and am now using gtk3.18. I was ablt to build luakit. However the browser keeps crashing. I have placed a bug report upstresam if you want to see what it is. I am attaching my ebuild so you can see what I did. The only difference from your diff is that for me I need to have this LUA_PKG_NAME=lua instead of LUA_PKG_NAME=lua5.1. 'lua5.1' was not recognized by pkg-config.

rican-linux@gentoo-ppc ~/Documents $ pkg-config --list-all |grep lua
lua                                 Lua - An Extensible Extension Language
Comment 21 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-08-10 16:19:35 UTC
I'm sorry but this is taking too long, with no clear perspective. When luakit is usable again, we'll start over with no legacy.


commit 2963b7d8bed43469f1f217d6fc57852886910361
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: Wed Aug 10 18:13:03 2016
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: Wed Aug 10 18:16:50 2016

    www-client/luakit: Remove last-rited pkg, #584186
Comment 22 herminio.hernandezjr 2016-08-10 17:07:51 UTC
I am sorry for the late response. The package does build with the new ebuild using the newer WebKit.