Bug 583726 – media-libs/svgalib-1.9.25-r5 compile failure with kernel 4.6.0: error: initialization from incompatible pointer type

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ed Catmur 2016-05-21 21:47:17 UTC]

make: Entering directory '/usr/src/linux-4.6.0-gentoo'
  CC [M]  /var/tmp/portage/media-libs/svgalib-1.9.25-r5/work/svgalib-1.9.25/kernel/svgalib_helper/main.o
/var/tmp/portage/media-libs/svgalib-1.9.25-r5/work/svgalib-1.9.25/kernel/svgalib_helper/main.c:616:22: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
    .unlocked_ioctl = svgalib_helper_ioctl,
                      ^
/var/tmp/portage/media-libs/svgalib-1.9.25-r5/work/svgalib-1.9.25/kernel/svgalib_helper/main.c:616:22: note: (near initialization for ‘svgalib_helper_fops.unlocked_ioctl’)
/var/tmp/portage/media-libs/svgalib-1.9.25-r5/work/svgalib-1.9.25/kernel/svgalib_helper/main.c: In function ‘svgalib_helper_open’:
/var/tmp/portage/media-libs/svgalib-1.9.25-r5/work/svgalib-1.9.25/kernel/svgalib_helper/main.c:466:4: warning: ignoring return value of ‘request_irq’, declared with attribute warn_unused_result [-Wunused-result]
    request_irq(i, vsync_interrupt, IRQF_SHARED, "svgalib_helper", sh_pci_devs[minor]);
    ^
/var/tmp/portage/media-libs/svgalib-1.9.25-r5/work/svgalib-1.9.25/kernel/svgalib_helper/main.c: In function ‘svgalib_helper_ioctl’:
/var/tmp/portage/media-libs/svgalib-1.9.25-r5/work/svgalib-1.9.25/kernel/svgalib_helper/main.c:378:21: warning: ignoring return value of ‘request_irq’, declared with attribute warn_unused_result [-Wunused-result]
                     request_irq(irqs[i++], vsync_interrupt, IRQF_SHARED, "svgalib_helper", sdev_id);
                     ^
cc1: some warnings being treated as errors
scripts/Makefile.build:291: recipe for target '/var/tmp/portage/media-libs/svgalib-1.9.25-r5/work/svgalib-1.9.25/kernel/svgalib_helper/main.o' failed
make[1]: *** [/var/tmp/portage/media-libs/svgalib-1.9.25-r5/work/svgalib-1.9.25/kernel/svgalib_helper/main.o] Error 1
Makefile:1428: recipe for target '_module_/var/tmp/portage/media-libs/svgalib-1.9.25-r5/work/svgalib-1.9.25/kernel/svgalib_helper' failed
make: *** [_module_/var/tmp/portage/media-libs/svgalib-1.9.25-r5/work/svgalib-1.9.25/kernel/svgalib_helper] Error 2
make: Leaving directory '/usr/src/linux-4.6.0-gentoo'

[Comment 1 Ed Catmur 2016-05-21 21:58:18 UTC]

Created attachment 434918 [details, diff]
linux-4.6.0.patch

[Comment 2 Ed Catmur 2016-05-21 22:10:20 UTC]

note: linux 4.6.0 added -Werror=incompatible-pointer-types to KBUILD_CFLAGS in ea8daa7 (https://github.com/torvalds/linux/commit/ea8daa7b97842aab8507b5b5b1e3226cf2d514a6)

[Comment 3 Ed Catmur 2016-05-21 22:14:41 UTC]

Looking at it, that ioctl has been long(*)(file*, unsigned, unsigned int) forever, so it would make more sense to fix files/svgalib-1.9.25-linux_2.6.36-r1.patch.

[Comment 4 Ed Catmur 2016-05-21 22:15:34 UTC]

Created attachment 434920 [details, diff]
svgalib-1.9.25-linux_2.6.36-r1.patch

Fixed svgalib-1.9.25-linux_2.6.36-r1.patch

[Comment 5 Andrew Savchenko 2016-05-25 07:58:07 UTC]

Fixed in tree, thanks.

No revbump, refetch tree if needed.