The pull request results in the following commits in the repo: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3ae2461de34ec9ec29c797260e54f8c6e11808a7 https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a7a6d00357859094ff31fcbaf4eba09de9360022 https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37e876bc29f2c811383c3d0fdc8d7478ecab9578 https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e57b6b19fd483bd337cfbbfdd6f18096e374b13f These commits break atomicity, use the same commit message, apply to the same ebuild without any revision bumps where changes include EAPI bumps and major RDEPEND changes, and improperly update the Manifest. There are also other QA issues with the submission such as gettext in RDEPEND, unquoted variables etc. The submission was reviewed, signed off by and committed by Ian Delaney, CC'ing him to the bug.
I'm the person responsible for the orignal PR that got pulled here -> I'll have a look at the content that got in. There were multiple pushes in the PR and not all of them were ok. -- Antti Järvinen
These points appear mostly intense nit pick. Either way they are reverted and no longer in place in the tree.
(In reply to Ian Delaney from comment #2) > These points appear mostly intense nit pick. > Either way they are reverted and no longer in place in the tree. Maybe we should ask for some more reviews before things are pushed to the main repo (or a "reviewers" team)?
There were some additional QA issues identified in the PR https://github.com/gentoo/gentoo/pull/1327 so I'll close the PR and open a new one that contains a cleaned version of the ebuild -> this ticket can be closed as my understanding is that commits listed by Götürk have already been reverted in the repository.
All right Sirs, here https://github.com/gentoo/gentoo/pull/1406 is a 2nd try of the version bump for review, comments welcome. -- Antti
Oh my, this one's old.
