Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 580950 - app-emulation/xen-tools-4.6.1-r1 : tap-ctl-allocate.c:109:29: error: implicit declaration of function ‘makedev’ [-Werror=implicit-function-declaration]
Summary: app-emulation/xen-tools-4.6.1-r1 : tap-ctl-allocate.c:109:29: error: implicit...
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Xen Devs
Depends on:
Blocks: glibc-sysmacros
  Show dependency tree
Reported: 2016-04-23 16:36 UTC by Toralf Förster
Modified: 2017-10-12 05:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

app-emulation:xen-tools-4.6.1-r1:20160423-162636.log (app-emulation:xen-tools-4.6.1-r1:20160423-162636.log,501.51 KB, text/plain)
2016-04-23 16:36 UTC, Toralf Förster
emerge-history.txt (emerge-history.txt,381.40 KB, text/plain)
2016-04-23 16:36 UTC, Toralf Förster
environment (environment,149.35 KB, text/plain)
2016-04-23 16:36 UTC, Toralf Förster
Patch to fix compile failure (part 1) (fix-tap-ctl.patch,329 bytes, patch)
2016-04-26 05:51 UTC, Pat Erley
Details | Diff
Fixes build (fix-tap-ctl.patch,707 bytes, patch)
2016-04-26 06:02 UTC, Pat Erley
Details | Diff
Fixes build v3 (fix-tap-ctl.patch,1.02 KB, patch)
2016-04-26 06:57 UTC, Pat Erley
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2016-04-23 16:36:00 UTC
This bug report feeds bug #575232 (sys-libs/glibc-2.23-r1 breakage).

ork/xen-4.6.1/tools/blktap2/../../tools/libxc/include -I/var/tmp/portage/app-emulation/xen-tools-4.6.1-r1/work/xen-4.6.1/tools/blktap2/../../tools/include -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF .tap-ctl-allocate.opic.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE   -Werror -Wno-unused -I../include -I../drivers -I/var/tmp/portage/app-emulation/xen-tools-4.6.1-r1/work/xen-4.6.1/tools/blktap2/control/../../..//tools/include -I/var/tmp/portage/app-emulation/xen-tools-4.6.1-r1/work/xen-4.6.1/tools/blktap2/control/../../..//tools/libxc/include -I/var/tmp/portage/app-emulation/xen-tools-4.6.1-r1/work/xen-4.6.1/tools/blktap2/control/../../..//tools/include -D_GNU_SOURCE -DTAPCTL  -fPIC -c -o tap-ctl-allocate.opic tap-ctl-allocate.c 
tap-ctl-allocate.c: In function ‘tap_ctl_make_device’:
tap-ctl-allocate.c:109:29: error: implicit declaration of function ‘makedev’ [-Werror=implicit-function-declaration]
  err = mknod(devname, perm, makedev(major, minor));
cc1: all warnings being treated as errors

$ cat emerge-info.txt

  This is an unstable amd64 chroot image (named amd64-gnome-unstable_20160415-104205) at a hardened host acting as a tinderbox.


  make.conf: USE="mmx sse sse2 pax_kernel -cdinstall -oci8 -bindist -apache avx clang compat csc designer dot eglfs fpm ftp -gif -gles2 gpg gstreamer gui -havege -ipv6 -jadetex jpeg lapack libkms logrotate mbox minizip -modplug multimedia multitarget mysqli opencv opengl openmpi pcre16 -png scripts server -sockets sqlite3 sse4_1 system-llvm -tls uml -wma xa xml xmlreader -xscreensaver"

Portage 2.2.28 (python 3.4.3-final-0, default/linux/amd64/13.0/desktop/gnome, gcc-5.3.0, glibc-2.23-r1, 4.4.8-hardened x86_64)
System uname: Linux-4.4.8-hardened-x86_64-Intel-R-_Core-TM-_i7-3770_CPU_@_3.40GHz-with-gentoo-2.2
KiB Mem:    16157888 total,   1821080 free
KiB Swap:   16777212 total,  16719292 free
Timestamp of repository gentoo: Sat, 23 Apr 2016 16:04:13 +0000
sh bash 4.3_p42-r2
ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1
ccache version 3.2.5 [disabled]
app-shells/bash:          4.3_p42-r2::gentoo
dev-java/java-config:     2.2.0-r3::gentoo
dev-lang/perl:            5.22.1::gentoo
dev-lang/python:          2.7.11-r2::gentoo, 3.4.3-r7::gentoo
dev-util/ccache:          3.2.5::gentoo
dev-util/cmake:           3.5.2::gentoo
dev-util/pkgconfig:       0.29.1::gentoo
sys-apps/baselayout:      2.2::gentoo
sys-apps/openrc:          0.20.5::gentoo
sys-apps/sandbox:         2.10-r2::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r2::gentoo
sys-devel/automake:       1.9.6-r4::gentoo, 1.11.6-r2::gentoo, 1.13.4-r1::gentoo, 1.14.1-r1::gentoo, 1.15-r2::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo
sys-devel/gcc:            4.9.3::gentoo, 5.3.0::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r2::gentoo
sys-devel/make:           4.1-r1::gentoo
sys-kernel/linux-headers: 4.5::gentoo (virtual/os-headers)
sys-libs/glibc:           2.23-r1::gentoo

    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://
    priority: 1

    location: /usr/local/portage
    masters: gentoo
    priority: 2

ACCEPT_KEYWORDS="amd64 ~amd64"
CFLAGS="-march=native -O2 -pipe"
CONFIG_PROTECT="/etc /etc/entropy /usr/share/config /usr/share/easy-rsa /var/rancid/.cloginrc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -O2 -pipe"
EMERGE_DEFAULT_OPTS="--verbose-conflicts --color=n --nospinner --tree --quiet-build --accept-properties=-interactive --accept-restrict=-fetch"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS=" rsync:// rsync://"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
USE="X a52 aac acl acpi alsa amd64 avx berkdb bluetooth branding bzip2 cairo cdda cdr clang cli colord compat consolekit cracklib crypt csc cups cxx dbus designer dot dri dts dvd dvdr eds eglfs emboss encode evo exif fam firefox flac fortran fpm ftp gdbm glamor gnome gnome-keyring gnome-online-accounts gpg gpm gstreamer gtk gui iconv introspection jpeg lapack lcms ldap libkms libnotify libsecret logrotate mad mbox minizip mmx mmxext mng modules mp3 mp4 mpeg multilib multimedia multitarget mysqli nautilus ncurses nls nptl ogg opencv opengl openmp openmpi pam pango pax_kernel pcre pcre16 pdf policykit ppds pulseaudio qt3support qt4 readline scripts sdl seccomp server session spell sqlite3 sse sse2 sse4_1 ssl startup-notification svg system-llvm tcpd tiff tracker truetype udev udisks uml unicode upower usb vorbis wxwidgets x264 xa xattr xcb xml xmlreader xv xvid zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en en_GB" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby20 ruby21" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Comment 1 Toralf Förster gentoo-dev 2016-04-23 16:36:06 UTC
Created attachment 431706 [details]
Comment 2 Toralf Förster gentoo-dev 2016-04-23 16:36:09 UTC
Created attachment 431708 [details]
Comment 3 Toralf Förster gentoo-dev 2016-04-23 16:36:12 UTC
Created attachment 431710 [details]
Comment 4 Pat Erley 2016-04-26 05:51:25 UTC
Created attachment 432020 [details, diff]
Patch to fix compile failure (part 1)

I'm betting this got pulled in by one of the other headers.  It will break in libxl after this.  I'll post a patch shortly that fixes both.
Comment 5 Pat Erley 2016-04-26 06:02:18 UTC
Created attachment 432022 [details, diff]
Fixes build

This may be tied to or dependent on specific klibc changes, and I have not tested whether it's functional, but it builds with this patch.
Comment 6 Pat Erley 2016-04-26 06:28:10 UTC
This only fixes system-qemu builds.  Will post a v3 with fixes for non system-qemu.
Comment 7 Pat Erley 2016-04-26 06:57:32 UTC
Created attachment 432036 [details, diff]
Fixes build v3

tested with and without system-qemu.  There are certainly other use combinations that will trigger this failure.  One of the headers used to include the major/minor/makedev macros, which live in sys/sysmacros.h

Verified working on at least pvhvm linux guests, all are probably fine if the build finishes.
Comment 8 Pat Erley 2016-05-05 06:35:21 UTC
Also, (for those that may come across this), my fix is almost definitely not correct, it's just what I needed to make it work on my system.  The fact that a newer klibc broke xen-tools after 4? years of it being fine leads me to believe that it's a klibc bug and not a xen-tools bug.
Comment 9 Ian Delaney (RETIRED) gentoo-dev 2016-05-09 07:20:58 UTC
so how do you CC for dev-libs/klibc; maintainers: (none)??
Comment 10 Pat Erley 2017-09-03 21:10:31 UTC
This bug seems to have crept back in in xen-tools 4.8.1-r1.  Old patch no longer cleanly applies, but it's pretty obvious to figure out how to re-add these.
Comment 11 Tomáš Mózes 2017-10-12 05:50:33 UTC
The patch is included for 4.8.2.