Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 58090 - samba-3.0.5-r1: new ebuild
Summary: samba-3.0.5-r1: new ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High major (vote)
Assignee: Christian Andreetta (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 58529
Blocks: 54640 55119 55121 56683 57063 58030
  Show dependency tree
 
Reported: 2004-07-23 10:14 UTC by Christian Andreetta (RETIRED)
Modified: 2004-09-11 02:00 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Andreetta (RETIRED) gentoo-dev 2004-07-23 10:14:38 UTC
new samba ebuild in portage (masked for all architectures): install with ACCEPT_KEYWORDS="~your_arch" emerge -pv samba
Changes:
+ general -> libs location changes slightly to reflect external tools
               assumptions
          -> compiler options: lowered for all architectures due to possiblity
               of runtime errors
+ ldap -> version bump. usage of dev-perl/Crypt-SmbHash for pwd exchange
+ vfs/antivirus -> version bump

If you have problems with previous version, you can make a try on this :-)

One last _important_ thing: smbldap-tools now use dev-perl/Crypt-SmbHash for pwd hash computing, but it is only tested for sparc and x86, thus breaking dependence tree for ldap installations. Can the other archs test it?
Comment 1 Alberto Garcia Hierro (Skyhusker) 2004-07-23 14:36:23 UTC
First of all, ${ARCH} is independent from ${ACCEPT_KEYWORDS}. The isn't ${ARCH} = "~ppc" nor ${ARCH} = "~x86" nor ${ARCH} = "~foo". So please, correct the ebuild.

The following seems a bug for me, you are replacing flags for all arches and then replacing again for ppc and ppc64

#Fix #57063 ------------------------------------------------------------
        strip-flags
        replace-flags -O? -O1
        for tmp_arch in "ppc" "ppc64" "~ppc" "~ppc64"; do
                if [ "${ARCH}" = "${tmp_arch}" ]; then
                        replace-flags -O? -O1
                        break
                fi
        done
Anyway, the best way of doing this is:
	if [ ${ARCH} = "ppc" -o ${ARCH} = "ppc64" ]
	then
		replace-flags -O? -O1
	fi

In addition, I confirmed this bug on ppc, but I haven't seen anybody reporting it on ppc64. Have you tested it?
Comment 2 Christian Andreetta (RETIRED) gentoo-dev 2004-07-24 02:33:18 UTC
thanks. you're right: duplication of archs in case of "~" mask is useless. i must stop committing after a destructive work day :)
On CFLAGS: i lately added the strip flags for all archs because lowering compiler options reduces some runtime auth errors on x86 and amd also. ppc64: i've not had any test report, but i want to be very cautious at now.
Since samba is in transition between major versions (and some external tools are changing version too), and it has to comply to a  vast use of both the new 2.6 and the old 2.4 kernels, i prefer trade optimization for stability on all archs (for now). Later on, we can relax this.
Comment 3 Alberto Garcia Hierro (Skyhusker) 2004-07-24 07:23:52 UTC
Works fine on ppc, you can keyword it ~ppc. Only one observation:

if [ ${ARCH} = "ppc" -o ${ARCH} = "ppc64" ]; then
	cd ${S} && epatch ${FILESDIR}/samba-3.0.x-smbumount-uid32.patch
fi

According to <a href="http://bugs.gentoo.org/show_bug.cgi?id=46687">#46687</a>, the first line should include ${ARCH} = "amd64"
Comment 4 Daniel Black (RETIRED) gentoo-dev 2004-07-24 08:13:05 UTC
I made a suggestion in bug 56805 suggesting that samba be part of a "virus" group so all antivirus programs can be used by those with generic plugin options (samba-vfs) can communicate to antivirus programs without leaving them open to DoS. Thoughts?
Comment 5 Christian Andreetta (RETIRED) gentoo-dev 2004-07-25 07:31:27 UTC
Alberto (as per comment #3): done. Did you also try Crypt-SmbHash on ppc, by chance?
Comment 6 Christian Andreetta (RETIRED) gentoo-dev 2004-07-25 08:13:33 UTC
Daniel (comment #4): it can be surely done. Only, all antivirus aware programs must be compliant with this. I agree with security's comment #4 on bug #56805. Anyway, one thing ton investigate: non-root run of clamav daemon...
Comment 7 Alberto Garcia Hierro (Skyhusker) 2004-07-26 13:21:04 UTC
USE=ldap emerge =net-fs/samba-3.0.5-r1 builds fine (after adding KEYWORDS=~ppc to Crypt-SmbHash). Do you want me to try any special test?
Comment 8 Christian Andreetta (RETIRED) gentoo-dev 2004-07-27 03:40:19 UTC
Alberto (comment #7): thanks for the test. I'm opening a call for testing on bug #58529
Comment 9 Christian Andreetta (RETIRED) gentoo-dev 2004-09-11 01:50:33 UTC
outdated (and already done ;) ). Closing (reopen if needed)
Comment 10 Christian Andreetta (RETIRED) gentoo-dev 2004-09-11 02:00:05 UTC
closing ;)