Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 580356 - x11-themes/adwaita-icon-theme: Missing dep on gnome-base/librsvg
Summary: x11-themes/adwaita-icon-theme: Missing dep on gnome-base/librsvg
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-17 17:07 UTC by Kristian Fiskerstrand
Modified: 2020-12-06 04:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.txt (build.log,165.79 KB, text/plain)
2016-04-17 17:07 UTC, Kristian Fiskerstrand
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kristian Fiskerstrand gentoo-dev 2016-04-17 17:07:04 UTC
Created attachment 430990 [details]
build.log.txt

Build fails with Can't load file: Unrecognized image file format when tools is not specified as use flag for gnome-base/librsvg
Also see https://forums.gentoo.org/viewtopic-t-1007524-view-next.html
Comment 1 Kristian Fiskerstrand gentoo-dev 2016-09-29 19:41:58 UTC
After some discussion, [tools] is likely not necessary
Comment 2 Mart Raudsepp gentoo-dev 2016-09-30 09:32:15 UTC
So gtk+:3 now ships with a gtk-encode-symbolic-svg, which converts a SVG into a special PNG for faster loading, but supposedly it still is scalable in some special ways or something.
This encoding likely needs to be able to read SVG via gdk-pixbuf, so probably needs librsvg.
This means technically gtk+:3 should rdepend on librsvg, but that's not really acceptable. So we have two choices:

1) gtk-encode-symbolic-svg (build time) using packages need librsvg in DEPEND
2) we split gtk-encode-symbolic-svg to a separate package that RDEPENDs on librsvg too, and packages using gtk-encode-symbolic-svg need to add it to DEPEND

Not sure many other icon themes are even using this yet (or shipping symbolic icnos).
Easiest to just do 1) for adwaita-icon-theme now and contemplate 2) for the long-term.

While this could be a problem for fresh installs when librsvg is pulled in after adwaita-icon-theme (because it's only in RDEPEND, not DEPEND), Kristian says he likely had librsvg already there due to in one case it being an upgrade of adwaita-icon-theme instead.
Comment 3 Mart Raudsepp gentoo-dev 2017-07-31 01:26:05 UTC
I'm adding librsvg and gtk+:3 to build depend to (initially masked) adwaita-icon-theme-3.24 for gtk-encode-symbolic-svg to be able to do its work. I hope it doesn't introduce any circular dependencies that way.

I'm not sure how many other themes ship symbolic icons and want to generate the PNG versions during build, but we should review and at least add the librsvg/gtk+ build deps there too or something. And maybe to adwaita-icon-theme-3.22 too.

Here is some information about the gtk-encode-symbolic-svg utility (it's basically a performance tool for symbolic icons in the common case with gtk+ making use of its results to achieve the perf gain):

This utility loads a symbolic svg at a specified size and renders a png file in a special format that can be recolored later.

https://bugzilla.gnome.org/show_bug.cgi?id=730450
Comment 4 Michael 'veremitz' Everitt 2020-09-29 04:14:03 UTC
Is this still a thing?