Bug 575970 – x11-drivers/xf86-video-intel with sys-libs/glibc-2.23 - .../work/d1672806a5222f00dcc2eb24ccddd03f727f71bc/tools/backlight_helper.c:54:2: error: implicit declaration of function ‘major’ [-Werror=implicit-function-declaration]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Franz Trischberger 2016-02-29 08:40:27 UTC]

Created attachment 426962 [details]
build.log.gz

But IMHO this is not directly due to the removal of sysmacros.h from types.h. They check what to include in the buildsystem, set defines and act according to that. In this case they simply forgot to #include <config.h> in tools/backlight_helper.h

[Comment 1 Rémi Cardona (RETIRED) 2016-02-29 21:01:16 UTC]

I'm confused: major(3) on glibc 2.22 says major() comes from sys/types.h. Has that changed with glibc 2.23 ?

[Comment 2 Chí-Thanh Christopher Nguyễn 2016-02-29 23:21:32 UTC]

This due to a Gentoo-specific change in glibc-2.23.
Other packages are affected too. See the blocked bug and
https://forums.gentoo.org/viewtopic-t-1039602.html
https://forums.gentoo.org/viewtopic-t-1039604.html

[Comment 3 Mike Gilbert 2016-04-14 01:50:48 UTC]

This was (mostly) fixed already upstream.

https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=aa40f990142eb165ee7f60f08e9616bc5bebdebe

[Comment 4 Mike Gilbert 2016-04-14 01:52:15 UTC]

Created attachment 430350 [details, diff]
Include config.h in tools/backlight_helper.c

Here's a patch to complete the upstream code fix.

[Comment 5 Mike Gilbert 2016-04-14 18:08:58 UTC]

*** Bug 579926 has been marked as a duplicate of this bug. ***

[Comment 6 Mike Gilbert 2016-04-15 22:34:08 UTC]

*** Bug 580150 has been marked as a duplicate of this bug. ***

[Comment 7 Lars Wendler (Polynomial-C) (RETIRED) 2016-04-18 08:21:56 UTC]

*** Bug 580394 has been marked as a duplicate of this bug. ***

[Comment 8 SpanKY 2016-12-07 05:20:54 UTC]

sent your patch upstream and added to Gentoo:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7bfe70d0e1ac379f44661c7b783d482052dfe183