Looking at the patches applied in ppsspp-1.1.1-r2, it's apparent that the only thing they do is replace one instance of -O3 with -O2 each. Therefore they can be dropped easily and substituted with one sed call. And since -r2 already has the same exact call for CMakeLists.txt, it's all the more reason to do so.
We could definitely do with a sed call instead of patching out a bunch of files. Can you suggest a patch?
Created attachment 424880 [details, diff] Replace all patches with one sed call Sure, I've attached the ebuild patch. Confirmed it works here.
Perfect. Robin are you happy with the patch and can you sign off on it? I'll merge it afterwards.
pr to fix this https://github.com/gentoo/gentoo/pull/4342
commit 07dcd0e1a674de8b3c71b2e5b34335b3f555eb9f (HEAD) Author: soredake <fdsfgs@krutt.org> AuthorDate: Tue Apr 4 16:17:54 2017 +0300 Commit: Patrice Clement <monsieurp@gentoo.org> CommitDate: Tue Apr 4 23:13:58 2017 +0200 games-emulation/ppsspp: version bump to 1.4. Gentoo-Bug: https://bugs.gentoo.org/583818 Gentoo-Bug: https://bugs.gentoo.org/612826 Gentoo-Bug: https://bugs.gentoo.org/587342 Gentoo-Bug: https://bugs.gentoo.org/574118 Gentoo-Bug: https://bugs.gentoo.org/585722 Closes: https://github.com/gentoo/gentoo/pull/4342 games-emulation/ppsspp/Manifest | 8 ++ games-emulation/ppsspp/files/ppsspp-1.4-O2.patch | 32 ++++++++ .../ppsspp/files/ppsspp-1.4-assets-lookup.patch | 13 ++++ games-emulation/ppsspp/metadata.xml | 8 +- games-emulation/ppsspp/ppsspp-1.4.ebuild | 87 ++++++++++++++++++++++ 5 files changed, 145 insertions(+), 3 deletions(-) create mode 100644 games-emulation/ppsspp/Manifest create mode 100644 games-emulation/ppsspp/files/ppsspp-1.4-O2.patch create mode 100644 games-emulation/ppsspp/files/ppsspp-1.4-assets-lookup.patch create mode 100644 games-emulation/ppsspp/ppsspp-1.4.ebuild
