net-libs/libproxy-0.4.12 was released on 2016-01-12. https://github.com/libproxy/libproxy/releases From NEWS file: "New in version 0.4.12 ============================== * Move development to github.com/libproxy/libproxy * Fix fd leak in get_pac (Bug #185) * Detect running MATE session (Bug #186, Part1). * Fix linking of perl bindings to pthread (Bug #182) * Correctly detect spidermonky (mozjs185) (Bug #188) * Stop pxgsettings from segfaulting on exit (Bug #192) * Fix test #10 (Bug #189) * Fix build on Mac OS X (Bug #183) * Add a generic KDE Config module (fix crashes of Qt5 based apps) (issue#4)" -HOMEPAGE="https://code.google.com/p/libproxy/" +HOMEPAGE="https://github.com/libproxy/libproxy" Support for KDE 5 was added in this version: https://github.com/libproxy/libproxy/commit/bd9bf72e15107e6c6133b438c700dd42d79c9d60 Qt / KDE libraries are no longer used, and kreadconfig5 / kreadconfig executables are called instead: + try { + // Try the KF5 one first + command = "kreadconfig5"; + kde_config_val("proxyType", "-1"); + return; // Worked + } + catch(...) {} + + try { + // The KDE4 one next + command = "kreadconfig"; + kde_config_val("proxyType", "-1"); + return; // Worked + } + catch(...) {} $ qfile -Sv /usr/bin/kreadconfig* kde-apps/kreadconfig-15.08.3:4/15.08 (/usr/bin/kreadconfig) kde-frameworks/kconfig-5.18.0:5/5.18 (/usr/bin/kreadconfig5) So net-libs/libproxy-0.4.12 ebuild probably should have this dependency: RDEPEND="${RDEPEND} kde? ( || ( kde-frameworks/kconfig:5 kde-apps/kreadconfig:4 ) )" This dependency is not needed in DEPEND, adding it only to RDEPEND will suffice. dev-util/automoc should be dropped from DEPEND. Backporting of https://github.com/libproxy/libproxy/commit/8ca0db36983e9154c808288fea4cbdfc9a7ea4c5 is needed to allow usage of -DWITH_KDE option, which replaces -DWITH_KDE4 option. In metadata.xml: -<remote-id type="google-code">libproxy</remote-id> +<remote-id type="github">libproxy/libproxy</remote-id>
And usage of -DWITH_KDE option will not need to be dependent on multilib_is_native_abi: - $(multilib_is_native_abi && cmake-utils_use_with kde KDE4 \ - || echo -DWITH_KDE4=OFF) + $(cmake-utils_use_with kde KDE)
Pull request: https://github.com/gentoo/gentoo/pull/1202
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #0) > dev-util/automoc should be dropped from DEPEND. Why?
(In reply to Jan Chren (rindeal) from comment #3) > (In reply to Arfrever Frehtes Taifersar Arahesis from comment #0) > > dev-util/automoc should be dropped from DEPEND. > Why? dev-util/automoc is needed by find_package(Automoc4 ${_REQ_STRING_KDE4}) in /usr/share/apps/cmake/modules/FindKDE4Internal.cmake needed by find_package(KDE4Internal ${_req} ${_quiet} NO_POLICY_SCOPE) in /usr/share/cmake/Modules/FindKDE4.cmake PREVIOUSLY needed by find_package(KDE4) in libproxy/cmake/modules/config_kde4.cmk of libproxy. libproxy/cmake/modules/config_kde4.cmk was deleted in https://github.com/libproxy/libproxy/commit/bd9bf72e15107e6c6133b438c700dd42d79c9d60.
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #4) > dev-util/automoc is needed by find_package(Automoc4 ${_REQ_STRING_KDE4}) in > /usr/share/apps/cmake/modules/FindKDE4Internal.cmake needed by > find_package(KDE4Internal ${_req} ${_quiet} NO_POLICY_SCOPE) in > /usr/share/cmake/Modules/FindKDE4.cmake PREVIOUSLY needed by > find_package(KDE4) in libproxy/cmake/modules/config_kde4.cmk of libproxy. > libproxy/cmake/modules/config_kde4.cmk was deleted in > https://github.com/libproxy/libproxy/commit/ > bd9bf72e15107e6c6133b438c700dd42d79c9d60. Impressive, thanks for explanation.
There are a few issues that should be considered before: - bug 549734 needs to be finally handled if possible - Looking to Fedora package, it seems that we will need to apply some of their patches to prevent some regressions: http://pkgs.fedoraproject.org/cgit/rpms/libproxy.git/tree/
Further considering https://github.com/libproxy/libproxy/issues/16#issuecomment-200372535 and https://github.com/libproxy/libproxy/issues/23, I think that we should just wait until 0.4.13 is out, which should be out soon and shouldn't require that amount of patches.
0.4.13 is out https://github.com/libproxy/libproxy/releases/tag/0.4.13
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8d9f6c18c2d20221171204129573ca7bc420a974 https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ff43aac18d9a5160d528fefd99abefb3bffa94dc https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d7675df85cdc0851c7ce306290677afb08b8dcbe https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=33aa498599d070ece03bac11c3c2e8af654a937f https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=363d2acb3ff0e2c8aed6bef02972f794ef705c00 https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=33d797b36526be748cc033cf1a3b61391c4e1ee2 https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=91bf5626e2727c05aed63cf56746cd03573773a4 https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9019bc1c5f7bf65ff64e0975dc9807ad4a27ab6a https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=31f7b8ba966287ef92361d2e59193e58dcc6adca
Choices in || ( ... ) should be ordered from best to worst (when applicable), so I suggest to prefer net-libs/webkit-gtk:4= before net-libs/webkit-gtk:3= and kde-frameworks/kconfig:5 before kde-apps/kreadconfig:4. There is WITH_WEBKIT3 option in build system, but seemingly no WITH_WEBKIT option: $ grep -Ei 'option.*webkit' CMakeLists.txt **/*.@(cmake|cmk) CMakeLists.txt:option(WITH_WEBKIT3 "Build against gtk-3 version of webkitgtk" OFF) $ So "-DWITH_WEBKIT=$(multilib_is_native_abi && usex webkit || echo 'OFF')" line in ebuild probably should be deleted.
:= operator within || () is invalid.
Is support for net-libs/webkit-gtk:3 in net-libs/libproxy needed at all? Maybe it could be dropped.
[master bd2a59b] net-libs/libproxy: Fix gmcs detection (#549734) and webkit dependencies (#574046#c10) 1 file changed, 15 insertions(+), 16 deletions(-) rename net-libs/libproxy/{libproxy-0.4.13.ebuild => libproxy-0.4.13-r1.ebuild} (87%)
