Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 573712 - media-sound/clementine - allow building without echonest
Summary: media-sound/clementine - allow building without echonest
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Fat-Zer
URL:
Whiteboard:
Keywords: InVCS
Depends on: 589550
Blocks: 587972 588908
  Show dependency tree
 
Reported: 2016-02-02 21:41 UTC by Thomas Capricelli
Modified: 2016-12-29 16:08 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
clementine-1.3.1-libechonest_removal.patch (clementine-1.3.1-libechonest_removal.patch,22.11 KB, patch)
2016-12-26 16:17 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Capricelli 2016-02-02 21:41:32 UTC
clementine ebuild depends, unconditionnaly, from some "libechonest" which seems to be some online stuff. I'd rather have no information from me at all sent to internet. I'm no privacy zealot, but i think we really don't need internet for everything, especially not for just listening some music.

Moreover, i'm not even sure this is still needed, echonest doesn't appear anywhere, not even in settings.
Comment 1 jms 2016-07-04 09:58:11 UTC
from what I understand echonest is used to provide info about artist,artist picture  similar artist to display in the artist info tab.

And it looks as it doesn't works (no more artist info for me) api key seems invalid

$ clementine
11:49:13.800 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.800 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.800 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.800 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.800 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.801 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.801 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.818 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.820 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.820 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:13.821 WARN  unknown                          QPixmap: It is not safe to use pixmaps outside the GUI thread 
11:49:20.913 DEBUG unknown                          "Error downloading http://developer.echonest.com/api/v4/artist/biographies?api_key=DFLFLJBUF4EGTXHIG&format=xml&name=AC%2FDC - server replied: Forbidden"  
11:49:20.914 DEBUG unknown                          "Error downloading http://developer.echonest.com/api/v4/artist/images?api_key=DFLFLJBUF4EGTXHIG&format=xml&name=AC%2FDC - server replied: Forbidden"  
11:49:20.914 DEBUG unknown                          "Error downloading http://developer.echonest.com/api/v4/artist/search?api_key=DFLFLJBUF4EGTXHIG&format=xml&name=AC%2FDC&limit=false&bucket=id:spotify - server replied: Forbidden"  
11:49:20.914 DEBUG unknown                          "Error downloading http://developer.echonest.com/api/v4/artist/search?api_key=DFLFLJBUF4EGTXHIG&format=xml&name=AC%2FDC&limit=false&bucket=id:songkick - server replied: Forbidden"  
11:49:20.915 DEBUG unknown                          "Error downloading http://developer.echonest.com/api/v4/artist/similar?api_key=DFLFLJBUF4EGTXHIG&format=xml&name=AC%2FDC&min_hotttnesss=0.5 - server replied: Forbidden"  
11:49:20.915 DEBUG unknown                          "Error downloading http://developer.echonest.com/api/v4/artist/terms?api_key=DFLFLJBUF4EGTXHIG&format=xml&name=AC%2FDC&sort=frequency - server replied: Forbidden"  


using 
[I] media-sound/clementine                                                                                                                                                                      
     Available versions:  1.2.3^t (~)1.2.3-r1^t (~)1.3.1-r1 **9999 {amazoncloud ayatana box cdda +dbus debug dropbox googledrive ipod lastfm mms moodbar mtp projectm pulseaudio seafile skydrive system-sqlite test ubuntu-one +udisks udisks_legacy vkontakte wiimote LINGUAS="af ar be bg bn br bs ca cs cy da de el en_CA en_GB eo es es_AR et eu fa fi fr ga gl he he_IL hi hr hu hy ia id is it ja ka kk ko lt lv mr ms my nb nl oc pa pl pt pt_BR ro ru si_LK sk sl sr sr@latin sv te tr tr_TR uk uz vi zh_CN zh_TW"}                                                                    
     Installed versions:  1.3.1-r1(10:45:21 04/07/2016)(cdda dbus dropbox googledrive ipod lastfm mms moodbar mtp projectm pulseaudio udisks -amazoncloud -box -debug -skydrive -test -vkontakte -wiimote LINGUAS="en_GB es fr -af -ar -be -bg -bn -br -bs -ca -cs -cy -da -de -el -en_CA -eo -et -eu -fa -fi -ga -gl -he -he_IL -hi -hr -hu -hy -ia -id -is -it -ja -ka -kk -ko -lt -lv -mr -ms -my -nb -nl -oc -pa -pl -pt -pt_BR -ro -ru -si_LK -sk -sl -sr -sr@latin -sv -te -tr -tr_TR -uk -uz -vi -zh_CN -zh_TW")
     Homepage:            http://www.clementine-player.org https://github.com/clementine-player/Clementine
     Description:         A modern music player and library organizer based on Amarok 1.4 and Qt4


[I] media-libs/libechonest
     Available versions:  2.0.2^t (~)2.2.0-r1(0/2.2)^t (~)2.3.0(0/2.3)^t (~)2.3.1(0/2.3)^t (~)2.3.1-r1(0/2.3)^t **9999(0/2.3)^t {+qt4 qt5}
     Installed versions:  2.3.1-r1^t(11:48:01 04/07/2016)(qt4 qt5)
     Homepage:            https://projects.kde.org/projects/playground/libs/libechonest
     Description:
Comment 2 jms 2016-07-04 11:38:11 UTC
there is a bug about this (make echonest optional)for clementine
making echonest optional:
https://github.com/clementine-player/Clementine/issues/5384

but it looks lie echonest has been removed see

Artist Info is broken because EchoNest shutdown:
https://github.com/clementine-player/Clementine/issues/5416
Comment 3 Fat-Zer 2016-08-07 09:07:27 UTC
The echonest support was already removed from the upstream and replaced with the search of information on the wikipedia. The backport of those patches will be quite messy, so I'd prefer to keep the current stable release as-is. The live ebuild already doesn't depend upon libechonest. Closing in two weeks if no further objections.
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-12-26 16:17:51 UTC
Created attachment 457442 [details, diff]
clementine-1.3.1-libechonest_removal.patch

Here's a backported patch which I am using since creation of this bug request. I'm all in favor of applying this patch. Please re-consider your decision.
Comment 5 Fat-Zer 2016-12-26 22:31:20 UTC
ok, let it be so... https://github.com/gentoo/gentoo/pull/3246
Comment 6 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-12-26 23:42:29 UTC
commit 435d5fdb52747acb507a0cbc1fec3778110e0a37
Author: Alexander Golubev <fatzer2@gmail.com>
Date:   Mon Dec 26 23:23:30 2016

    media-sound/clementine-1.3.1: drop echonest support

    Gentoo Bug: 573712
    Thanks for the patch to Lars Wendler.

    Also rename the recently added patch 'clementine-chromaprint14' to meet
    gentoo patch naming suggestions.
    Closes: https://github.com/gentoo/gentoo/pull/3246
Comment 7 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-12-26 23:44:48 UTC
Sorry I was too quick in closing this bug...